User got renamed however filters modified/created with his old username are still shown with the old username in logs & histories of the extension.
Thanks.
URL: https://es.wikipedia.org/wiki/Especial:AbuseFilter
See Also:
Description
Description
Details
Details
- Reference
- bz25377
| Subject | Repo | Branch | Lines +/- | |
|---|---|---|---|---|
| Integrate with Renameuser | mediawiki/extensions/AbuseFilter | master | +23 -0 |
| Status | Subtype | Assigned | Task | ||
|---|---|---|---|---|---|
| Open | None | T25135 blocking user is not updated after rename | |||
| Open | None | T28816 RenameUser should log out target user to prevent unwanted recreation of old username | |||
| Stalled | None | T27377 Update username in AbuseFilter interface when user is renamed using Renameuser | |||
| Open | None | T158495 UserCache should allow for usernames on other wikis | |||
| Open | None | T188180 Read from and write to `actor` table in AbuseFilter | |||
| Open | None | T86943 AbuseLog search not working on global hits | |||
| Resolved | Ladsgroup | T333332 Add af_actor/afh_actor fields to wmf wikis | |||
| Resolved | Zabe | T334295 Write to af_actor/afh_actor in production | |||
| Resolved | Ladsgroup | T336224 Run MigrateActorsAF on all wikis | |||
| Stalled | None | T337920 Stop writing to af_user(_text)/afh_user(_text) | |||
| Resolved | Zabe | T337921 Make af_actor and afh_actor accessible in Wiki Replicas | |||
| Resolved | Zabe | T355616 Start reading from af_actor/afh_actor | |||
| Open | None | T361996 Remove deprecated fields from Wiki Replicas |
Event Timeline
Comment Actions
The same problem happens with the CodeReview extension. Is this something that could be fixed in both extensions at once?
Comment Actions
thogol wrote:
I want to add that a search for the old username does not give any results with the log, despite the fact that the old username does still appear in the log (you get there only by searching for the *new* username which does in fact *not* appear in the log). It's very confusing. :)
Best regards.
Comment Actions
This is because user renaming is not a MediaWiki core feature. We use Extension:Renameuser.
Extension:Renameuser provides several hooks for other extensions to register their tables/columns that need updating in case of a rename.
So it is correct that this is a request for the AbuseFilter extension to use those hooks.
Comment Actions
Change 145156 had a related patch set uploaded by Legoktm:
Use user id to get a logged in user's name
Comment Actions
I agree that the user text needs to be updated from the old username to the new username. Otherwise, viewing the abuse filter log for the new username would just say "No results" or new entries after the rename instead of the entries prior to the rename. We should also make UserCache work globally. Once that happens, please try to merge Change 145156.
Comment Actions
While it might not completely fix the problem for global filters, would a hook "onRenameUserSQL" in the style of this patch to CheckUser solve most of this problem?
Comment Actions
Given that T167246 is not progressing really, I'm okay with implementing a temporary partial solution as described by @ST47. @Daimona and @matej_suchanek what do you think?
Comment Actions
The task to wait for was T188180. But this can work without that for abuse_filter and abuse_filter_history. abuse_filter_log is complicated because of global filters and other issues.
Comment Actions
Change 631182 had a related patch set uploaded (by Matěj Suchánek; owner: Matěj Suchánek):
[mediawiki/extensions/AbuseFilter@master] Integrate with Renameuser
Comment Actions
Change 631182 merged by jenkins-bot:
[mediawiki/extensions/AbuseFilter@master] Integrate with Renameuser
Comment Actions
Just came to report this, but it seems to have been done already
Can existing entries be fixed via script?
Comment Actions
I'd say no. The existing entries will be fixed by the actor migration, which is going to require a maintenance script anyway.
Comment Actions
The remaining part is blocked on several limitations that cannot be reasonably resolved within the project.
Comment Actions
Can the "rename" problem be avoided by having the userid (which doesn't change in renames) be captured in to the AF data, then use that?