Page MenuHomePhabricator

Expand existing browser tests
Closed, ResolvedPublic

Description

The two browser tests, that should be existing by the point that this ticket is tackled, need to be expanded to cover a reasonable amount of the behavior of Query Builder.

We want three browser tests:

1. Happy path:
  • add a string property and some value and change the ValueRelationship to "not matching"
  • add a item property and some value and negate it
  • add an external-id property and change the ValueRelationship to "regardless of value" and connect it with "OR" to the previous condition
  • add a property with limited support
  • run the query
  • assert that the iframe has the correct source, i.e. sparql

Maybe this should also include some more assertions, e.g. that the value input is disabled with "regardless of value" and maybe different values of the reference-dropdown

2. Deviation
  • ?
  • Maybe something related to reconstructing the query from the URL? (This is not yet ready)
3. Error:
  • try to run the query without any input, assert that the notification is shown to add input
  • add a property, but no value, try to run the query, and assert that there is an error on the value
  • add a value and an empty second condition, try to run the query, and assert that there are no errors on the first condition and two errors on the second
  • delete the second condition and try to run the query and confirm the it runs successfully and the sparql (i.e. iframe-src) is as expected

Related Objects

StatusSubtypeAssignedTask
Resolved amy_rc
Resolved bete