Page MenuHomePhabricator

Help desk errors out when GEHelpPanelAskMentor is true and there are no mentors available
Closed, ResolvedPublic

Description

While looking into T273776, I noticed that help panel errors out when GEHelpPanelAskMentor is set to true and there are no mentors available. That should be fixed, so help desk simply does not allow any questions to be asked in such a scenario.

Event Timeline

Change 670021 had a related patch set uploaded (by Urbanecm; owner: Urbanecm):
[mediawiki/extensions/GrowthExperiments@master] Make help panel fallback to help desk if no mentor is available

https://gerrit.wikimedia.org/r/670021

Urbanecm_WMF triaged this task as High priority.
Urbanecm_WMF moved this task from Incoming to Code Review on the Growth-Team (Current Sprint) board.

High => breaks help panel on several wikis.

@Urbanecm_WMF is this the same issue as T276759: TypeError: title is undefined? Could you say more about which wikis, and how it breaks exactly (error message)? Thanks!

@Urbanecm_WMF is this the same issue as T276759: TypeError: title is undefined? Could you say more about which wikis, and how it breaks exactly (error message)? Thanks!

The error from console:

Uncaught TypeError: Cannot read property 'replace' of undefined

Traceback is at P14678.

I'd say it's a different error, considering you filled T276759 before the deployment of T275908.

Change 670021 merged by jenkins-bot:
[mediawiki/extensions/GrowthExperiments@master] Make help panel fallback to help desk if no mentor is available

https://gerrit.wikimedia.org/r/670021

Change 670108 had a related patch set uploaded (by Urbanecm; owner: Urbanecm):
[mediawiki/extensions/GrowthExperiments@wmf/1.36.0-wmf.34] Make help panel fallback to help desk if no mentor is available

https://gerrit.wikimedia.org/r/670108

Change 670109 had a related patch set uploaded (by Urbanecm; owner: Urbanecm):
[mediawiki/extensions/GrowthExperiments@wmf/1.36.0-wmf.33] Make help panel fallback to help desk if no mentor is available

https://gerrit.wikimedia.org/r/670109

Change 670108 merged by jenkins-bot:
[mediawiki/extensions/GrowthExperiments@wmf/1.36.0-wmf.34] Make help panel fallback to help desk if no mentor is available

https://gerrit.wikimedia.org/r/670108

Change 670109 merged by jenkins-bot:
[mediawiki/extensions/GrowthExperiments@wmf/1.36.0-wmf.33] Make help panel fallback to help desk if no mentor is available

https://gerrit.wikimedia.org/r/670109

Mentioned in SAL (#wikimedia-operations) [2021-03-09T12:16:16Z] <urbanecm@deploy1002> Synchronized php-1.36.0-wmf.33/extensions/GrowthExperiments/: dbd6f0cb299bcfb6648b351e1476100fe669cc58: Make help panel fallback to help desk if no mentor is available (T275908; T273782) (duration: 01m 01s)

Urbanecm_WMF added a subscriber: Etonkovidova.

@Etonkovidova Hello, this is the bug that made dawiki help panel gone temporarily. Moving to QA, as it should be fixed (at least it works for me now :)).

@Etonkovidova Hello, this is the bug that made dawiki help panel gone temporarily. Moving to QA, as it should be fixed (at least it works for me now :)).

Checked. Also tested betalabs for the case when Wikipedia:Mentors page is blank - all seem to be fine.