Page MenuHomePhabricator
Create Task
Maniphest T273785

Deal with release of npm 7
Closed, ResolvedPublic
Actions

Description

  • Alert teams to not upgrade locally until things are ready
  • Upgrade CI containers/jobs to provide npm 7 (backwards-compatible)
  • Upgrade LibUp container to use npm 7
  • Tell teams to feel free to switch
  • Migrate repos to use npm 7 (package-lock.json lockfileversion 2)
  • Switch Fresh to use a npm 7 container

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
Update npm lockfileVersion to v2wikimedia/portals/deploymaster+5 K -12
Update npm lockfileVersion to v2mediawiki/extensions/RelatedArticlesmaster+14 K -16
Customize query in gerrit

Related Objects
Search...

Event Timeline

Jdforrester-WMF created this task.Feb 3 2021, 5:03 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptFeb 3 2021, 5:03 PM
Jdforrester-WMF removed a subtask: T273811: Upgrade integration/npm to 7.x.Feb 3 2021, 8:15 PM
Legoktm updated the task description. (Show Details)Feb 3 2021, 8:15 PM
Volker_E subscribed.Apr 18 2021, 7:16 PM
Volker_E updated the task description. (Show Details)Apr 22 2021, 12:58 PM
KartikMistry subscribed.Sep 22 2021, 6:49 AM
Lucas_Werkmeister_WMDE subscribed.Oct 27 2021, 2:02 PM
Lucas_Werkmeister_WMDE mentioned this in T294426: mwgate-node12-docker gate-and-submit builds failing (ENOENT _cacache errors resulting in corrupted tarballs).Oct 27 2021, 2:12 PM
Jdforrester-WMF closed subtask T273812: Upgrade CI containers/jobs to provide npm 7 as Resolved.Oct 27 2021, 3:31 PM
Jdforrester-WMF updated the task description. (Show Details)
Volker_E mentioned this in T295420: Add Codex to LibraryUpgrader monitored repos.Nov 9 2021, 10:59 PM
Volker_E mentioned this in T295036: Migrate all repos to lockfileVersion 2 to avoid "The package-lock.json file was created with an old version of npm".Dec 2 2021, 3:47 PM
Michael subscribed.Dec 2 2021, 3:51 PM
WMDE-Fisch subscribed.Jan 20 2022, 12:33 PM
Umherirrender closed subtask T273810: Prepare libup for npm 7 as Resolved.Jun 20 2022, 4:16 PM
Catrope added a subtask: T295420: Add Codex to LibraryUpgrader monitored repos.Jul 27 2022, 3:47 PM
Jdforrester-WMF removed a subtask: T295420: Add Codex to LibraryUpgrader monitored repos.Jul 27 2022, 3:52 PM
Jdforrester-WMF added a parent task: T295420: Add Codex to LibraryUpgrader monitored repos.
Jdforrester-WMF updated the task description. (Show Details)Jul 27 2022, 4:24 PM
zeljkofilipin subscribed.EditedJan 23 2023, 1:07 PM

Migrate repos to use npm 7 (package-lock.json lockfileversion 2) is marked as resolved, but it's still at v1 for a few repositories, including RelatedArticles and wikimedia/portals/deploy. For some reason, searching for "lockfileVersion": 1 in both codesearch and codesearch-beta doesn't list RelatedArticles and wikimedia/portals/deploy.

zeljkofilipin added a project: User-zeljkofilipin.Jan 23 2023, 1:07 PM
zeljkofilipin moved this task from Backlog 🪒 to Deep work 🌊 on the User-zeljkofilipin board.
zeljkofilipin mentioned this in T325059: Delete WebdriverIO package from devDependencies for all repositories.Jan 23 2023, 1:11 PM
Michael added a comment.Jan 23 2023, 1:42 PM
In T273785#8548853, @zeljkofilipin wrote:

[...] searching for "lockfileVersion": 1 in both codesearch and codesearch-beta [...]

Thanks for sharing those links. I created a task to migrate wikibase-termbox: T327652

gerritbot added a comment.Jan 23 2023, 3:38 PM

Change 882669 had a related patch set uploaded (by Zfilipin; author: Zfilipin):

[mediawiki/extensions/RelatedArticles@master] Update npm lockfileVersion to v2

https://gerrit.wikimedia.org/r/882669

gerritbot added a project: Patch-For-Review.Jan 23 2023, 3:38 PM
gerritbot added a comment.Jan 23 2023, 3:49 PM

Change 882676 had a related patch set uploaded (by Zfilipin; author: Zfilipin):

[wikimedia/portals/deploy@master] Update npm lockfileVersion to v2

https://gerrit.wikimedia.org/r/882676

gerritbot added a comment.Jan 23 2023, 3:58 PM

Change 882669 merged by jenkins-bot:

[mediawiki/extensions/RelatedArticles@master] Update npm lockfileVersion to v2

https://gerrit.wikimedia.org/r/882669

ReleaseTaggerBot added a project: MW-1.40-notes (1.40.0-wmf.20; 2023-01-23).Jan 23 2023, 4:00 PM
zeljkofilipin moved this task from Deep work 🌊 to Waiting 🏹 on the User-zeljkofilipin board.Jan 25 2023, 5:21 PM
Jdrewniak mentioned this in T331304: Remove selenium tests from portals/deploy repo.Mar 6 2023, 3:31 PM
gerritbot added a comment.Mar 17 2023, 2:39 PM

Change 882676 abandoned by Zfilipin:

[wikimedia/portals/deploy@master] Update npm lockfileVersion to v2

Reason:

https://gerrit.wikimedia.org/r/882676

Maintenance_bot removed a project: Patch-For-Review.Mar 17 2023, 3:10 PM
hashar changed the task status from Open to Stalled.Mar 22 2023, 2:07 PM
hashar subscribed.

Marking as Stalled until package-lock.json files have been updated to lockfile version 2: T295036

zeljkofilipin removed a project: User-zeljkofilipin.Mar 22 2023, 2:59 PM
Jdforrester-WMF closed this task as Resolved.Mar 22 2023, 3:03 PM
Jdforrester-WMF claimed this task.
Jdforrester-WMF closed subtask T327652: Migrate termbox to lockfileVersion 2 in package-lock.json as Resolved.
In T273785#8718012, @hashar wrote:

Marking as Stalled until package-lock.json files have been updated to lockfile version 2: T295036

Calling this done, at last.

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits