Page MenuHomePhabricator

load.php outputs HTML on exceptions
Closed, ResolvedPublic

Description

It outputs the standard "Internal error" page. Probably, it should output something like "/* Internal error: [error message] */" instead, but certainly not HTML. Discovered while investigating bug 25338.


Version: 1.17.x
Severity: normal

Details

Reference
bz25386

Event Timeline

bzimport raised the priority of this task from to Normal.Nov 21 2014, 11:22 PM
bzimport set Reference to bz25386.
MaxSem created this task.Oct 1 2010, 3:55 PM

Note that we can only fix this to a certain degree. We can change what the exception handler outputs for load.php, but uncatchable fatal errors will still be output as HTML.

There's a comment in the code to this effect - it's on the todo list, thanks for filing a bug for it.

I think this can be closed, exceptions are now output as /* exception content */ comments in both JS and CSS.

(In reply to comment #3)

I think this can be closed, exceptions are now output as /* exception content
*/ comments in both JS and CSS.

This wasn't true, you probably meant PHP warnings. Exceptions were done in r78924.