Page MenuHomePhabricator
Create Task
Maniphest T273866

Kubernetes prod and staging share the same cluster key in hiera
Closed, ResolvedPublic
Actions

Description

I stumbled upon this fact as I was looking at the etcd dashboard. It filters by label "cluster" which is generated puppet via prometheus::class_config from hiera key cluster: which we set to kubernetes for prod and staging:

hieradata/role/common/etcd/kubernetes.yaml:cluster: kubernetes
hieradata/role/common/etcd/networking.yaml:cluster: kubernetes
hieradata/role/common/etcd/v3/kubernetes.yaml:cluster: kubernetes
hieradata/role/common/etcd/v3/kubernetes/staging.yaml:cluster: kubernetes
hieradata/role/common/kubernetes/master.yaml:cluster: kubernetes
hieradata/role/common/kubernetes/staging/master.yaml:cluster: kubernetes
hieradata/role/common/kubernetes/staging/worker.yaml:cluster: kubernetes
hieradata/role/common/kubernetes/worker.yaml:cluster: kubernetes

We should probably use kubernetes-staging for staging kubernetes and corresponding etcd, but I'm unsure about the consequences a change like this would have.

Details

Related Changes in Gerrit:
SubjectAuthorRepoBranchLines +/-
Create a new wikimedia_cluster: kubernetes-stagingJMeybohmoperations/puppetproduction+9 -3
Customize query in gerrit

Related Objects
Search...

Event Timeline

JMeybohm created this task.Feb 4 2021, 10:59 AM
JMeybohm triaged this task as Medium priority.
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptFeb 4 2021, 10:59 AM
akosiaris subscribed.Feb 5 2021, 5:12 PM

We should probably use kubernetes-staging for staging kubernetes and corresponding etcd, but I'm unsure about the consequences a change like this would have.

+1. It's been bugging me for a while, but it was always a very low priority since I never really had a strong incentive to "fix it".

As far as consequences, I don't think many. We 'll need to create the icinga groups to not break icinga and we 'll lose some history in dashboards in grafana that filter on the cluster. Maybe some budget related calculation spreadsheets as well. But nothing of that sounds painful.

JMeybohm added a parent task: T244335: Upgrade kubernetes clusters to v1.16.Feb 8 2021, 10:16 AM
JMeybohm claimed this task.Feb 3 2022, 11:12 AM
gerritbot added a comment.Feb 3 2022, 11:13 AM

Change 759470 had a related patch set uploaded (by JMeybohm; author: JMeybohm):

[operations/puppet@production] Create a new wikimedia_cluster: kubernetes-staging

https://gerrit.wikimedia.org/r/759470

gerritbot added a project: Patch-For-Review.Feb 3 2022, 11:13 AM
gerritbot added a comment.Feb 3 2022, 1:02 PM

Change 759470 merged by JMeybohm:

[operations/puppet@production] Create a new wikimedia_cluster: kubernetes-staging

https://gerrit.wikimedia.org/r/759470

Maintenance_bot removed a project: Patch-For-Review.Feb 3 2022, 1:11 PM
Stashbot added a comment.Feb 3 2022, 1:27 PM

Mentioned in SAL (#wikimedia-operations) [2022-02-03T13:27:16Z] <jayme> moved kubernetes staging master,nodes,etcd from wikimedia_cluster "kubernetes" to "kubernetes-staging" - T273866

JMeybohm closed this task as Resolved.Feb 3 2022, 1:27 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits