Page MenuHomePhabricator
Create Task
Maniphest T273871

Typo in login string
Closed, ResolvedPublic
Actions

Description

Assuming that these are both verbs/imperatives and not both nouns,
./src/i18n/en.json: "login": "Register / Login",
should probably be
./src/i18n/en.json: "login": "Register / Log in",
?

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
Refactor:: Fix typo in i18n en.jsonlabs/tools/VideoCutToolmaster+2 -2
Customize query in gerrit

Event Timeline

Aklapper created this task.Feb 4 2021, 12:10 PM
Gopavasanth subscribed.Feb 5 2021, 5:14 AM

@Aklapper, Thanks for pointing!! Also, we need to change
"logout": "Logout" to "logout": "Log Out"

Aklapper added a comment.Feb 5 2021, 9:23 AM

Not sure why that's capitalized, instead of using Log out?

Gopavasanth added a comment.Feb 5 2021, 10:03 AM

@Aklapper inspired from our Phabricator Log Out button :P
but yeah Log out should look good and it will be consistent to Log in :)

SarthakKundra claimed this task.Feb 5 2021, 6:58 PM
gerritbot added a comment.Feb 10 2021, 7:11 PM

Change 663278 had a related patch set uploaded (by SarthakKundra; owner: SarthakKundra):
[labs/tools/VideoCutTool@master] Refactor:: Fix typo in i18n en.json

https://gerrit.wikimedia.org/r/663278

gerritbot added a project: Patch-For-Review.Feb 10 2021, 7:11 PM
gerritbot added a comment.Feb 14 2021, 5:56 PM

Change 663278 merged by jenkins-bot:
[labs/tools/VideoCutTool@master] Refactor:: Fix typo in i18n en.json

https://gerrit.wikimedia.org/r/663278

Gopavasanth added a comment.Feb 14 2021, 6:02 PM

Thanks @SarthakKundra ! The changes are live now: https://videocuttool.wmflabs.org/

Gopavasanth closed this task as Resolved.Feb 14 2021, 6:02 PM
Maintenance_bot removed a project: Patch-For-Review.Feb 14 2021, 6:10 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits