Looking up actor_id and actors will be a relatively often operation, so we need to introduce caching in the ActorStore. Perhaps we could abstract out some of the logic from NameTableStore given that's proven to work and reuse it here.
Description
Description
Details
Details
Related Changes in Gerrit:
| Subject | Repo | Branch | Lines +/- | |
|---|---|---|---|---|
| Add caching to ActorStore | mediawiki/core | master | +122 -6 |
| Status | Subtype | Assigned | Task | ||
|---|---|---|---|---|---|
| Open | None | T272689 Investigate design of UserStore or UserAccountStore | |||
| Resolved | • CCicalese_WMF | T273974 Introduce caching into ActorStore |
Event Timeline
Comment Actions
Perhaps we could abstract out some of the logic from NameTableStore given that's proven to work and reuse it here.
We can have as look, but I don't think it will work. NameTableStore is built on the idea of holding the entire mapping in memory. That's not applicable here.
I think we can just start with a small MapCacheLRU to avoid redundant lookups within the same request.
Comment Actions
Change 664989 had a related patch set uploaded (by Cicalese; owner: Cicalese):
[mediawiki/core@master] WIP: Add caching to ActorStore
Comment Actions
Change 664989 merged by jenkins-bot:
[mediawiki/core@master] Add caching to ActorStore