Page MenuHomePhabricator

Introduce caching into ActorStore
Closed, ResolvedPublic

Description

Looking up actor_id and actors will be a relatively often operation, so we need to introduce caching in the ActorStore. Perhaps we could abstract out some of the logic from NameTableStore given that's proven to work and reuse it here.

Event Timeline

daniel raised the priority of this task from Medium to High.Feb 10 2021, 12:16 PM

Perhaps we could abstract out some of the logic from NameTableStore given that's proven to work and reuse it here.

We can have as look, but I don't think it will work. NameTableStore is built on the idea of holding the entire mapping in memory. That's not applicable here.

I think we can just start with a small MapCacheLRU to avoid redundant lookups within the same request.

Change 664989 had a related patch set uploaded (by Cicalese; owner: Cicalese):
[mediawiki/core@master] WIP: Add caching to ActorStore

https://gerrit.wikimedia.org/r/664989

Change 664989 merged by jenkins-bot:
[mediawiki/core@master] Add caching to ActorStore

https://gerrit.wikimedia.org/r/664989