Page MenuHomePhabricator
Create Task
Maniphest T274151

Clean up Title deprecated methods
Closed, ResolvedPublic
Actions

Description

Title class has a number of soft-deprecated methods, moved into RevisionStore, that are overdue for hard deprecation:

  • ::getPreviousRevisionID
  • ::getNextRevisionID
  • ::getFirstRevision
  • ::getEarliestRevTime

Also hard-deprecated methods that are ready to be dropped:

  • ::countRevisionsBetween
  • ::getAuthorsBetween

Details

Show related patches Customize query in gerrit

Related Objects

Event Timeline

• Pchelolo created this task.Feb 8 2021, 3:38 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptFeb 8 2021, 3:38 PM
daniel triaged this task as Medium priority.Feb 8 2021, 7:38 PM
daniel moved this task from Unsorted pile to PageStore pile on the Platform Team Workboards (MW Expedition) board.
Peter.ovchyn moved this task from PageStore pile to Doing on the Platform Team Workboards (MW Expedition) board.Feb 9 2021, 5:36 PM
gerritbot added a comment.Feb 10 2021, 3:38 PM

Change 663224 had a related patch set uploaded (by Vlad.shapik; owner: Vlad.shapik):
[mediawiki/extensions/ApprovedRevs@master] ApprovedRevsHooks class: replace getPreviousRevisionID with getPreviousRevision

https://gerrit.wikimedia.org/r/663224

gerritbot added a project: Patch-For-Review.Feb 10 2021, 3:38 PM
gerritbot added a comment.Feb 10 2021, 7:24 PM

Change 663280 had a related patch set uploaded (by Vlad.shapik; owner: Vlad.shapik):
[mediawiki/extensions/FlaggedRevs@master] Replace hard deprecated getPreviousRevisionID method with RevisionLookup::getPreviousRevision method

https://gerrit.wikimedia.org/r/663280

gerritbot added a comment.Feb 10 2021, 7:35 PM

Change 663284 had a related patch set uploaded (by Vlad.shapik; owner: Vlad.shapik):
[mediawiki/skins/BlueSpiceCalumma@master] Replace hard deprecated getPreviousRevisionID method with RevisionLookup::getPreviousRevision method

https://gerrit.wikimedia.org/r/663284

gerritbot added a comment.Feb 10 2021, 7:38 PM

Change 663224 merged by jenkins-bot:
[mediawiki/extensions/ApprovedRevs@master] ApprovedRevsHooks class: replace getPreviousRevisionID with getPreviousRevision

https://gerrit.wikimedia.org/r/663224

gerritbot added a comment.Feb 10 2021, 8:33 PM

Change 663297 had a related patch set uploaded (by Vlad.shapik; owner: Vlad.shapik):
[mediawiki/extensions/Echo@master] Replace hard deprecated getPreviousRevisionID method with RevisionLookup::getPreviousRevision method

https://gerrit.wikimedia.org/r/663297

gerritbot added a comment.Feb 11 2021, 12:13 AM

Change 663334 had a related patch set uploaded (by Vlad.shapik; owner: Vlad.shapik):
[mediawiki/extensions/Memento@master] Clean up Title deprecated methods

https://gerrit.wikimedia.org/r/663334

gerritbot added a comment.Feb 11 2021, 12:56 AM

Change 663342 had a related patch set uploaded (by Vlad.shapik; owner: Vlad.shapik):
[mediawiki/extensions/BlueSpiceAuthors@master] Clean up Title deprecated methods

https://gerrit.wikimedia.org/r/663342

gerritbot added a comment.Feb 11 2021, 1:26 AM

Change 663349 had a related patch set uploaded (by Vlad.shapik; owner: Vlad.shapik):
[mediawiki/extensions/BlueSpiceSocialBlog@master] Clean up Title deprecated methods

https://gerrit.wikimedia.org/r/663349

gerritbot added a comment.Feb 11 2021, 1:49 AM

Change 663358 had a related patch set uploaded (by Vlad.shapik; owner: Vlad.shapik):
[mediawiki/extensions/Cargo@master] Clean up Title deprecated methods

https://gerrit.wikimedia.org/r/663358

gerritbot added a comment.Feb 11 2021, 2:42 AM

Change 663371 had a related patch set uploaded (by Vlad.shapik; owner: Vlad.shapik):
[mediawiki/extensions/DeleteOwn@master] Clean up Title deprecated methods

https://gerrit.wikimedia.org/r/663371

gerritbot added a comment.Feb 11 2021, 3:31 AM

Change 663376 had a related patch set uploaded (by Vlad.shapik; owner: Vlad.shapik):
[mediawiki/extensions/BlueSpiceFoundation@master] Clean up Title deprecated methods

https://gerrit.wikimedia.org/r/663376

gerritbot added a comment.Feb 11 2021, 11:16 AM

Change 663371 abandoned by Vlad.shapik:
[mediawiki/extensions/DeleteOwn@master] Clean up Title deprecated methods

Reason:

https://gerrit.wikimedia.org/r/663371

gerritbot added a comment.Feb 11 2021, 11:16 AM

Change 663358 abandoned by Vlad.shapik:
[mediawiki/extensions/Cargo@master] Clean up Title deprecated methods

Reason:

https://gerrit.wikimedia.org/r/663358

gerritbot added a comment.Feb 11 2021, 1:21 PM

Change 663574 had a related patch set uploaded (by Vlad.shapik; owner: Vlad.shapik):
[mediawiki/extensions/Wikibase@master] Clean up Title deprecated methods

https://gerrit.wikimedia.org/r/663574

gerritbot added a comment.Feb 11 2021, 1:51 PM

Change 663574 abandoned by Vlad.shapik:
[mediawiki/extensions/Wikibase@master] Clean up Title deprecated methods

Reason:

https://gerrit.wikimedia.org/r/663574

gerritbot added a comment.Feb 11 2021, 2:23 PM

Change 663390 had a related patch set uploaded (by Pwirth; owner: Vlad.shapik):
[mediawiki/extensions/BlueSpiceAuthors@REL1_35] Clean up Title deprecated methods

https://gerrit.wikimedia.org/r/663390

gerritbot added a comment.Feb 11 2021, 2:38 PM

Change 663342 abandoned by Pwirth:
[mediawiki/extensions/BlueSpiceAuthors@master] Clean up Title deprecated methods

Reason:
Not cherry-pickable due to \Title::toPageIdentity availabe from 1.36

https://gerrit.wikimedia.org/r/663342

gerritbot added a comment.Feb 11 2021, 2:38 PM

Change 663342 restored by Pwirth:
[mediawiki/extensions/BlueSpiceAuthors@master] Clean up Title deprecated methods

https://gerrit.wikimedia.org/r/663342

gerritbot added a comment.Feb 11 2021, 2:38 PM

Change 663390 abandoned by Pwirth:
[mediawiki/extensions/BlueSpiceAuthors@REL1_35] Clean up Title deprecated methods

Reason:
Not cherry-pickable due to \Title::toPageIdentity availabe from 1.36

https://gerrit.wikimedia.org/r/663390

gerritbot added a comment.Feb 11 2021, 2:55 PM

Change 663390 restored by Pwirth:
[mediawiki/extensions/BlueSpiceAuthors@REL1_35] Clean up Title deprecated methods

https://gerrit.wikimedia.org/r/663390

gerritbot added a comment.Feb 11 2021, 2:57 PM

Change 663349 merged by jenkins-bot:
[mediawiki/extensions/BlueSpiceSocialBlog@master] Clean up Title deprecated methods

https://gerrit.wikimedia.org/r/663349

gerritbot added a comment.Feb 11 2021, 3:01 PM

Change 663574 restored by Vlad.shapik:
[mediawiki/extensions/Wikibase@master] Clean up Title deprecated methods

https://gerrit.wikimedia.org/r/663574

gerritbot added a comment.Feb 11 2021, 3:01 PM

Change 663342 merged by jenkins-bot:
[mediawiki/extensions/BlueSpiceAuthors@master] Clean up Title deprecated methods

https://gerrit.wikimedia.org/r/663342

gerritbot added a comment.Feb 11 2021, 3:02 PM

Change 663390 merged by jenkins-bot:
[mediawiki/extensions/BlueSpiceAuthors@REL1_35] Clean up Title deprecated methods

https://gerrit.wikimedia.org/r/663390

Pwirth mentioned this in rEBSD27a94e927c2c: Clean up Title deprecated methods.Feb 11 2021, 3:19 PM
Pwirth mentioned this in rEBSD7f805540c856: Clean up Title deprecated methods.
gerritbot added a comment.Feb 11 2021, 3:49 PM

Change 663594 had a related patch set uploaded (by Vlad.shapik; owner: Vlad.shapik):
[mediawiki/extensions/Video@master] Clean up Title deprecated methods

https://gerrit.wikimedia.org/r/663594

gerritbot added a comment.Feb 11 2021, 4:06 PM

Change 663598 had a related patch set uploaded (by Vlad.shapik; owner: Vlad.shapik):
[mediawiki/extensions/BlueSpiceWikiExplorer@master] Clean up Title deprecated methods

https://gerrit.wikimedia.org/r/663598

• Pchelolo moved this task from Doing to Waiting for Review on the Platform Team Workboards (MW Expedition) board.Feb 11 2021, 6:08 PM
gerritbot added a comment.Feb 12 2021, 6:48 AM

Change 663734 had a related patch set uploaded (by Pwirth; owner: Vlad.shapik):
[mediawiki/extensions/BlueSpiceWikiExplorer@REL1_35] Clean up Title deprecated methods

https://gerrit.wikimedia.org/r/663734

gerritbot added a comment.Feb 12 2021, 6:52 AM

Change 663598 merged by jenkins-bot:
[mediawiki/extensions/BlueSpiceWikiExplorer@master] Clean up Title deprecated methods

https://gerrit.wikimedia.org/r/663598

gerritbot added a comment.Feb 12 2021, 6:54 AM

Change 663734 merged by jenkins-bot:
[mediawiki/extensions/BlueSpiceWikiExplorer@REL1_35] Clean up Title deprecated methods

https://gerrit.wikimedia.org/r/663734

gerritbot added a comment.Feb 12 2021, 6:56 AM

Change 663735 had a related patch set uploaded (by Pwirth; owner: Vlad.shapik):
[mediawiki/skins/BlueSpiceCalumma@REL1_35] Clean up Title deprecated methods

https://gerrit.wikimedia.org/r/663735

gerritbot added a comment.Feb 12 2021, 2:30 PM

Change 663284 merged by jenkins-bot:
[mediawiki/skins/BlueSpiceCalumma@master] Clean up Title deprecated methods

https://gerrit.wikimedia.org/r/663284

gerritbot added a comment.Feb 12 2021, 2:30 PM

Change 663735 merged by jenkins-bot:
[mediawiki/skins/BlueSpiceCalumma@REL1_35] Clean up Title deprecated methods

https://gerrit.wikimedia.org/r/663735

gerritbot added a comment.Feb 12 2021, 2:37 PM

Change 663376 merged by jenkins-bot:
[mediawiki/extensions/BlueSpiceFoundation@master] Clean up Title deprecated methods

https://gerrit.wikimedia.org/r/663376

Pwirth mentioned this in rMSBCe2a98f806263: Clean up Title deprecated methods.Feb 12 2021, 2:46 PM
Vlad.shapik mentioned this in rMSBC705d64169f12: Clean up Title deprecated methods.Feb 12 2021, 2:46 PM
gerritbot added a comment.Feb 18 2021, 1:32 AM

Change 663594 merged by jenkins-bot:
[mediawiki/extensions/Video@master] Clean up Title deprecated methods

https://gerrit.wikimedia.org/r/663594

gerritbot added a comment.Feb 18 2021, 3:41 PM

Change 663280 merged by jenkins-bot:
[mediawiki/extensions/FlaggedRevs@master] Clean up Title deprecated methods

https://gerrit.wikimedia.org/r/663280

ReleaseTaggerBot added a project: MW-1.36-notes (1.36.0-wmf.32; 2021-02-23).Feb 18 2021, 4:00 PM
gerritbot added a comment.Feb 18 2021, 4:41 PM

Change 663297 merged by jenkins-bot:
[mediawiki/extensions/Echo@master] Clean up Title deprecated methods

https://gerrit.wikimedia.org/r/663297

gerritbot added a comment.Feb 24 2021, 7:17 PM

Change 663334 merged by jenkins-bot:
[mediawiki/extensions/Memento@master] Clean up Title deprecated methods

https://gerrit.wikimedia.org/r/663334

Vlad.shapik mentioned this in rEMEMc36935524dad: Clean up Title deprecated methods.Feb 24 2021, 8:02 PM
gerritbot added a comment.Feb 25 2021, 4:24 PM

Change 663574 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] Clean up Title deprecated methods

https://gerrit.wikimedia.org/r/663574

ReleaseTaggerBot edited projects, added MW-1.36-notes (1.36.0-wmf.33; 2021-03-02); removed MW-1.36-notes (1.36.0-wmf.32; 2021-02-23).Feb 25 2021, 5:00 PM
• Pchelolo added a comment.Feb 26 2021, 7:01 PM

Seems like all extensions are ready, so now all that's left is a patch to hard-deprecate soft-deprecated methods and remove the ones that were already hard-deprecated.

gerritbot added a comment.Feb 28 2021, 10:13 AM

Change 667375 had a related patch set uploaded (by Peter.ovchyn; owner: Peter.ovchyn):
[mediawiki/core@master] Clean up Title deprecated methods of mediawiki core

https://gerrit.wikimedia.org/r/667375

gerritbot added a comment.Mar 1 2021, 6:36 PM

Change 667375 merged by jenkins-bot:
[mediawiki/core@master] Clean up Title deprecated methods of mediawiki core

https://gerrit.wikimedia.org/r/667375

• Pchelolo closed this task as Resolved.Apr 6 2021, 5:15 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits