Page MenuHomePhabricator
Create Task
Maniphest T274156

Remove WikibaseRepo idGeneratorLogging option
Closed, ResolvedPublic3 Estimated Story Points
Actions

Description

This option was introduced in T268625 to optionally log all entity ID creation attempts with request details. It sends a lot of data to logstash (the full POST body – in hindsight, we should’ve at least redacted the token parameter), and since we presumably don’t need it anymore (the investigation is done, after all), we should remove it and the associated code (mainly the LoggingIdGenerator class).

ACs can be completed in any order (no dependency there).

Acceptance criteria ⛺✨ :

  • The option and associated code are removed from Wikibase
  • The Wikibase.IdGenerator log channel is removed from the production config (mediawiki-config)

Details

ProjectBranchLines +/-Subject
operations/mediawiki-configmaster+0 -8Remove all remains of idGeneratorLogging
operations/mediawiki-configmaster+0 -2Remove idGeneratorLogging
mediawiki/extensions/Wikibasemaster+0 -204WB: Remove WikibaseRepo idGeneratorLogging option
Customize query in gerrit

Related Objects

Event Timeline

Lucas_Werkmeister_WMDE created this task.Feb 8 2021, 4:31 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptFeb 8 2021, 4:31 PM
Lucas_Werkmeister_WMDE mentioned this in T274157: Remove WikibaseRepo idGeneratorRateLimiting option.Feb 8 2021, 4:31 PM
Lucas_Werkmeister_WMDE mentioned this in T272032: Add rate limit for creating Item IDs.
Lucas_Werkmeister_WMDE mentioned this in T276066: Move WikibaseRepo IdGenerator to service container.Mar 1 2021, 11:19 AM
Addshore added a project: Wikidata-Campsite.Mar 2 2021, 11:59 AM
Addshore moved this task from Incoming to Prioritized Tech (prioritised from top to bottom) on the Wikidata-Campsite board.
Addshore updated the task description. (Show Details)Mar 2 2021, 1:17 PM
darthmon_wmde set the point value for this task to 3.Mar 3 2021, 11:55 AM
darthmon_wmde moved this task from Prioritized Tech (prioritised from top to bottom) to Wikidata-Campsite-Iteration-∞ on the Wikidata-Campsite board.
darthmon_wmde edited projects, added Wikidata-Campsite (Wikidata-Campsite-Iteration-∞); removed Wikidata-Campsite.
Maintenance_bot moved this task from incoming to in progress on the Wikidata board.Mar 3 2021, 12:15 PM
Addshore moved this task from Inbox to legacy-backlog on the wdwb-tech board.Mar 5 2021, 11:50 AM
Addshore edited projects, added wdwb-tech (legacy-backlog); removed wdwb-tech.
Addshore moved this task from Incoming to Active on the wdwb-tech (legacy-backlog) board.
Addshore moved this task from legacy-backlog to Active on the wdwb-tech board.Mar 18 2021, 9:32 AM
Addshore edited projects, added wdwb-tech; removed wdwb-tech (legacy-backlog).
noarave claimed this task.Tue, Apr 6, 11:30 AM
Restricted Application added a project: User-Noarave. · View Herald TranscriptTue, Apr 6, 11:30 AM
noarave moved this task from To Do (prioritised from top to bottom) to Doing on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞) board.Tue, Apr 6, 11:30 AM
gerritbot added a comment.Wed, Apr 7, 11:50 AM

Change 677552 had a related patch set uploaded (by Noa wmde; author: Noa wmde):

[mediawiki/extensions/Wikibase@master] WB: Remove WikibaseRepo idGeneratorLogging option

https://gerrit.wikimedia.org/r/677552

gerritbot added a project: Patch-For-Review.Wed, Apr 7, 11:50 AM
gerritbot added a comment.Wed, Apr 7, 12:15 PM

Change 677560 had a related patch set uploaded (by Noa wmde; author: Noa wmde):

[operations/mediawiki-config@master] Remove log channel Wikibase.IdGenerator

https://gerrit.wikimedia.org/r/677560

noarave moved this task from Doing to Peer Review on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞) board.Wed, Apr 7, 12:32 PM
noarave added a subscriber: Silvan_WMDE.Wed, Apr 7, 1:59 PM

Note from handover call with @Silvan_WMDE :
The two patches currently undo the code added in the following patches:
https://gerrit.wikimedia.org/r/c/mediawiki/extensions/Wikibase/+/667891
https://gerrit.wikimedia.org/r/c/operations/mediawiki-config/+/649321
https://gerrit.wikimedia.org/r/c/operations/mediawiki-config/+/644564
https://gerrit.wikimedia.org/r/c/operations/mediawiki-config/+/643874
https://gerrit.wikimedia.org/r/c/mediawiki/extensions/Wikibase/+/643882
https://gerrit.wikimedia.org/r/c/mediawiki/extensions/Wikibase/+/643760

The mediawiki-config changes will require deployment.

gerritbot added a comment.Thu, Apr 8, 2:18 PM

Change 677920 had a related patch set uploaded (by Silvan Heintze; author: Silvan Heintze):

[operations/mediawiki-config@master] Remove all remains of idGeneratorLogging

https://gerrit.wikimedia.org/r/677920

Lucas_Werkmeister_WMDE added a comment.Thu, Apr 8, 2:36 PM

We probably want to backport the Wikibase change to the REL1_36 branch.

gerritbot added a comment.Thu, Apr 8, 3:04 PM

Change 677552 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] WB: Remove WikibaseRepo idGeneratorLogging option

https://gerrit.wikimedia.org/r/677552

ReleaseTaggerBot added a project: MW-1.37-notes (1.37.0-wmf.1; 2021-04-13).Thu, Apr 8, 4:00 PM
gerritbot added a comment.Mon, Apr 12, 11:04 AM

Change 677560 merged by jenkins-bot:

[operations/mediawiki-config@master] Remove idGeneratorLogging

https://gerrit.wikimedia.org/r/677560

Stashbot added a comment.Mon, Apr 12, 11:07 AM

Mentioned in SAL (#wikimedia-operations) [2021-04-12T11:07:04Z] <lucaswerkmeister-wmde@deploy1002> Synchronized wmf-config/Wikibase.php: Config: [[gerrit:677560|Remove idGeneratorLogging (T274156)]] (duration: 00m 58s)

gerritbot added a comment.Mon, Apr 12, 11:08 AM

Change 677920 merged by jenkins-bot:

[operations/mediawiki-config@master] Remove all remains of idGeneratorLogging

https://gerrit.wikimedia.org/r/677920

Stashbot added a comment.Mon, Apr 12, 11:10 AM

Mentioned in SAL (#wikimedia-operations) [2021-04-12T11:10:30Z] <lucaswerkmeister-wmde@deploy1002> Synchronized wmf-config/InitialiseSettings.php: Config: [[gerrit:677920|Remove all remains of idGeneratorLogging (T274156)]] (1/2) (duration: 00m 57s)

Stashbot added a comment.Mon, Apr 12, 11:11 AM

Mentioned in SAL (#wikimedia-operations) [2021-04-12T11:11:41Z] <lucaswerkmeister-wmde@deploy1002> Synchronized wmf-config/InitialiseSettings-labs.php: Config: [[gerrit:677920|Remove all remains of idGeneratorLogging (T274156)]] (2/2, Beta-only) (duration: 00m 56s)

Lucas_Werkmeister_WMDE added a comment.EditedMon, Apr 12, 11:15 AM

No more log events in the Wikibase.IdGenerator channel since 13:07 CEST (11:07 UTC).

Silvan_WMDE moved this task from Peer Review to Test (Verification) on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞) board.Mon, Apr 12, 11:16 AM
Addshore closed this task as Resolved.Wed, Apr 14, 9:25 AM
Maintenance_bot moved this task from Test (Verification) to Done on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞) board.Wed, Apr 14, 10:16 AM
Content licensed under Creative Commons Attribution-ShareAlike 3.0 (CC-BY-SA) unless otherwise noted; code licensed under GNU General Public License (GPL) or other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL