Page MenuHomePhabricator

Remove WikibaseRepo idGeneratorLogging option
Closed, ResolvedPublic3 Estimated Story Points

Description

This option was introduced in T268625 to optionally log all entity ID creation attempts with request details. It sends a lot of data to logstash (the full POST body – in hindsight, we should’ve at least redacted the token parameter), and since we presumably don’t need it anymore (the investigation is done, after all), we should remove it and the associated code (mainly the LoggingIdGenerator class).

ACs can be completed in any order (no dependency there).

Acceptance criteria ⛺✨ :

  • The option and associated code are removed from Wikibase
  • The Wikibase.IdGenerator log channel is removed from the production config (mediawiki-config)

Event Timeline

Addshore edited projects, added wdwb-tech (legacy-backlog); removed wdwb-tech.
Addshore moved this task from Incoming to Active on the wdwb-tech (legacy-backlog) board.

Change 677552 had a related patch set uploaded (by Noa wmde; author: Noa wmde):

[mediawiki/extensions/Wikibase@master] WB: Remove WikibaseRepo idGeneratorLogging option

https://gerrit.wikimedia.org/r/677552

Change 677560 had a related patch set uploaded (by Noa wmde; author: Noa wmde):

[operations/mediawiki-config@master] Remove log channel Wikibase.IdGenerator

https://gerrit.wikimedia.org/r/677560

Change 677920 had a related patch set uploaded (by Silvan Heintze; author: Silvan Heintze):

[operations/mediawiki-config@master] Remove all remains of idGeneratorLogging

https://gerrit.wikimedia.org/r/677920

We probably want to backport the Wikibase change to the REL1_36 branch.

Change 677552 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] WB: Remove WikibaseRepo idGeneratorLogging option

https://gerrit.wikimedia.org/r/677552

Change 677560 merged by jenkins-bot:

[operations/mediawiki-config@master] Remove idGeneratorLogging

https://gerrit.wikimedia.org/r/677560

Mentioned in SAL (#wikimedia-operations) [2021-04-12T11:07:04Z] <lucaswerkmeister-wmde@deploy1002> Synchronized wmf-config/Wikibase.php: Config: [[gerrit:677560|Remove idGeneratorLogging (T274156)]] (duration: 00m 58s)

Change 677920 merged by jenkins-bot:

[operations/mediawiki-config@master] Remove all remains of idGeneratorLogging

https://gerrit.wikimedia.org/r/677920

Mentioned in SAL (#wikimedia-operations) [2021-04-12T11:10:30Z] <lucaswerkmeister-wmde@deploy1002> Synchronized wmf-config/InitialiseSettings.php: Config: [[gerrit:677920|Remove all remains of idGeneratorLogging (T274156)]] (1/2) (duration: 00m 57s)

Mentioned in SAL (#wikimedia-operations) [2021-04-12T11:11:41Z] <lucaswerkmeister-wmde@deploy1002> Synchronized wmf-config/InitialiseSettings-labs.php: Config: [[gerrit:677920|Remove all remains of idGeneratorLogging (T274156)]] (2/2, Beta-only) (duration: 00m 56s)

No more log events in the Wikibase.IdGenerator channel since 13:07 CEST (11:07 UTC).