Page MenuHomePhabricator

Remove WikibaseRepo idGeneratorRateLimiting option
Closed, ResolvedPublic

Description

This option was introduced in T272032 to control whether the rate limit for creating entity IDs is enabled or not. Once it’s been successfully enabled on Wikidata, we should remove it from Wikibase: it shouldn’t be needed in regular operation. (If someone doesn’t want the rate limit to be enforced, they could just configure it to be a very high limit.)

Acceptance criteria ⛺✨ :

  • The option is removed from Wikibase (note: unlike in T274156, we don’t want to remove the associated code – the rate limit should be unconditionally enabled)
  • The option is removed from the production config
  • double-check that "ID-Generation-Rate-Limiting" exists as a feature in the Changelog

Event Timeline

Change 698557 had a related patch set uploaded (by Dat Nguyen; author: Dat Nguyen):

[mediawiki/extensions/Wikibase@master] Remove IdGeneratorRateLimiting

https://gerrit.wikimedia.org/r/698557

@Lucas_Werkmeister_WMDE What is the last AC with "ID-Generation-Rate-Limiting" referring to, is that some kind of log when deployed?

Change 698751 had a related patch set uploaded (by Dat Nguyen; author: Dat Nguyen):

[operations/mediawiki-config@master] Remove idGeneratorRateLimiting from production config

https://gerrit.wikimedia.org/r/698751

That AC was written by @Michael, not me 😅 but I assume it means that the feature is documented in the Wikibase release notes (RELEASE-NOTES-1.37 file), since it’ll now be enabled for all installations. I don’t think we need the exact string “ID-Generation-Rate-Limiting”, though.

Yes. As part of the Release Strategy hike (I think), it was decided that we want a Wikibase Changelog / Release Notes that list the changes since the last release, including added/removed/changed/deprecated options.

@Lucas_Werkmeister_WMDE How about we just backport these changes as well into REL1_36 and it would be as if this option never was released.

I don’t think I said anything about 1.36…?

What exactly do you propose backporting? If it’s the same changes that remove the option while leaving the behavior, then that would still be a change in behavior that should also be documented in the release notes.

Change 699713 had a related patch set uploaded (by Dat Nguyen; author: Dat Nguyen):

[mediawiki/extensions/Wikibase@master] Add Release note about Rate Limiting

https://gerrit.wikimedia.org/r/699713

Change 698557 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] Remove IdGeneratorRateLimiting

https://gerrit.wikimedia.org/r/698557

Change 699713 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] Add Release note about Rate Limiting

https://gerrit.wikimedia.org/r/699713

Ladsgroup added a subscriber: Ladsgroup.

We can't deploy config changes this week (wmf allhands)

Change 698751 merged by jenkins-bot:

[operations/mediawiki-config@master] Remove idGeneratorRateLimiting from production config

https://gerrit.wikimedia.org/r/698751

Mentioned in SAL (#wikimedia-operations) [2021-06-28T08:31:44Z] <ladsgroup@deploy1002> Synchronized wmf-config/Wikibase.php: Config: [[gerrit:698751|Remove idGeneratorRateLimiting from production config (T274157)]], Part I (duration: 00m 58s)

Mentioned in SAL (#wikimedia-operations) [2021-06-28T08:33:22Z] <ladsgroup@deploy1002> Synchronized wmf-config/InitialiseSettings.php: Config: [[gerrit:698751|Remove idGeneratorRateLimiting from production config (T274157)]], Part II (duration: 00m 55s)

Change 745279 had a related patch set uploaded (by Rosalie Perside (WMDE); author: Dat Nguyen):

[mediawiki/extensions/Wikibase@REL1_36] Remove IdGeneratorRateLimiting

https://gerrit.wikimedia.org/r/745279

Change 745279 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@REL1_36] Remove IdGeneratorRateLimiting

https://gerrit.wikimedia.org/r/745279