The current URL for the 'Live demo' in the README.md gives 404.
I have Fixed the issue in my forked repo but I don't know how to contribute to Wikimedia. Should I make a PR in the GitHub repository i.e VisualEditor or there is some other way to do it.
Description
Details
Related Objects
Event Timeline
The link on the front page of https://doc.wikimedia.org/ is also a 404 for me. I have no idea where that is defined.
Both links are pointing to https://doc.wikimedia.org/VisualEditor/master/lib/ve/demos/ve/desktop-wikimediaui.html right now. What would the correct URL be? (Or maybe that is the correct URL, but doc.wikimedia.org is misconfigured…)
I have Fixed the issue in my forked repo but I don't know how to contribute to Wikimedia. Should I make a PR in the GitHub repository i.e VisualEditor or there is some other way to do it.
Sorry, we don't review pull requests on GitHub. If you want to contribute, you can submit a patch to our instance of Gerrit, where we do code review. Please start at https://www.mediawiki.org/wiki/Gerrit :)
Both links are pointing to https://doc.wikimedia.org/VisualEditor/master/lib/ve/demos/ve/desktop-wikimediaui.html right now. What would the correct URL be? (Or maybe that is the correct URL, but doc.wikimedia.org is misconfigured…).
Actually the correct URL should be https://doc.wikimedia.org/VisualEditor/master/js/lib/ve/demos/ve/desktop-wikimediaui.html.
Sorry, we don't review pull requests on GitHub. If you want to contribute, you can submit a patch to our instance of Gerrit, where we do code review. Please start at https://www.mediawiki.org/wiki/Gerrit :)
Ok, I will submit my patch on Gerrit. Thanks for guiding me :)
Change 663522 had a related patch set uploaded (by Pradhuman1; owner: Pradhuman1):
[VisualEditor/VisualEditor@master] Update of 'Live link' URL in README
Change 663522 merged by jenkins-bot:
[VisualEditor/VisualEditor@master] Update of 'Live Demo' URL in README
Thank you for the patch @Pradhuman1!
I found it, it's the integration/docroot repository. Let's fix that as well, I'll submit a patch.
Change 663665 had a related patch set uploaded (by Bartosz Dziewoński; owner: Bartosz Dziewoński):
[integration/docroot@master] Update URL of VisualEditor demo
Change 663665 merged by jenkins-bot:
[integration/docroot@master] Update URL of VisualEditor demo
Change 663851 had a related patch set uploaded (by Bartosz Dziewoński; owner: Bartosz Dziewoński):
[mediawiki/extensions/VisualEditor@master] Update VE core submodule to master (a248cdbac)
Change 663851 merged by jenkins-bot:
[mediawiki/extensions/VisualEditor@master] Update VE core submodule to master (a248cdbac)