Page MenuHomePhabricator
Create Task
Maniphest T274253

Split up module specific-JS in SecurePoll
Closed, ResolvedPublic2 Estimated Story Points
Actions

Description

From https://gerrit.wikimedia.org/r/c/mediawiki/extensions/SecurePoll/+/661995/:

We like to keep the number of modules as small as possible - which we could also do separate files with a dispatcher. I personally find separate files preferable, but I was thinking we should untangle the modules in a separate commit. Does that sound OK?

The js in modules/ext.securepoll.htmlform.js manages two independent features and can be split up as mentioned. An example of this architecture can be found in IPInfo.

Details

SubjectRepoBranchLines +/-
Split ext.securepoll.htmlform into multiple filesmediawiki/extensions/SecurePollmaster+136 -124
Customize query in gerrit

Related Objects

Event Timeline

STran created this task.Feb 9 2021, 1:47 PM
Restricted Application added a project: Platform Engineering. · View Herald TranscriptFeb 9 2021, 1:47 PM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
• AMooney removed a project: Platform Engineering.Feb 9 2021, 2:02 PM
• Niharika triaged this task as Medium priority.Feb 11 2021, 3:06 PM
• Niharika moved this task from Untriaged to Triage/To be Estimated on the Anti-Harassment board.
ARamirez_WMF set the point value for this task to 2.Feb 11 2021, 5:36 PM
ARamirez_WMF moved this task from Triage/To be Estimated to Cards ready for development on the Anti-Harassment board.
ARamirez_WMF moved this task from Cards ready for development to The Letter Song on the Anti-Harassment board.Feb 11 2021, 5:53 PM
ARamirez_WMF edited projects, added Anti-Harassment (The Letter Song); removed Anti-Harassment.
Tchanders updated the task description. (Show Details)Feb 18 2021, 8:12 PM
DLynch claimed this task.Feb 22 2021, 5:17 PM
DLynch moved this task from Ready 🎬 (ONLY IF YOU HAVE NO MORE CODE TO REVIEW) to In Progress 💪 on the Anti-Harassment (The Letter Song) board.
gerritbot added a comment.Feb 22 2021, 5:39 PM

Change 666192 had a related patch set uploaded (by DLynch; owner: DLynch):
[mediawiki/extensions/SecurePoll@master] Split ext.securepoll.htmlform into multiple files

https://gerrit.wikimedia.org/r/666192

gerritbot added a project: Patch-For-Review.Feb 22 2021, 5:39 PM
DLynch moved this task from In Progress 💪 to Code Review 🔍 on the Anti-Harassment (The Letter Song) board.Feb 22 2021, 5:51 PM
gerritbot added a comment.Feb 22 2021, 6:29 PM

Change 666192 merged by jenkins-bot:
[mediawiki/extensions/SecurePoll@master] Split ext.securepoll.htmlform into multiple files

https://gerrit.wikimedia.org/r/666192

DLynch moved this task from Code Review 🔍 to QA/Testing 🐞 on the Anti-Harassment (The Letter Song) board.Feb 22 2021, 6:37 PM
ReleaseTaggerBot added a project: MW-1.36-notes (1.36.0-wmf.32; 2021-02-23).Feb 22 2021, 7:00 PM
Maintenance_bot removed a project: Patch-For-Review.Feb 22 2021, 7:10 PM
dom_walden moved this task from QA/Testing 🐞 to Done: Q3 (2020-2021) on the Anti-Harassment (The Letter Song) board.Feb 24 2021, 9:18 AM
dom_walden subscribed.

The two features managed by the now split javascript module are:

  • adding the custom column labels on Special:SecurePoll/create
  • disabling/enabling form fields on Special:SecurePollLog

I checked that both of these still functioned on their respective pages.

Test Environments:

• Niharika closed this task as Resolved.Feb 24 2021, 2:46 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL