Page MenuHomePhabricator

Remove class_exists checks for Wikibase
Closed, ResolvedPublic5 Estimated Story Points

Description

Checking the class_exists for Wikibase which would complicate enabling preload (feature of php 7.4) can be found everywhere in Wikibase-related extensions: the whole list. For example: In WikidataPageBanner. They are there because Wikibase wasn't being loaded using extension registry (but that got fixed recently) and now they can simply migrated to ExtensionRegistry::isLoaded('WikibaseClient') and ExtensionRegistry::isLoaded('WikibaseRepo').

List of related ones already found:

Acceptance Criteria🏕️🌟:

  • MediaWiki Extensions no longer use class_exists checks for Wikibase classes

Event Timeline

Addshore set the point value for this task to 5.Jun 18 2021, 9:32 AM

Change 700519 had a related patch set uploaded (by Ladsgroup; author: Ladsgroup):

[mediawiki/extensions/MobileFrontend@master] Replace class_exists with ExtensionRegistry

https://gerrit.wikimedia.org/r/700519

Change 700521 had a related patch set uploaded (by Ladsgroup; author: Ladsgroup):

[mediawiki/extensions/Echo@master] Replace class_exists with ExtensionRegistry

https://gerrit.wikimedia.org/r/700521

Change 700527 had a related patch set uploaded (by Ladsgroup; author: Ladsgroup):

[mediawiki/extensions/Math@master] Replace class_exists with ExtensionRegistry

https://gerrit.wikimedia.org/r/700527

Change 700593 had a related patch set uploaded (by Ladsgroup; author: Ladsgroup):

[mediawiki/extensions/WikibaseMediaInfo@master] Replace class_exists with ExtensionRegistry

https://gerrit.wikimedia.org/r/700593

Change 700519 merged by jenkins-bot:

[mediawiki/extensions/MobileFrontend@master] Replace class_exists with ExtensionRegistry

https://gerrit.wikimedia.org/r/700519

Change 700521 merged by jenkins-bot:

[mediawiki/extensions/Echo@master] Replace class_exists with ExtensionRegistry

https://gerrit.wikimedia.org/r/700521

Change 700600 had a related patch set uploaded (by Ladsgroup; author: Ladsgroup):

[mediawiki/extensions/Citoid@master] Replace class_exists with ExtensionRegistry

https://gerrit.wikimedia.org/r/700600

Change 700527 merged by jenkins-bot:

[mediawiki/extensions/Math@master] Replace class_exists with ExtensionRegistry

https://gerrit.wikimedia.org/r/700527

Change 700343 had a related patch set uploaded (by Ladsgroup; author: Ladsgroup):

[mediawiki/extensions/MobileFrontend@wmf/1.37.0-wmf.9] Replace class_exists with ExtensionRegistry

https://gerrit.wikimedia.org/r/700343

Change 700600 merged by jenkins-bot:

[mediawiki/extensions/Citoid@master] Replace class_exists with ExtensionRegistry

https://gerrit.wikimedia.org/r/700600

Change 700603 had a related patch set uploaded (by Ladsgroup; author: Ladsgroup):

[mediawiki/extensions/Wikidata.org@master] Replace class_exists with ExtensionRegistry

https://gerrit.wikimedia.org/r/700603

Change 700606 had a related patch set uploaded (by Ladsgroup; author: Ladsgroup):

[mediawiki/extensions/WikidataPageBanner@master] Replace class_exists with ExtensionRegistry

https://gerrit.wikimedia.org/r/700606

Change 700343 merged by jenkins-bot:

[mediawiki/extensions/MobileFrontend@wmf/1.37.0-wmf.9] Replace class_exists with ExtensionRegistry

https://gerrit.wikimedia.org/r/700343

Change 700593 merged by jenkins-bot:

[mediawiki/extensions/WikibaseMediaInfo@master] Replace class_exists with ExtensionRegistry

https://gerrit.wikimedia.org/r/700593

Change 700603 merged by jenkins-bot:

[mediawiki/extensions/Wikidata.org@master] Replace class_exists with ExtensionRegistry

https://gerrit.wikimedia.org/r/700603

Change 700606 merged by jenkins-bot:

[mediawiki/extensions/WikidataPageBanner@master] Replace class_exists with ExtensionRegistry

https://gerrit.wikimedia.org/r/700606