Page MenuHomePhabricator
Create Task
Maniphest T274275

Remove class_exists checks for Wikibase
Closed, ResolvedPublic5 Estimated Story Points
Actions

Description

Checking the class_exists for Wikibase which would complicate enabling preload (feature of php 7.4) can be found everywhere in Wikibase-related extensions: the whole list. For example: In WikidataPageBanner. They are there because Wikibase wasn't being loaded using extension registry (but that got fixed recently) and now they can simply migrated to ExtensionRegistry::isLoaded('WikibaseClient') and ExtensionRegistry::isLoaded('WikibaseRepo').

List of related ones already found:

Acceptance Criteria🏕️🌟:

  • MediaWiki Extensions no longer use class_exists checks for Wikibase classes

Details

SubjectRepoBranchLines +/-
Replace class_exists with ExtensionRegistrymediawiki/extensions/Citoidmaster+6 -5
Replace class_exists with ExtensionRegistrymediawiki/extensions/WikidataPageBannermaster+23 -22
Replace class_exists with ExtensionRegistrymediawiki/extensions/Wikidata.orgmaster+2 -1
Replace class_exists with ExtensionRegistrymediawiki/extensions/WikibaseMediaInfomaster+4 -4
Replace class_exists with ExtensionRegistrymediawiki/extensions/MobileFrontendwmf/1.37.0-wmf.9+1 -1
Replace class_exists with ExtensionRegistrymediawiki/extensions/Mathmaster+6 -5
Replace class_exists with ExtensionRegistrymediawiki/extensions/MobileFrontendmaster+1 -1
Replace class_exists with ExtensionRegistrymediawiki/extensions/Echomaster+1 -4
Customize query in gerrit

Related Objects
Search...

StatusSubtypeAssignedTask
 DeclinedNoneT240775 RFC: Support PHP 7.4 preload
 ResolvedLadsgroupT274275 Remove class_exists checks for Wikibase

Event Timeline

Ladsgroup created this task.Feb 9 2021, 4:50 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptFeb 9 2021, 4:50 PM
Addshore edited projects, added [DEPRECATED] wdwb-tech; removed Wikidata-Campsite.May 25 2021, 11:17 AM
Addshore moved this task from Inbox to To Prioritize on the [DEPRECATED] wdwb-tech board.Jun 15 2021, 9:26 AM
Lucas_Werkmeister_WMDE added a comment.Jun 15 2021, 10:14 AM

See also T257586: ExtensionRegistry is difficult to use as a singleton.

Addshore moved this task from To Prioritize to Triaged Low (0-50) on the [DEPRECATED] wdwb-tech board.Jun 15 2021, 11:26 AM
Addshore triaged this task as Medium priority.Jun 15 2021, 11:29 AM
Addshore added a project: Wikidata-Campsite.
Addshore moved this task from Incoming to Prioritized Wikidata Tech Backlog (prioritised from top to bottom) on the Wikidata-Campsite board.
Addshore updated the task description. (Show Details)Jun 15 2021, 12:16 PM
Addshore updated the task description. (Show Details)Jun 18 2021, 9:22 AM
Addshore updated the task description. (Show Details)
Addshore set the point value for this task to 5.Jun 18 2021, 9:32 AM
Addshore edited projects, added Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)); removed Wikidata-Campsite.Jun 18 2021, 9:45 AM
Addshore moved this task from Triaged Low (0-50) to Active on the [DEPRECATED] wdwb-tech board.Jun 18 2021, 1:48 PM
Ladsgroup claimed this task.Jun 21 2021, 11:06 AM
Ladsgroup moved this task from To Do (prioritised from top to bottom) to Doing on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)) board.
Restricted Application added a project: User-Ladsgroup. · View Herald TranscriptJun 21 2021, 11:06 AM
gerritbot added a comment.Jun 21 2021, 11:12 AM

Change 700519 had a related patch set uploaded (by Ladsgroup; author: Ladsgroup):

[mediawiki/extensions/MobileFrontend@master] Replace class_exists with ExtensionRegistry

https://gerrit.wikimedia.org/r/700519

gerritbot added a project: Patch-For-Review.Jun 21 2021, 11:12 AM
gerritbot added a comment.Jun 21 2021, 11:15 AM

Change 700521 had a related patch set uploaded (by Ladsgroup; author: Ladsgroup):

[mediawiki/extensions/Echo@master] Replace class_exists with ExtensionRegistry

https://gerrit.wikimedia.org/r/700521

gerritbot added a comment.Jun 21 2021, 11:32 AM

Change 700527 had a related patch set uploaded (by Ladsgroup; author: Ladsgroup):

[mediawiki/extensions/Math@master] Replace class_exists with ExtensionRegistry

https://gerrit.wikimedia.org/r/700527

gerritbot added a comment.Jun 21 2021, 12:14 PM

Change 700593 had a related patch set uploaded (by Ladsgroup; author: Ladsgroup):

[mediawiki/extensions/WikibaseMediaInfo@master] Replace class_exists with ExtensionRegistry

https://gerrit.wikimedia.org/r/700593

gerritbot added a comment.Jun 21 2021, 12:27 PM

Change 700519 merged by jenkins-bot:

[mediawiki/extensions/MobileFrontend@master] Replace class_exists with ExtensionRegistry

https://gerrit.wikimedia.org/r/700519

gerritbot added a comment.Jun 21 2021, 12:27 PM

Change 700521 merged by jenkins-bot:

[mediawiki/extensions/Echo@master] Replace class_exists with ExtensionRegistry

https://gerrit.wikimedia.org/r/700521

gerritbot added a comment.Jun 21 2021, 12:48 PM

Change 700600 had a related patch set uploaded (by Ladsgroup; author: Ladsgroup):

[mediawiki/extensions/Citoid@master] Replace class_exists with ExtensionRegistry

https://gerrit.wikimedia.org/r/700600

gerritbot added a comment.Jun 21 2021, 12:51 PM

Change 700527 merged by jenkins-bot:

[mediawiki/extensions/Math@master] Replace class_exists with ExtensionRegistry

https://gerrit.wikimedia.org/r/700527

gerritbot added a comment.Jun 21 2021, 12:57 PM

Change 700343 had a related patch set uploaded (by Ladsgroup; author: Ladsgroup):

[mediawiki/extensions/MobileFrontend@wmf/1.37.0-wmf.9] Replace class_exists with ExtensionRegistry

https://gerrit.wikimedia.org/r/700343

gerritbot added a comment.Jun 21 2021, 1:00 PM

Change 700600 merged by jenkins-bot:

[mediawiki/extensions/Citoid@master] Replace class_exists with ExtensionRegistry

https://gerrit.wikimedia.org/r/700600

ReleaseTaggerBot added a project: MW-1.37-notes (1.37.0-wmf.11; 2021-06-21).Jun 21 2021, 1:00 PM
gerritbot added a comment.Jun 21 2021, 1:11 PM

Change 700603 had a related patch set uploaded (by Ladsgroup; author: Ladsgroup):

[mediawiki/extensions/Wikidata.org@master] Replace class_exists with ExtensionRegistry

https://gerrit.wikimedia.org/r/700603

gerritbot added a comment.Jun 21 2021, 1:15 PM

Change 700606 had a related patch set uploaded (by Ladsgroup; author: Ladsgroup):

[mediawiki/extensions/WikidataPageBanner@master] Replace class_exists with ExtensionRegistry

https://gerrit.wikimedia.org/r/700606

gerritbot added a comment.Jun 21 2021, 1:23 PM

Change 700343 merged by jenkins-bot:

[mediawiki/extensions/MobileFrontend@wmf/1.37.0-wmf.9] Replace class_exists with ExtensionRegistry

https://gerrit.wikimedia.org/r/700343

ReleaseTaggerBot edited projects, added MW-1.37-notes (1.37.0-wmf.9; 2021-06-07); removed MW-1.37-notes (1.37.0-wmf.11; 2021-06-21).Jun 21 2021, 2:00 PM
gerritbot added a comment.Jun 21 2021, 2:41 PM

Change 700593 merged by jenkins-bot:

[mediawiki/extensions/WikibaseMediaInfo@master] Replace class_exists with ExtensionRegistry

https://gerrit.wikimedia.org/r/700593

Ladsgroup moved this task from Doing to Peer Review on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)) board.Jun 21 2021, 2:42 PM
ReleaseTaggerBot edited projects, added MW-1.37-notes (1.37.0-wmf.11; 2021-06-21); removed MW-1.37-notes (1.37.0-wmf.9; 2021-06-07).Jun 21 2021, 3:00 PM
gerritbot added a comment.Jun 21 2021, 3:15 PM

Change 700603 merged by jenkins-bot:

[mediawiki/extensions/Wikidata.org@master] Replace class_exists with ExtensionRegistry

https://gerrit.wikimedia.org/r/700603

gerritbot added a comment.Jun 21 2021, 3:15 PM

Change 700606 merged by jenkins-bot:

[mediawiki/extensions/WikidataPageBanner@master] Replace class_exists with ExtensionRegistry

https://gerrit.wikimedia.org/r/700606

Lucas_Werkmeister_WMDE moved this task from Peer Review to Test (Verification) on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)) board.Jun 21 2021, 3:48 PM
Addshore closed this task as Resolved.Jun 28 2021, 11:07 AM
Addshore subscribed.

LGTM!

Lucas_Werkmeister_WMDE moved this task from Test (Verification) to Done on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)) board.Jun 28 2021, 11:12 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL