| Patriccck | |
| Feb 9 2021, 10:28 PM |
| F34137343: Screen Shot 2021-03-04 at 2.31.18 PM.png | |
| Mar 4 2021, 10:33 PM |
| F34108216: Screenshot_20210216-230030_Chrome.jpg | |
| Feb 16 2021, 10:01 PM |
| F34099216: Screenshot_20210210-091036_Chrome.jpg | |
| Feb 10 2021, 8:11 AM |
| F34099092: image.png | |
| Feb 10 2021, 3:21 AM |
Hello, why is there not functional [reply] link: https://cs.m.wikipedia.org/wiki/Wikipedie:Pod_l%C3%ADpou#N%C3%A1zvy_%C4%8Dl%C3%A1nk%C5%AF_pam%C3%A1tek I expected I will see something when click on [reply] but nothing happend. I think that it is a bug and the same bug was resolved earlier.
Expected
[ reply ] links should not be visible on mobile web yet
@Patriccck: we appreciate you reporting this. Can you please share a screenshot of what you're seeing?
...I have not yet been able to get [ reply ] links to appear when visiting a cs.wiki page on my mobile device. [i]
Hmm, there was a link yesterday but now I cannot see it. Was there any software change? For example, here is the [reply] link (but it is maybe intention).
I did also see the link yesterday but am no longer able to reproduce anywhere, here's testwiki (currently on wmf.30): https://test.m.wikipedia.org/w/index.php?title=Wikipedia_talk:Sandbox&dtenable=1#Please_start_your_testing_below_this_line
All wikis were temporarily on wmf.29 for some time yesterday but were rolled back to wmf.27 to ensure a safe version to rollback.
Change 663237 had a related patch set uploaded (by Bartosz Dziewoński; owner: Bartosz Dziewoński):
[mediawiki/extensions/DiscussionTools@master] Add MobileFrontend check to the parser cache path
(The patch just hides the [reply] links again – we have task T270536 about actually supporting the reply tool in the mobile version.)
Change 663237 abandoned by Bartosz Dziewoński:
[mediawiki/extensions/DiscussionTools@master] Fix the reply tool check in the parser cache path
Reason:
We're not happy that the "obvious" way to fix this (by checking whether we're rendering a mobile page before adding reply links) requires accessing the global state rather than just the parser options, and Ed is concerned that we might end up caching the wrong HTML in some case because of that (although I'm pretty sure it's impossible).
Instead of this patch (which I just abandoned), we're going to let the reply links be added, and instead hide them with CSS, which is something we were planning already for T273072.
Change 663223 had a related patch set uploaded (by Bartosz Dziewoński; owner: Esanders):
[mediawiki/extensions/DiscussionTools@master] Only show reply links when body class in present
Change 663223 merged by jenkins-bot:
[mediawiki/extensions/DiscussionTools@master] Only show reply links when body class in present
There are still non-functional Reply links appearing on this page on cs wiki: https://cs.m.wikipedia.org/wiki/Wikipedie:Pod_l%C3%ADpou#N%C3%A1zvy_%C4%8Dl%C3%A1nk%C5%AF_pam%C3%A1tek
So, yeah, we didn't think this through. The CSS change to hide reply links does not work, because our CSS is not loaded on mobile, because the reply links are not supposed to appear there (but they do).
Change 663237 restored by Bartosz Dziewoński:
[mediawiki/extensions/DiscussionTools@master] Fix the reply tool check in the parser cache path
Change 669029 had a related patch set uploaded (by Esanders; owner: Esanders):
[mediawiki/extensions/DiscussionTools@master] Always load init CSS when tools are available for a title
Change 663237 abandoned by Bartosz Dziewoński:
[mediawiki/extensions/DiscussionTools@master] Add MobileFrontend check to the parser cache path
Reason:
Change 669029 merged by jenkins-bot:
[mediawiki/extensions/DiscussionTools@master] Always load init CSS when tools are available for a title
