Page MenuHomePhabricator
Create Task
Maniphest T274312

Special:Watchlist not showing a link to Special:GlobalWatchlist
Closed, ResolvedPublic4 Estimated Story PointsBUG REPORT
Actions

Description

Reproducable at:
beta cluster metawiki: https://meta.wikimedia.beta.wmflabs.org/wiki/Special:Watchlist
production testwiki: https://test.wikipedia.org/wiki/Special:Watchlist
Not reproducible at: patchdemo with GlobalWatchlist master and no other extensions enabled, with MediaWiki:Sidebar copied from testwiki - https://patchdemo.wmflabs.org/wikis/1ec5b0d5b04520a39832bb3dc4a0533f/w/index.php/Special:Watchlist

Is there another extension or configuration option that is messing with this?

Details

SubjectRepoBranchLines +/-
Switch sidebar hook to onSidebarBeforeOutputmediawiki/extensions/GlobalWatchlistwmf/1.36.0-wmf.30+9 -9
Switch sidebar hook to onSidebarBeforeOutputmediawiki/extensions/GlobalWatchlistmaster+9 -9
Customize query in gerrit

Related Objects

Event Timeline

DannyS712 created this task.Feb 9 2021, 10:50 PM
Restricted Application added a project: User-DannyS712. · View Herald TranscriptFeb 9 2021, 10:50 PM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
DannyS712 triaged this task as High priority.Feb 9 2021, 10:55 PM
DannyS712 moved this task from Backlog to In progress on the MediaWiki-extensions-GlobalWatchlist board.
DannyS712 changed the subtype of this task from "Task" to "Bug Report".
DannyS712 mentioned this in T260862: Deploy GlobalWatchlist extension to production (Meta only).Feb 9 2021, 11:10 PM
DannyS712 set the point value for this task to 4.Feb 10 2021, 12:46 AM
DannyS712 added a comment.Feb 10 2021, 7:21 PM

Found it - appears to be caused by $wgEnableSidebarCache

gerritbot added a comment.Feb 10 2021, 7:22 PM

Change 663075 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/extensions/GlobalWatchlist@master] Switch sidebar hook to onSidebarBeforeOutput

https://gerrit.wikimedia.org/r/663075

gerritbot added a project: Patch-For-Review.Feb 10 2021, 7:22 PM
DannyS712 moved this task from Unsorted to Awaiting review and deployment on the User-DannyS712 board.Feb 10 2021, 7:32 PM
In T274312#6819857, @DannyS712 wrote:

Found it - appears to be caused by $wgEnableSidebarCache

Confirmed to be the issue locally:

  • View Special:Watchlist and confirm that has the link, as expected
  • Enable $wgEnableSidebarCache
  • View Special:Watchlist and see that it is now missing the link
  • Checking the commit above to switch the hook, and see that it now works
gerritbot added a comment.Feb 11 2021, 12:31 AM

Change 663075 merged by jenkins-bot:
[mediawiki/extensions/GlobalWatchlist@master] Switch sidebar hook to onSidebarBeforeOutput

https://gerrit.wikimedia.org/r/663075

jenkins-bot mentioned this in rEGLWa50f0e773436: Switch sidebar hook to onSidebarBeforeOutput.Feb 11 2021, 12:31 AM
ReleaseTaggerBot added a project: MW-1.36-notes (1.36.0-wmf.31; 2021-02-16).Feb 11 2021, 1:00 AM
Maintenance_bot removed a project: Patch-For-Review.Feb 11 2021, 1:11 AM
gerritbot added a comment.Feb 11 2021, 7:47 PM

Change 663398 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/extensions/GlobalWatchlist@wmf/1.36.0-wmf.30] Switch sidebar hook to onSidebarBeforeOutput

https://gerrit.wikimedia.org/r/663398

gerritbot added a project: Patch-For-Review.Feb 11 2021, 7:47 PM
gerritbot added a comment.Feb 11 2021, 10:05 PM

Change 663398 merged by jenkins-bot:
[mediawiki/extensions/GlobalWatchlist@wmf/1.36.0-wmf.30] Switch sidebar hook to onSidebarBeforeOutput

https://gerrit.wikimedia.org/r/663398

jenkins-bot mentioned this in rEGLW120f98e50de1: Switch sidebar hook to onSidebarBeforeOutput.Feb 11 2021, 10:07 PM
Maintenance_bot removed a project: Patch-For-Review.Feb 11 2021, 10:10 PM
DannyS712 closed this task as Resolved.Feb 11 2021, 10:12 PM
DannyS712 claimed this task.
DannyS712 moved this task from In progress to Done on the MediaWiki-extensions-GlobalWatchlist board.
DannyS712 set Final Story Points to 3.
ReleaseTaggerBot edited projects, added MW-1.36-notes (1.36.0-wmf.30; 2021-02-09); removed MW-1.36-notes (1.36.0-wmf.31; 2021-02-16).Feb 11 2021, 11:00 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL