Page MenuHomePhabricator

Replace LogEntry::getPerformer with ::getPerformerIdentity
Open, HighPublic

Description

LogEntry::getPerformer returns a User. UserIdentity should be enough. ManualLogEntry already has getPerformerIdentity - it should just be elevated to the interface and implemented in DatabaseLogEntry. Replace all usages, hard-deprecate.

Details

ProjectBranchLines +/-Subject
mediawiki/coremaster+11 -3
mediawiki/extensions/Thanksmaster+5 -5
mediawiki/extensions/TranslationNotificationsmaster+1 -1
mediawiki/extensions/TranslationNotificationsmaster+1 -1
mediawiki/extensions/Thanksmaster+4 -7
mediawiki/extensions/MobileFrontendmaster+4 -1
mediawiki/extensions/Flowmaster+1 -1
mediawiki/extensions/ArticleFeedbackv5master+1 -1
mediawiki/extensions/IPInfomaster+1 -1
mediawiki/extensions/FileImportermaster+4 -4
mediawiki/extensions/IPInfomaster+1 -1
mediawiki/extensions/Flowmaster+1 -1
mediawiki/coremaster+39 -49
mediawiki/extensions/CentralAuthmaster+1 -1
Show related patches Customize query in gerrit

Event Timeline

Pchelolo created this task.Wed, Feb 10, 3:18 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptWed, Feb 10, 3:18 AM

Additionally, DatabaseLogEntry should use ActorNormalization::getActorById on $row->log_actor only - log_user and user_name fields were deleted from MW database in favor of log_actor, so the getPerformer method can be vastly simplified. Same with RCDatabaseLogEntry::getPerformer

daniel triaged this task as High priority.Thu, Feb 11, 11:49 AM

Change 664326 had a related patch set uploaded (by Vadim Kovalenko; owner: Vadim Kovalenko):
[mediawiki/core@master] Replace LogEntry method

https://gerrit.wikimedia.org/r/664326

Change 664790 had a related patch set uploaded (by Vadim Kovalenko; owner: Vadim Kovalenko):
[mediawiki/extensions/CentralAuth@master] Avoid using LogEntry::getPerformer in favor of getPerformerIdentity

https://gerrit.wikimedia.org/r/664790

Now that the replacement in place, we need to hard-deprecate the old method. e.g. find all usages, replace, hard-deprecate.

Change 664326 merged by jenkins-bot:
[mediawiki/core@master] Introduce LogEntry::getPerformerIdentity and deprecate ::getPerformer

https://gerrit.wikimedia.org/r/664326

Change 664790 merged by jenkins-bot:
[mediawiki/extensions/CentralAuth@master] Avoid using LogEntry::getPerformer in favor of getPerformerIdentity

https://gerrit.wikimedia.org/r/664790

Change 664906 had a related patch set uploaded (by Vadim Kovalenko; owner: Vadim Kovalenko):
[mediawiki/extensions/Thanks@master] Avoid using LogEntry::getPerformer in favor of getPerformerIdentity

https://gerrit.wikimedia.org/r/664906

Change 664908 had a related patch set uploaded (by Vadim Kovalenko; owner: Vadim Kovalenko):
[mediawiki/extensions/FileImporter@master] Avoid using LogEntry::getPerformer in favor of getPerformerIdentity

https://gerrit.wikimedia.org/r/664908

Change 664910 had a related patch set uploaded (by Vadim Kovalenko; owner: Vadim Kovalenko):
[mediawiki/extensions/MobileFrontend@master] Avoid using LogEntry::getPerformer in favor of getPerformerIdentity

https://gerrit.wikimedia.org/r/664910

Change 664912 had a related patch set uploaded (by Vadim Kovalenko; owner: Vadim Kovalenko):
[mediawiki/extensions/TranslationNotifications@master] Avoid using LogEntry::getPerformer in favor of getPerformerIdentity

https://gerrit.wikimedia.org/r/664912

Change 664913 had a related patch set uploaded (by Vadim Kovalenko; owner: Vadim Kovalenko):
[mediawiki/extensions/IPInfo@master] Avoid using LogEntry::getPerformer in favor of getPerformerIdentity

https://gerrit.wikimedia.org/r/664913

Change 664915 had a related patch set uploaded (by Vadim Kovalenko; owner: Vadim Kovalenko):
[mediawiki/extensions/Flow@master] Avoid using LogEntry::getPerformer in favor of getPerformerIdentity

https://gerrit.wikimedia.org/r/664915

Change 664915 abandoned by Vadim Kovalenko:
[mediawiki/extensions/Flow@master] Avoid using LogEntry::getPerformer in favor of getPerformerIdentity

Reason:
redundant patch

https://gerrit.wikimedia.org/r/664915

Change 664913 abandoned by Vadim Kovalenko:
[mediawiki/extensions/IPInfo@master] Avoid using LogEntry::getPerformer in favor of getPerformerIdentity

Reason:
Redundant patch

https://gerrit.wikimedia.org/r/664913

Change 664921 had a related patch set uploaded (by Vadim Kovalenko; owner: Vadim Kovalenko):
[mediawiki/extensions/IPInfo@master] Avoid using LogEntry::getPerformer in favor of getPerformerIdentity

https://gerrit.wikimedia.org/r/664921

Change 664925 had a related patch set uploaded (by Vadim Kovalenko; owner: Vadim Kovalenko):
[mediawiki/extensions/Flow@master] Avoid using LogEntry::getPerformer in favor of getPerformerIdentity

https://gerrit.wikimedia.org/r/664925

Change 664928 had a related patch set uploaded (by Vadim Kovalenko; owner: Vadim Kovalenko):
[mediawiki/extensions/ArticleFeedbackv5@master] Avoid using LogEntry::getPerformer in favor of getPerformerIdentity

https://gerrit.wikimedia.org/r/664928

Change 664908 merged by jenkins-bot:
[mediawiki/extensions/FileImporter@master] Avoid using LogEntry::getPerformer in favor of getPerformerIdentity

https://gerrit.wikimedia.org/r/664908

Change 664925 merged by jenkins-bot:
[mediawiki/extensions/Flow@master] Avoid using LogEntry::getPerformer in favor of getPerformerIdentity

https://gerrit.wikimedia.org/r/664925

Change 664921 merged by jenkins-bot:
[mediawiki/extensions/IPInfo@master] Avoid using LogEntry::getPerformer in favor of getPerformerIdentity

https://gerrit.wikimedia.org/r/664921

Change 664928 merged by jenkins-bot:
[mediawiki/extensions/ArticleFeedbackv5@master] Avoid using LogEntry::getPerformer in favor of getPerformerIdentity

https://gerrit.wikimedia.org/r/664928

Change 664910 merged by jenkins-bot:
[mediawiki/extensions/MobileFrontend@master] Avoid using LogEntry::getPerformer in favor of getPerformerIdentity

https://gerrit.wikimedia.org/r/664910

Change 664906 merged by jenkins-bot:
[mediawiki/extensions/Thanks@master] Avoid using LogEntry::getPerformer in favor of getPerformerIdentity

https://gerrit.wikimedia.org/r/664906

Change 665639 had a related patch set uploaded (by Vadim Kovalenko; owner: Vadim Kovalenko):
[mediawiki/extensions/TranslationNotifications@master] Avoid using LogEntry::getPerformer in favor of getPerformerIdentity

https://gerrit.wikimedia.org/r/665639

Change 664912 abandoned by Vadim Kovalenko:
[mediawiki/extensions/TranslationNotifications@master] Avoid using LogEntry::getPerformer in favor of getPerformerIdentity

Reason:
Fix replaced to separate branch - https://gerrit.wikimedia.org/r/c/mediawiki/extensions/TranslationNotifications/ /665639

https://gerrit.wikimedia.org/r/664912

All merged. Now just left to hard-deprecate the old methods and update RELEASE_NOTES, and this one is done.

Change 665639 merged by jenkins-bot:
[mediawiki/extensions/TranslationNotifications@master] Avoid using LogEntry::getPerformer in favor of getPerformerIdentity

https://gerrit.wikimedia.org/r/665639

Change 666323 had a related patch set uploaded (by Vadim Kovalenko; owner: Vadim Kovalenko):
[mediawiki/core@master] Deprecate LogEntry::getPerformer in favor of ::getPerformerIdentity

https://gerrit.wikimedia.org/r/666323

Change 666378 had a related patch set uploaded (by Vadim Kovalenko; owner: Vadim Kovalenko):
[mediawiki/extensions/Thanks@master] Avoid using LogEntry::getPerformer in favor of getPerformerIdentity

https://gerrit.wikimedia.org/r/666378

Change 666378 merged by jenkins-bot:
[mediawiki/extensions/Thanks@master] Avoid using LogEntry::getPerformer in favor of getPerformerIdentity

https://gerrit.wikimedia.org/r/666378