Page MenuHomePhabricator
Create Task
Maniphest T274329

Replace LogEntry::getPerformer with ::getPerformerIdentity
Closed, ResolvedPublic
Actions

Description

LogEntry::getPerformer returns a User. UserIdentity should be enough. ManualLogEntry already has getPerformerIdentity - it should just be elevated to the interface and implemented in DatabaseLogEntry. Replace all usages, hard-deprecate.

Details

SubjectRepoBranchLines +/-
Avoid using LogEntry::getPerformer in favor of getPerformerIdentitymediawiki/extensions/Commentsmaster+1 -1
Deprecate LogEntry::getPerformer in favor of ::getPerformerIdentitymediawiki/coremaster+11 -3
Avoid using LogEntry::getPerformer in favor of getPerformerIdentitymediawiki/extensions/Thanksmaster+5 -5
Avoid using LogEntry::getPerformer in favor of getPerformerIdentitymediawiki/extensions/TranslationNotificationsmaster+1 -1
Avoid using LogEntry::getPerformer in favor of getPerformerIdentitymediawiki/extensions/TranslationNotificationsmaster+1 -1
Avoid using LogEntry::getPerformer in favor of getPerformerIdentitymediawiki/extensions/Thanksmaster+4 -7
Avoid using LogEntry::getPerformer in favor of getPerformerIdentitymediawiki/extensions/MobileFrontendmaster+4 -1
Avoid using LogEntry::getPerformer in favor of getPerformerIdentitymediawiki/extensions/Flowmaster+1 -1
Avoid using LogEntry::getPerformer in favor of getPerformerIdentitymediawiki/extensions/ArticleFeedbackv5master+1 -1
Avoid using LogEntry::getPerformer in favor of getPerformerIdentitymediawiki/extensions/IPInfomaster+1 -1
Avoid using LogEntry::getPerformer in favor of getPerformerIdentitymediawiki/extensions/FileImportermaster+4 -4
Avoid using LogEntry::getPerformer in favor of getPerformerIdentitymediawiki/extensions/IPInfomaster+1 -1
Avoid using LogEntry::getPerformer in favor of getPerformerIdentitymediawiki/extensions/Flowmaster+1 -1
Introduce LogEntry::getPerformerIdentity and deprecate ::getPerformermediawiki/coremaster+39 -49
Avoid using LogEntry::getPerformer in favor of getPerformerIdentitymediawiki/extensions/CentralAuthmaster+1 -1
Show related patches Customize query in gerrit

Related Objects

Event Timeline

• Pchelolo created this task.Feb 10 2021, 3:18 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptFeb 10 2021, 3:18 AM
• Pchelolo added a comment.Feb 10 2021, 3:26 AM

Additionally, DatabaseLogEntry should use ActorNormalization::getActorById on $row->log_actor only - log_user and user_name fields were deleted from MW database in favor of log_actor, so the getPerformer method can be vastly simplified. Same with RCDatabaseLogEntry::getPerformer

• Not2contro1ever added a commit: rEUREc259d8cac099: Add .gitreview.Feb 10 2021, 5:43 AM
Mainframe98 removed a commit: rEUREc259d8cac099: Add .gitreview.Feb 10 2021, 3:29 PM
• Pchelolo moved this task from Unsorted pile to UserStore pile on the Platform Team Workboards (MW Expedition) board.Feb 10 2021, 4:07 PM
daniel triaged this task as High priority.Feb 11 2021, 11:49 AM
• Pchelolo moved this task from UserStore pile to Doing on the Platform Team Workboards (MW Expedition) board.Feb 11 2021, 6:09 PM
gerritbot added a comment.Feb 15 2021, 7:03 PM

Change 664326 had a related patch set uploaded (by Vadim Kovalenko; owner: Vadim Kovalenko):
[mediawiki/core@master] Replace LogEntry method

https://gerrit.wikimedia.org/r/664326

gerritbot added a project: Patch-For-Review.Feb 15 2021, 7:03 PM
gerritbot added a comment.Feb 17 2021, 11:33 AM

Change 664790 had a related patch set uploaded (by Vadim Kovalenko; owner: Vadim Kovalenko):
[mediawiki/extensions/CentralAuth@master] Avoid using LogEntry::getPerformer in favor of getPerformerIdentity

https://gerrit.wikimedia.org/r/664790

• Pchelolo added a comment.Feb 17 2021, 5:58 PM

Now that the replacement in place, we need to hard-deprecate the old method. e.g. find all usages, replace, hard-deprecate.

gerritbot added a comment.Feb 17 2021, 6:27 PM

Change 664326 merged by jenkins-bot:
[mediawiki/core@master] Introduce LogEntry::getPerformerIdentity and deprecate ::getPerformer

https://gerrit.wikimedia.org/r/664326

gerritbot added a comment.Feb 17 2021, 6:27 PM

Change 664790 merged by jenkins-bot:
[mediawiki/extensions/CentralAuth@master] Avoid using LogEntry::getPerformer in favor of getPerformerIdentity

https://gerrit.wikimedia.org/r/664790

ReleaseTaggerBot added a project: MW-1.36-notes (1.36.0-wmf.32; 2021-02-23).Feb 17 2021, 7:00 PM
Maintenance_bot removed a project: Patch-For-Review.Feb 17 2021, 7:10 PM
gerritbot added a comment.Feb 17 2021, 8:45 PM

Change 664906 had a related patch set uploaded (by Vadim Kovalenko; owner: Vadim Kovalenko):
[mediawiki/extensions/Thanks@master] Avoid using LogEntry::getPerformer in favor of getPerformerIdentity

https://gerrit.wikimedia.org/r/664906

gerritbot added a project: Patch-For-Review.Feb 17 2021, 8:45 PM
gerritbot added a comment.Feb 17 2021, 8:48 PM

Change 664908 had a related patch set uploaded (by Vadim Kovalenko; owner: Vadim Kovalenko):
[mediawiki/extensions/FileImporter@master] Avoid using LogEntry::getPerformer in favor of getPerformerIdentity

https://gerrit.wikimedia.org/r/664908

gerritbot added a comment.Feb 17 2021, 8:52 PM

Change 664910 had a related patch set uploaded (by Vadim Kovalenko; owner: Vadim Kovalenko):
[mediawiki/extensions/MobileFrontend@master] Avoid using LogEntry::getPerformer in favor of getPerformerIdentity

https://gerrit.wikimedia.org/r/664910

gerritbot added a comment.Feb 17 2021, 8:55 PM

Change 664912 had a related patch set uploaded (by Vadim Kovalenko; owner: Vadim Kovalenko):
[mediawiki/extensions/TranslationNotifications@master] Avoid using LogEntry::getPerformer in favor of getPerformerIdentity

https://gerrit.wikimedia.org/r/664912

gerritbot added a comment.Feb 17 2021, 8:59 PM

Change 664913 had a related patch set uploaded (by Vadim Kovalenko; owner: Vadim Kovalenko):
[mediawiki/extensions/IPInfo@master] Avoid using LogEntry::getPerformer in favor of getPerformerIdentity

https://gerrit.wikimedia.org/r/664913

gerritbot added a comment.Feb 17 2021, 9:07 PM

Change 664915 had a related patch set uploaded (by Vadim Kovalenko; owner: Vadim Kovalenko):
[mediawiki/extensions/Flow@master] Avoid using LogEntry::getPerformer in favor of getPerformerIdentity

https://gerrit.wikimedia.org/r/664915

gerritbot added a comment.Feb 17 2021, 9:14 PM

Change 664915 abandoned by Vadim Kovalenko:
[mediawiki/extensions/Flow@master] Avoid using LogEntry::getPerformer in favor of getPerformerIdentity

Reason:
redundant patch

https://gerrit.wikimedia.org/r/664915

gerritbot added a comment.Feb 17 2021, 9:15 PM

Change 664913 abandoned by Vadim Kovalenko:
[mediawiki/extensions/IPInfo@master] Avoid using LogEntry::getPerformer in favor of getPerformerIdentity

Reason:
Redundant patch

https://gerrit.wikimedia.org/r/664913

gerritbot added a comment.Feb 17 2021, 9:21 PM

Change 664921 had a related patch set uploaded (by Vadim Kovalenko; owner: Vadim Kovalenko):
[mediawiki/extensions/IPInfo@master] Avoid using LogEntry::getPerformer in favor of getPerformerIdentity

https://gerrit.wikimedia.org/r/664921

gerritbot added a comment.Feb 17 2021, 9:26 PM

Change 664925 had a related patch set uploaded (by Vadim Kovalenko; owner: Vadim Kovalenko):
[mediawiki/extensions/Flow@master] Avoid using LogEntry::getPerformer in favor of getPerformerIdentity

https://gerrit.wikimedia.org/r/664925

gerritbot added a comment.Feb 17 2021, 9:32 PM

Change 664928 had a related patch set uploaded (by Vadim Kovalenko; owner: Vadim Kovalenko):
[mediawiki/extensions/ArticleFeedbackv5@master] Avoid using LogEntry::getPerformer in favor of getPerformerIdentity

https://gerrit.wikimedia.org/r/664928

gerritbot added a comment.Feb 17 2021, 9:41 PM

Change 664908 merged by jenkins-bot:
[mediawiki/extensions/FileImporter@master] Avoid using LogEntry::getPerformer in favor of getPerformerIdentity

https://gerrit.wikimedia.org/r/664908

vadim-kovalenko mentioned this in rEFLI1063a591a9c9: Avoid using LogEntry::getPerformer in favor of getPerformerIdentity.Feb 17 2021, 9:50 PM
gerritbot added a comment.Feb 18 2021, 4:14 PM

Change 664925 merged by jenkins-bot:
[mediawiki/extensions/Flow@master] Avoid using LogEntry::getPerformer in favor of getPerformerIdentity

https://gerrit.wikimedia.org/r/664925

gerritbot added a comment.Feb 18 2021, 4:14 PM

Change 664921 merged by jenkins-bot:
[mediawiki/extensions/IPInfo@master] Avoid using LogEntry::getPerformer in favor of getPerformerIdentity

https://gerrit.wikimedia.org/r/664921

gerritbot added a comment.Feb 18 2021, 4:14 PM

Change 664928 merged by jenkins-bot:
[mediawiki/extensions/ArticleFeedbackv5@master] Avoid using LogEntry::getPerformer in favor of getPerformerIdentity

https://gerrit.wikimedia.org/r/664928

gerritbot added a comment.Feb 19 2021, 3:59 AM

Change 664910 merged by jenkins-bot:
[mediawiki/extensions/MobileFrontend@master] Avoid using LogEntry::getPerformer in favor of getPerformerIdentity

https://gerrit.wikimedia.org/r/664910

gerritbot added a comment.Feb 19 2021, 2:00 PM

Change 664906 merged by jenkins-bot:
[mediawiki/extensions/Thanks@master] Avoid using LogEntry::getPerformer in favor of getPerformerIdentity

https://gerrit.wikimedia.org/r/664906

gerritbot added a comment.Feb 21 2021, 12:31 PM

Change 665639 had a related patch set uploaded (by Vadim Kovalenko; owner: Vadim Kovalenko):
[mediawiki/extensions/TranslationNotifications@master] Avoid using LogEntry::getPerformer in favor of getPerformerIdentity

https://gerrit.wikimedia.org/r/665639

gerritbot added a comment.Feb 21 2021, 12:42 PM

Change 664912 abandoned by Vadim Kovalenko:
[mediawiki/extensions/TranslationNotifications@master] Avoid using LogEntry::getPerformer in favor of getPerformerIdentity

Reason:
Fix replaced to separate branch - https://gerrit.wikimedia.org/r/c/mediawiki/extensions/TranslationNotifications/ /665639

https://gerrit.wikimedia.org/r/664912

vadim-kovalenko subscribed.Feb 22 2021, 11:55 AM

Patch 665639 depends on 664909

• Pchelolo added a comment.Feb 22 2021, 7:32 PM

All merged. Now just left to hard-deprecate the old methods and update RELEASE_NOTES, and this one is done.

gerritbot added a comment.Feb 22 2021, 7:54 PM

Change 665639 merged by jenkins-bot:
[mediawiki/extensions/TranslationNotifications@master] Avoid using LogEntry::getPerformer in favor of getPerformerIdentity

https://gerrit.wikimedia.org/r/665639

gerritbot added a comment.Feb 23 2021, 11:59 AM

Change 666323 had a related patch set uploaded (by Vadim Kovalenko; owner: Vadim Kovalenko):
[mediawiki/core@master] Deprecate LogEntry::getPerformer in favor of ::getPerformerIdentity

https://gerrit.wikimedia.org/r/666323

gerritbot added a comment.Feb 23 2021, 3:09 PM

Change 666378 had a related patch set uploaded (by Vadim Kovalenko; owner: Vadim Kovalenko):
[mediawiki/extensions/Thanks@master] Avoid using LogEntry::getPerformer in favor of getPerformerIdentity

https://gerrit.wikimedia.org/r/666378

• Pchelolo moved this task from Doing to Waiting for Review on the Platform Team Workboards (MW Expedition) board.Feb 23 2021, 5:54 PM
gerritbot added a comment.Feb 25 2021, 2:43 PM

Change 666378 merged by jenkins-bot:
[mediawiki/extensions/Thanks@master] Avoid using LogEntry::getPerformer in favor of getPerformerIdentity

https://gerrit.wikimedia.org/r/666378

ReleaseTaggerBot edited projects, added MW-1.36-notes (1.36.0-wmf.33; 2021-03-02); removed MW-1.36-notes (1.36.0-wmf.32; 2021-02-23).Feb 25 2021, 3:00 PM
gerritbot added a comment.Mar 1 2021, 10:00 PM

Change 666323 merged by jenkins-bot:
[mediawiki/core@master] Deprecate LogEntry::getPerformer in favor of ::getPerformerIdentity

https://gerrit.wikimedia.org/r/666323

• Pchelolo moved this task from Waiting for Review to On the train on the Platform Team Workboards (MW Expedition) board.Mar 1 2021, 10:03 PM
• Pchelolo mentioned this in T276412: Replace RecentChange::getPerformer with RecentChange::getPerformerIdentity..Mar 4 2021, 5:16 AM
• Pchelolo mentioned this in T276610: Hard-deprecate AbstractBlock::getTarget and introduce AbstractBlock::getTargetIdentity.Mar 5 2021, 6:26 PM
• Pchelolo closed this task as Resolved.Mar 5 2021, 6:34 PM
gerritbot added a comment.Mar 9 2021, 6:14 PM

Change 670256 had a related patch set uploaded (by Vadim Kovalenko; owner: Vadim Kovalenko):
[mediawiki/extensions/Comments@master] Avoid using LogEntry::getPerformer in favor of getPerformerIdentity

https://gerrit.wikimedia.org/r/670256

gerritbot added a comment.Mar 10 2021, 9:33 AM

Change 670256 merged by jenkins-bot:
[mediawiki/extensions/Comments@master] Avoid using LogEntry::getPerformer in favor of getPerformerIdentity

https://gerrit.wikimedia.org/r/670256

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL