Page MenuHomePhabricator

It should be possible to get to input and display settings via the new language button
Closed, ResolvedPublic5 Estimated Story Points

Description

Background

Adding the new language switcher button requires us to remove the languages list from the sidebar as well as the language settings associated with it. To make this available again, following the example of Commons we want to make "display settings" and "input settings" available in the footer of the open dialog for new Vector.

Acceptance criteria

  • Add the "display settings" and "input settings" links to the version of ULS triggered by selecting the language button

Screen Shot 2021-02-10 at 9.54.42 AM.png (764×770 px, 86 KB)

QA

  • Click the language button in modern vector - "display settings" and "input settings" links should be in the footer
  • Click the language button in old Vector - "display settings" and "input settings" links should NOT be in the footer

QA Results - Beta

ACStatusDetails
1T274396#6876116
2T274396#6876116

Event Timeline

Change 663262 had a related patch set uploaded (by Jdlrobson; owner: Jdlrobson):
[mediawiki/extensions/UniversalLanguageSelector@master] Allow access to display and input settings in new vector

https://gerrit.wikimedia.org/r/663262

ovasileva updated the task description. (Show Details)

The proposed patch currently only supports Vector, with a language button. MediaWiki-skins-Mirage now has one of these too, but cannot benefit from the changes made to ULS because it hardcodes support for Vector only. Is there a plan to extend support for other skins too?

(Upstream task: T273985)

Given Vector and Vector classic are currently still the same skin, we'll need some special handling for Vector, but I don't see why I can't expand this patch to have an explicit config change that does the same thing. Can you test out my revised patch?

Jdlrobson set the point value for this task to 5.Feb 16 2021, 6:21 PM

Estimated as large due to the technical debt we're taking on here.

Estimated as large due to the technical debt we're taking on here.

Out of curiosity, is that tech debt being created or being paid off?

Estimated as large due to the technical debt we're taking on here.

Out of curiosity, is that tech debt being created or being paid off?

Added. Because we treat the the legacy Vector and new Vector as the same skin, with the same skin key, we need to provide a hardcoded vector workaround for now. We hope to pay that off in future by splitting the two Vector modes into 2 separate skins by the end of the project.

Change 663262 merged by jenkins-bot:
[mediawiki/extensions/UniversalLanguageSelector@master] Allow access to display and input settings in new vector

https://gerrit.wikimedia.org/r/663262

Test Result - Beta

Status: ✅ PASS
Environment: beta
OS: macOS Big Sur
Browser: Chrome
Device: MBP
Emulated Device: NA

Test Artifact(s):

QA Steps

✅ AC1: Click the language button in modern vector - "display settings" and "input settings" links should be in the footer

Screen Shot 2021-03-02 at 10.21.26 AM.png (405×677 px, 64 KB)

✅ AC2: Click the language button in old Vector - "display settings" and "input settings" links should NOT be in the footer

Screen Shot 2021-03-02 at 10.22.39 AM.png (306×1 px, 47 KB)

ovasileva added a subscriber: ovasileva.

Looks good, resolving!