ForeignWikiRequest.php:135 - PHP Notice: Undefined index: query
Closed, ResolvedPublicPRODUCTION ERROR
Actions

Assigned To

Authored By

	• thcipriani
	Feb 10 2021, 7:32 PM

Description

Error message

PHP Notice: Undefined index: query

Stack Trace

from /srv/mediawiki/php-1.36.0-wmf.27/extensions/Echo/includes/ForeignWikiRequest.php(135)
#0 /srv/mediawiki/php-1.36.0-wmf.27/extensions/Echo/includes/ForeignWikiRequest.php(135): MWExceptionHandler::handleError(integer, string, string, integer, array)
#1 /srv/mediawiki/php-1.36.0-wmf.27/extensions/Echo/includes/ForeignWikiRequest.php(178): EchoForeignWikiRequest->getCsrfToken(string)
#2 /srv/mediawiki/php-1.36.0-wmf.27/extensions/Echo/includes/ForeignWikiRequest.php(159): EchoForeignWikiRequest->getQueryParams(string)
#3 /srv/mediawiki/php-1.36.0-wmf.27/extensions/Echo/includes/ForeignWikiRequest.php(58): EchoForeignWikiRequest->getRequestParams(string, array)
#4 /srv/mediawiki/php-1.36.0-wmf.27/extensions/Echo/includes/api/ApiCrossWiki.php(39): EchoForeignWikiRequest->execute()
#5 /srv/mediawiki/php-1.36.0-wmf.27/extensions/Echo/includes/api/ApiEchoMarkRead.php(44): ApiEchoMarkRead->getFromForeign()
#6 /srv/mediawiki/php-1.36.0-wmf.27/includes/api/ApiMain.php(1612): ApiEchoMarkRead->execute()
#7 /srv/mediawiki/php-1.36.0-wmf.27/includes/api/ApiMain.php(592): ApiMain->executeAction()
#8 /srv/mediawiki/php-1.36.0-wmf.27/includes/api/ApiMain.php(563): ApiMain->executeActionWithErrorHandling()
#9 /srv/mediawiki/php-1.36.0-wmf.27/api.php(90): ApiMain->execute()
#10 /srv/mediawiki/php-1.36.0-wmf.27/api.php(45): wfApiMain()
#11 /srv/mediawiki/w/api.php(3): require(string)
#12 {main}

Impact

Roughly happening at a rate of 1 per hour

Notes

Details

Request ID: YCQo4QpAMNkABA8cfC4AAAFN

Related Changes in Gerrit:

	Subject	Repo	Branch	Lines +/-
	ForeignWikiRequest: Guard against bad response	mediawiki/extensions/Echo	master	+13 -3

Customize query in gerrit

Related Objects

Mentioned Here: T273479: ApiEchoUnreadNotificationPages.php PHP Notice: Undefined index: query

Event Timeline

• thcipriani created this task.Feb 10 2021, 7:32 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptFeb 10 2021, 7:32 PM

• thcipriani renamed this task from ForeignWikiRequest.php:135 - PHP Notice: Undefined index: query to ForeignWikiRequest.php:135 - PHP Notice: Undefined index: query.Feb 10 2021, 7:32 PM

Krinkle moved this task from Jan 2021 to Feb 2021 on the Wikimedia-production-error board.Feb 10 2021, 7:37 PM

This message really started in 1.36.0-wmf.26 -- there are 3 in the roughly 2 months and then there have been 356 sine 1.36.0-wmf.26 rolled out.

Looks similar to T273479 (but different stack trace).

daniel closed this task as a duplicate of T273479: ApiEchoUnreadNotificationPages.php PHP Notice: Undefined index: query.Feb 10 2021, 8:26 PM

I'm still seeing these in 1.36.0-wmf.30. The most recent:

URL: www.wikidata.org/w/api.php

Stack Trace

from /srv/mediawiki/php-1.36.0-wmf.30/extensions/Echo/includes/ForeignWikiRequest.php(135)
#0 /srv/mediawiki/php-1.36.0-wmf.30/extensions/Echo/includes/ForeignWikiRequest.php(135): MWExceptionHandler::handleError(integer, string, string, integer, array)
#1 /srv/mediawiki/php-1.36.0-wmf.30/extensions/Echo/includes/ForeignWikiRequest.php(178): EchoForeignWikiRequest->getCsrfToken(string)
#2 /srv/mediawiki/php-1.36.0-wmf.30/extensions/Echo/includes/ForeignWikiRequest.php(159): EchoForeignWikiRequest->getQueryParams(string)
#3 /srv/mediawiki/php-1.36.0-wmf.30/extensions/Echo/includes/ForeignWikiRequest.php(58): EchoForeignWikiRequest->getRequestParams(string, array)
#4 /srv/mediawiki/php-1.36.0-wmf.30/extensions/Echo/includes/api/ApiCrossWiki.php(39): EchoForeignWikiRequest->execute()
#5 /srv/mediawiki/php-1.36.0-wmf.30/extensions/Echo/includes/api/ApiEchoMarkRead.php(44): ApiEchoMarkRead->getFromForeign()
#6 /srv/mediawiki/php-1.36.0-wmf.30/includes/api/ApiMain.php(1612): ApiEchoMarkRead->execute()
#7 /srv/mediawiki/php-1.36.0-wmf.30/includes/api/ApiMain.php(592): ApiMain->executeAction()
#8 /srv/mediawiki/php-1.36.0-wmf.30/includes/api/ApiMain.php(563): ApiMain->executeActionWithErrorHandling()
#9 /srv/mediawiki/php-1.36.0-wmf.30/api.php(90): ApiMain->execute()
#10 /srv/mediawiki/php-1.36.0-wmf.30/api.php(45): wfApiMain()
#11 /srv/mediawiki/w/api.php(3): require(string)
#12 {main}

dancy reopened this task as Open.Feb 16 2021, 7:37 PM

Change 664775 had a related patch set uploaded (by Kosta Harlan; owner: Kosta Harlan):
[mediawiki/extensions/Echo@master] ForeignWikiRequest: Guard against bad response

https://gerrit.wikimedia.org/r/664775

gerritbot added a project: Patch-For-Review.Feb 17 2021, 9:09 AM

Change 664775 merged by jenkins-bot:
[mediawiki/extensions/Echo@master] ForeignWikiRequest: Guard against bad response

https://gerrit.wikimedia.org/r/664775

ReleaseTaggerBot added a project: MW-1.36-notes (1.36.0-wmf.32; 2021-02-23).Feb 17 2021, 6:00 PM

Maintenance_bot removed a project: Patch-For-Review.Feb 17 2021, 6:10 PM

Krinkle closed this task as Resolved.Feb 25 2021, 4:09 AM

Krinkle assigned this task to kostajh.