ExtensionRegistry should not store configuration settings twice in cache
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Legoktm
	Feb 10 2021, 11:14 PM

Project Tags

Referenced Files

None

Subscribers

Aklapper

Krinkle

Legoktm

Description

https://people.wikimedia.org/~krinkle/apcu-extreg-wmf30.txt

ExtensionRegistry is storing configuration settings under "globals" and then under "config" even though the "config" entry is never used by exportExtractedData.

Details

Related Changes in Gerrit:

	Subject	Author	Repo	Branch	Lines +/-
	Registration: Remove dead code from ExtensionProcessor::extractConfig2	Thiemo Kreuz (WMDE)	mediawiki/core	master	+1 -8
	registration: Stop double-caching config settings	Legoktm	mediawiki/core	master	+0 -8

Customize query in gerrit

Related Objects

Mentioned In: T274648: ExtensionRegistry: Allow reusing cached queues between wikis
T187154: Performance regression from Apcu/ExtensionRegistry::loadFromQueue on PHP7

Event Timeline

Legoktm created this task.Feb 10 2021, 11:14 PM

Legoktm triaged this task as High priority.

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptFeb 10 2021, 11:14 PM

Krinkle mentioned this in T187154: Performance regression from Apcu/ExtensionRegistry::loadFromQueue on PHP7.Feb 10 2021, 11:26 PM

Krinkle added a project: Performance-Team (Radar).

Change 663332 had a related patch set uploaded (by Legoktm; owner: Legoktm):
[mediawiki/core@master] registration: Stop double-caching config settings

https://gerrit.wikimedia.org/r/663332

gerritbot added a project: Patch-For-Review.Feb 11 2021, 12:08 AM

Change 663332 merged by jenkins-bot:
[mediawiki/core@master] registration: Stop double-caching config settings

https://gerrit.wikimedia.org/r/663332

ReleaseTaggerBot added a project: MW-1.36-notes (1.36.0-wmf.31; 2021-02-16).Feb 11 2021, 3:00 AM

Maintenance_bot removed a project: Patch-For-Review.Feb 11 2021, 3:10 AM

Legoktm closed this task as Resolved.Feb 11 2021, 7:52 AM

Legoktm claimed this task.

TK-999 mentioned this in T274648: ExtensionRegistry: Allow reusing cached queues between wikis.Feb 12 2021, 4:03 PM

Change #1245285 had a related patch set uploaded (by Thiemo Kreuz (WMDE); author: Thiemo Kreuz (WMDE)):

[mediawiki/core@master] Remove dead code from ExtensionProcessor

https://gerrit.wikimedia.org/r/1245285

gerritbot added a project: Patch-For-Review.Feb 27 2026, 9:43 AM

Change #1245285 merged by jenkins-bot:

[mediawiki/core@master] Registration: Remove dead code from ExtensionProcessor::extractConfig2