Page MenuHomePhabricator

Ranges in block logs can't be clicked to view contributions anymore
Closed, ResolvedPublic

Description

Block log entries for ranges, like this one on beta should link to the contributions of that IP range like single IPs do. It seems like the 1.36.0-wmf.30 train has broken things and IP ranges are no longer linked to their contributions.

Event Timeline

Can also be replicated on meta/wikimania etc

This also occurs with the block log displayed in Special:Contribs and Special:Block, https://commons.wikimedia.org/wiki/Special:Contributions/109.126.196.166 is an example

Also an issue with Special:BlockList

UserNameUtils service and the underlying IPUtils::isValid() method do not consider IP range as a valid IP address, so they must be handled separately if something is allowed for IP OR IP range

Change 663586 had a related patch set uploaded (by Ammarpad; owner: Ammarpad):
[mediawiki/core@master] Restore userlink for IP range.

https://gerrit.wikimedia.org/r/663586

Change 663586 merged by jenkins-bot:
[mediawiki/core@master] Restore userlink for IP range.

https://gerrit.wikimedia.org/r/663586

hashar added a subscriber: hashar.

Reopening since:

  • beta still show the issue (until the code get automatically pushed there which should happen soon)
  • it should be affecting production since e2b732cd863c5ed3529b14ddd8d8563e6fac90f3 is in 1.36.0-wmf.30. We thus need to backport the patch and deploy it.

deployment-prep code update was broken, I had to cancel a stalled Jenkins job. The change to deployed and the test case shows the ip range being linked https://en.wikipedia.beta.wmflabs.org/w/index.php?title=Special:Log&logid=250502 . So that is fixed in master, just need a backport to wmf/1.36.0-wmf.30 ;)

Change 663738 had a related patch set uploaded (by Majavah; owner: Ammarpad):
[mediawiki/core@wmf/1.36.0-wmf.30] Restore userlink for IP range.

https://gerrit.wikimedia.org/r/663738

Change 663738 abandoned by DannyS712:
[mediawiki/core@wmf/1.36.0-wmf.30] Restore userlink for IP range.

Reason:
wmf.31 is now deployed everywhere, no longer needed

https://gerrit.wikimedia.org/r/663738