SecurePoll: Duplicate input id for custom column labels
Closed, ResolvedPublic5 Estimated Story PointsBUG REPORT
Actions

Assigned To

Authored By

	dom_walden
	Feb 11 2021, 2:09 PM

Description

What is the problem?

When there are more than two questions, if you click Use custom messages for column labels for the 3rd question it will check the box for the 2nd question.

This is because the id attribute of the <input> element is the same for the 2nd and 3rd (or later) questions.

Steps to reproduce problem

Go to Special:SecurePoll/create
For "Poll Type", select one of the 4 "range" types
Click the "Add another question" button twice
In the very last (3rd) question, click the label (not the checkbox itself) which states "Use custom messages for column labels"

Expected behavior: The checkbox next to it is checked
Observed behavior: The checkbox for question 2 is checked

Environment

Browser: Firefox 78
Wiki(s): SecurePoll 2.0.0 (5c73aa8) 07:40, 11 February 2021.

Screenshots (if applicable):

Details

	Subject	Repo	Branch	Lines +/-
	Force unique ids for cloner-generated elements	mediawiki/core	master	+9 -4

Customize query in gerrit

Related Objects

Mentioned Here: rESPO5c73aa875792: Localisation updates from https://translatewiki.net.

Event Timeline

dom_walden created this task.Feb 11 2021, 2:09 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptFeb 11 2021, 2:09 PM

• Niharika triaged this task as Medium priority.Feb 11 2021, 2:10 PM

• Niharika moved this task from Untriaged to Triage/To be Estimated on the Anti-Harassment board.

ARamirez_WMF set the point value for this task to 5.Feb 11 2021, 5:24 PM

ARamirez_WMF moved this task from Triage/To be Estimated to Cards ready for development on the Anti-Harassment board.

ARamirez_WMF moved this task from Cards ready for development to The Letter Song on the Anti-Harassment board.Feb 11 2021, 5:53 PM

ARamirez_WMF edited projects, added Anti-Harassment (The Letter Song); removed Anti-Harassment.

STran claimed this task.Feb 13 2021, 7:26 AM

STran moved this task from Ready 🎬 (ONLY IF YOU HAVE NO MORE CODE TO REVIEW) to In Progress 💪 on the Anti-Harassment (The Letter Song) board.

STran merged a task: T206905: OOUI HTMLFormFieldCloner focusses on the incorrect field when that field has been added by JS.Feb 17 2021, 4:44 PM

STran added subscribers: Mainframe98, Tchanders, matmarex.

Change 664886 had a related patch set uploaded (by STran; owner: STran):
[mediawiki/core@master] Force unique ids for cloner-generated elements

https://gerrit.wikimedia.org/r/664886

gerritbot added a project: Patch-For-Review.Feb 17 2021, 6:42 PM

STran moved this task from In Progress 💪 to Code Review 🔍 on the Anti-Harassment (The Letter Song) board.Feb 17 2021, 8:46 PM

Tchanders moved this task from Code Review 🔍 to QA/Testing 🐞 on the Anti-Harassment (The Letter Song) board.Feb 23 2021, 1:53 PM

Change 664886 merged by jenkins-bot:
[mediawiki/core@master] Force unique ids for cloner-generated elements

https://gerrit.wikimedia.org/r/664886

Maintenance_bot removed a project: Patch-For-Review.Feb 23 2021, 3:10 PM

ReleaseTaggerBot added a project: MW-1.36-notes (1.36.0-wmf.33; 2021-03-02).Feb 23 2021, 10:00 PM

The bug in the description no longer occurs. I have verified that all the labels in the question input go to the right input when you click them.

I tried a number of different ways of interacting with the form (by adding and deleting questions and options), but couldn't generate any duplicate IDs.

We have a global counter that gets iterated each time a new cloner element is created, so ids are unique like ooui-php-61-clone1, ooui-php-61-clone2. The counter is iterated both for new questions and new options for existing questions.

Although we have not (in theory) changed anything relating to how the input gets saved, I did also test creating and editing elections and verifying everything looked ok in the database.

This change is part of core and "cloner" elements are used in a couple of other places:

The Voter Eligibility page (I briefly tested this also, although we might be getting rid of it soon)
https://www.mediawiki.org/wiki/Extension:GlobalWatchlist (This is still in beta, so did not test)
CentralAuth Special:GlobalUserMerge (This special page is disabled everywhere I believe, so did not test)

Test Environment: vote.wikimedia.beta.wmflabs.org (Sorry, I forgot to record the specific version)

• Niharika closed this task as Resolved.Mar 16 2021, 1:50 PM

SecurePoll: Duplicate input id for custom column labelsClosed, ResolvedPublic5 Estimated Story PointsBUG REPORTActions