Page MenuHomePhabricator
Create Task
Maniphest T274535

Replace calls to deprecated methods in TranslatePage (OT)
Closed, ResolvedPublic2 Estimated Story Points
Actions

Description

Calls to the following methods should be replaced:

wfWikiID
Language::fetchLanguageNames
WikiPage::factory Separated into T275792
WikiPage::doEditContent Separated into T275792

The current method can be found in the @deprecated comment above each of these method definitions.

Details

SubjectRepoBranchLines +/-
Replace wfWikiID and Language::fetchLanguageNames with non-deprecated methodsmediawiki/extensions/SecurePollmaster+10 -6
Customize query in gerrit

Related Objects
Search...

Event Timeline

• wikitrent created this task.Feb 11 2021, 2:36 PM
• Niharika moved this task from Untriaged to Onboarding Tasks on the Anti-Harassment board.Feb 11 2021, 2:59 PM
• Niharika set the point value for this task to 2.Feb 11 2021, 5:28 PM
ARamirez_WMF moved this task from Onboarding Tasks to Cards ready for development on the Anti-Harassment board.Feb 11 2021, 5:44 PM
• Niharika moved this task from Cards ready for development to The Letter Song on the Anti-Harassment board.Feb 22 2021, 9:26 PM
• Niharika edited projects, added Anti-Harassment (The Letter Song); removed Anti-Harassment.
• wikitrent claimed this task.Feb 23 2021, 1:07 PM
• wikitrent moved this task from Ready 🎬 (ONLY IF YOU HAVE NO MORE CODE TO REVIEW) to In Progress 💪 on the Anti-Harassment (The Letter Song) board.
gerritbot added a comment.Feb 24 2021, 3:06 PM

Change 666649 had a related patch set uploaded (by Wikitrent; owner: Wikitrent):
[mediawiki/extensions/SecurePoll@master] Replace wfWikiID and Language::fetchLanguageNames with non-deprecated methods

https://gerrit.wikimedia.org/r/666649

gerritbot added a project: Patch-For-Review.Feb 24 2021, 3:06 PM
gerritbot added a comment.Feb 25 2021, 3:14 PM

Change 666911 had a related patch set uploaded (by Wikitrent; owner: Wikitrent):
[mediawiki/extensions/SecurePoll@master] Replace WikiPage methods with current methods

https://gerrit.wikimedia.org/r/666911

• wikitrent moved this task from In Progress 💪 to Code Review 🔍 on the Anti-Harassment (The Letter Song) board.Feb 25 2021, 3:18 PM
Tchanders updated the task description. (Show Details)Feb 25 2021, 4:29 PM

@wikitrent I've separated the WikiPage work into a separate task (see this task's description). Would you mind tagging the second patch against that one instead?

Tchanders moved this task from Code Review 🔍 to Done: Q3 (2020-2021) on the Anti-Harassment (The Letter Song) board.Feb 25 2021, 5:02 PM
gerritbot added a comment.Feb 25 2021, 5:07 PM

Change 666649 merged by jenkins-bot:
[mediawiki/extensions/SecurePoll@master] Replace wfWikiID and Language::fetchLanguageNames with non-deprecated methods

https://gerrit.wikimedia.org/r/666649

ReleaseTaggerBot added a project: MW-1.36-notes (1.36.0-wmf.33; 2021-03-02).Feb 25 2021, 6:00 PM
• Niharika closed this task as Resolved.Mar 4 2021, 4:20 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL