Page MenuHomePhabricator
Create Task
Maniphest T274544

Support multiple transclusions (i.e. templates) in the new template dialog sidebar
Closed, ResolvedPublic8 Estimated Story Points
Actions

Description

  • Wire template and raw wikitext transclusion *headings* into sidebar view.
  • Sidebar shows multiple templates and raw wikitext transclusion blocks
  • Show the titles as headings in the checkbox list pane.
  • Each template should have its own checkbox list view

Details

ProjectBranchLines +/-Subject
mediawiki/extensions/VisualEditormaster+9 -20Remove unused code from ve.ui.MWTransclusionOutlinePartWidget
mediawiki/extensions/VisualEditormaster+56 -25Fix incomplete template dialog event handling in new sidebar
mediawiki/extensions/VisualEditormaster+16 -6Fix template editor showing more than one new sidebar
mediawiki/extensions/VisualEditormaster+36 -10Focus template editor elements on click in the new sidebar
mediawiki/extensions/VisualEditormaster+76 -60Finishing touches to new template editor sidebar
mediawiki/extensions/VisualEditormaster+6 -1Make button to add undocumented template parameter work
mediawiki/extensions/VisualEditormaster+37 -20Make new template editor sidebar items actual ButtonElements
mediawiki/extensions/VisualEditormaster+56 -60Reuse generic button widget for elements in the new sidebar
mediawiki/extensions/VisualEditormaster+27 -5Various design tweaks to the new template dialog sidebar
mediawiki/extensions/VisualEditormaster+36 -7Update new sidebar when moving template parts up/down
mediawiki/extensions/VisualEditormaster+27 -6More robust debug container for new template editor sitebar
mediawiki/extensions/VisualEditormaster+57 -30Full add/delete support for all 3 types in template sidebar
mediawiki/extensions/VisualEditormaster+72 -25Add template outline widgets for all content types
mediawiki/extensions/VisualEditormaster+45 -22Move template outline item header into the base class
mediawiki/extensions/VisualEditormaster+42 -3Add wikitext content item to new template editor sidebar
mediawiki/extensions/VisualEditormaster+23 -37Replace custom template header widget with button
mediawiki/extensions/VisualEditormaster+2 -14Remove empty container widgets that don't do anything
mediawiki/extensions/VisualEditormaster+25 -2Abstract base class for top-level items in template editor
mediawiki/extensions/VisualEditormaster+8 -13Rename CSS classes in new template dialog sidebar code
Show related patches Customize query in gerrit

Related Objects
Search...

StatusSubtypeAssignedTask
 ResolvedWMDE-FischT306967 Deploy VE template dialog improvements to enwiki
 ResolvedLena_WMDET296759 Deploy VE template dialog improvements to more wikis
 ResolvedLena_WMDET286992 Deploy VE template dialog improvements to small set of wikis
 ResolvedWMDE-FischT272487 New input for undocumented parameters
 ResolvedWMDE-FischT272482 Show/hide advanced toolbar when multi-part content is present
 ResolvedECohen_WMDET272368 Add checkboxes to param list sidebar in VE TemplateDialog
 ResolvedWMDE-FischT274542 Fork / subclass / include variations in BookletLayout for new VisualEditor template dialog
 ResolvedawightT274539 Implement new VisualEditor template dialog enhanced sidebar feature flag
 DeclinedNoneT274541 Adapt VisualEditor template dialog code to reduce duplication after fork
 ResolvedNoneT274548 VisualEditor template "required" parameter handling
 InvalidNoneT274549 Handle "no parameter" templates
 ResolvedthiemowmdeT274551 "deprecated" parameter handling
 Resolvedlilients_WMDET274552 Synchronize scroll and focus between content and outline panes
 InvalidNoneT274546 Maintain order of checkboxes and content
 ResolvedthiemowmdeT288202 Parameter search also filters main content area
 ResolvedAndrew-WMDET274554 Make sidebar responsive
 ResolvedAndrew-WMDET275761 Remove the trash icons which show next to the parameter name when it's "in focus"
 ResolvedNoneT274547 Handle checkbox clicks in VisualEditor template dialog sidebar
 ResolvedNoneT272481 Add parameter search to sidebar of VE TemplateDialog
 ResolvedthiemowmdeT274544 Support multiple transclusions (i.e. templates) in the new template dialog sidebar
 ResolvedAndrew-WMDET274550 Handle undocumented template parameters
 ResolvedWMDE-FischT274545 Wire template parameters into the checkbox list view
 ResolvedLena_WMDET274538 Design new VisualEditor template dialog data model and data propagation
 ResolvedNoneT276325 Review proof-of-concept VE template dialog sidebar code
 ResolvedawightT274543 Create a new checkbox list view for the VisualEditor template dialog
 ResolvedAndrew-WMDET285044 Fix parameter sidebar overflowing text ellipsis
 InvalidNoneT285289 Sidebar containers should receive initial parameters through regular add events
 ResolvedthiemowmdeT285382 Preserve parameter serialization order
 ResolvedawightT216808 VE shuffles the order of template parameters in template dialog
 ResolvedBUG REPORTthiemowmdeT286715 Sidebars overlap after adding undocumented parameters
 ResolvedWMDE-FischT286765 Prepare sidebar feature for deploy on beta and deploy on beta
 DuplicateBUG REPORTNoneT287384 Pathological duplicate aliases could be displayed in sidebar menu
 ResolvedECohen_WMDET285869 Add error handling for the undocumented parameter input
 InvalidNoneT291059 [DRAFT] Adjust messages for special alias edge cases

Event Timeline

awight created this task.Feb 11 2021, 3:06 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptFeb 11 2021, 3:06 PM
awight added a project: VisualEditor-MediaWiki-Templates.Feb 11 2021, 3:20 PM
Maintenance_bot added a project: VisualEditor.Feb 11 2021, 3:46 PM
matmarex moved this task from To Triage to Triaged on the VisualEditor board.Feb 11 2021, 4:09 PM
awight updated the task description. (Show Details)Feb 25 2021, 1:22 PM
awight updated the task description. (Show Details)Feb 25 2021, 1:29 PM
Lena_WMDE moved this task from Backlog to In preparation on the WMDE-Templates-FocusArea board.Mar 10 2021, 1:54 PM
awight added a parent task: T272481: Add parameter search to sidebar of VE TemplateDialog.Mar 10 2021, 2:22 PM
awight updated the task description. (Show Details)Mar 10 2021, 2:24 PM
awight updated the task description. (Show Details)Mar 11 2021, 2:23 PM
awight set the point value for this task to 8.Mar 11 2021, 2:36 PM
awight removed a parent task: T272368: Add checkboxes to param list sidebar in VE TemplateDialog.Mar 11 2021, 2:53 PM
Lena_WMDE moved this task from In preparation to Ready for pickup on the WMDE-Templates-FocusArea board.Apr 14 2021, 8:25 AM
Lena_WMDE moved this task from Ready for pickup to Ready for story time on the WMDE-Templates-FocusArea board.Apr 23 2021, 10:43 AM
awight renamed this task from Support multiple transclusions (i.e. templates) in the template dialog sidebar to Support multiple transclusions (i.e. templates) in the new template dialog sidebar.May 14 2021, 7:41 AM
awight added a subtask: T274545: Wire template parameters into the checkbox list view.
Lena_WMDE moved this task from Ready for story time to Ready for pickup on the WMDE-Templates-FocusArea board.May 14 2021, 7:45 AM
ECohen_WMDE mentioned this in T272368: Add checkboxes to param list sidebar in VE TemplateDialog.Jun 30 2021, 12:21 PM
WMDE-Fisch closed subtask T274545: Wire template parameters into the checkbox list view as Resolved.Jul 6 2021, 11:30 AM
thiemowmde claimed this task.Jul 7 2021, 12:22 PM
thiemowmde added a project: WMDE-TechWish-Sprint-2021-07-07.
thiemowmde moved this task from Ready for pickup to In sprint on the WMDE-Templates-FocusArea board.
thiemowmde moved this task from Sprint Backlog to Doing on the WMDE-TechWish-Sprint-2021-07-07 board.
gerritbot added a comment.Jul 8 2021, 3:47 PM

Change 703763 had a related patch set uploaded (by Thiemo Kreuz (WMDE); author: Thiemo Kreuz (WMDE)):

[mediawiki/extensions/VisualEditor@master] Add wikitext content item to new template editor sidebar

https://gerrit.wikimedia.org/r/703763

gerritbot added a project: Patch-For-Review.Jul 8 2021, 3:47 PM
gerritbot added a comment.Jul 8 2021, 4:43 PM

Change 703780 had a related patch set uploaded (by Thiemo Kreuz (WMDE); author: Thiemo Kreuz (WMDE)):

[mediawiki/extensions/VisualEditor@master] Replace custom template header widget with button

https://gerrit.wikimedia.org/r/703780

gerritbot added a comment.Jul 9 2021, 1:32 PM

Change 703844 had a related patch set uploaded (by Thiemo Kreuz (WMDE); author: Thiemo Kreuz (WMDE)):

[mediawiki/extensions/VisualEditor@master] Rename CSS classes in new template dialog sidebar code

https://gerrit.wikimedia.org/r/703844

gerritbot added a comment.Jul 9 2021, 1:51 PM

Change 703845 had a related patch set uploaded (by Thiemo Kreuz (WMDE); author: Thiemo Kreuz (WMDE)):

[mediawiki/extensions/VisualEditor@master] Abstract base class for top-level items in template editor

https://gerrit.wikimedia.org/r/703845

gerritbot added a comment.Jul 9 2021, 1:58 PM

Change 703846 had a related patch set uploaded (by Thiemo Kreuz (WMDE); author: Thiemo Kreuz (WMDE)):

[mediawiki/extensions/VisualEditor@master] Remove empty container widgets that don't do anything

https://gerrit.wikimedia.org/r/703846

gerritbot added a comment.Jul 9 2021, 2:48 PM

Change 703853 had a related patch set uploaded (by Thiemo Kreuz (WMDE); author: Thiemo Kreuz (WMDE)):

[mediawiki/extensions/VisualEditor@master] Move template outline item header into the base class

https://gerrit.wikimedia.org/r/703853

gerritbot added a comment.Jul 9 2021, 3:07 PM

Change 703855 had a related patch set uploaded (by Thiemo Kreuz (WMDE); author: Thiemo Kreuz (WMDE)):

[mediawiki/extensions/VisualEditor@master] Add template outline widgets for all content types

https://gerrit.wikimedia.org/r/703855

gerritbot added a comment.Jul 9 2021, 3:35 PM

Change 703858 had a related patch set uploaded (by Thiemo Kreuz (WMDE); author: Thiemo Kreuz (WMDE)):

[mediawiki/extensions/VisualEditor@master] Full add/delete support for all 3 types in template sidebar

https://gerrit.wikimedia.org/r/703858

gerritbot added a comment.Jul 9 2021, 4:09 PM

Change 703844 merged by jenkins-bot:

[mediawiki/extensions/VisualEditor@master] Rename CSS classes in new template dialog sidebar code

https://gerrit.wikimedia.org/r/703844

gerritbot added a comment.Jul 9 2021, 4:09 PM

Change 703845 merged by jenkins-bot:

[mediawiki/extensions/VisualEditor@master] Abstract base class for top-level items in template editor

https://gerrit.wikimedia.org/r/703845

gerritbot added a comment.Jul 9 2021, 4:14 PM

Change 703846 merged by jenkins-bot:

[mediawiki/extensions/VisualEditor@master] Remove empty container widgets that don't do anything

https://gerrit.wikimedia.org/r/703846

ReleaseTaggerBot added a project: MW-1.37-notes (1.37.0-wmf.14; 2021-07-12).Jul 9 2021, 5:00 PM
gerritbot added a comment.Jul 12 2021, 7:25 AM

Change 703780 abandoned by Thiemo Kreuz (WMDE):

[mediawiki/extensions/VisualEditor@master] Replace custom template header widget with button

Reason:

Replaced with I1a62ff6.

https://gerrit.wikimedia.org/r/703780

gerritbot added a comment.Jul 12 2021, 7:26 AM

Change 703763 abandoned by Thiemo Kreuz (WMDE):

[mediawiki/extensions/VisualEditor@master] Add wikitext content item to new template editor sidebar

Reason:

Replaced with If4219b0.

https://gerrit.wikimedia.org/r/703763

gerritbot added a comment.Jul 12 2021, 9:24 AM

Change 703853 merged by jenkins-bot:

[mediawiki/extensions/VisualEditor@master] Move template outline item header into the base class

https://gerrit.wikimedia.org/r/703853

gerritbot added a comment.Jul 12 2021, 10:52 AM

Change 703855 merged by jenkins-bot:

[mediawiki/extensions/VisualEditor@master] Add template outline widgets for all content types

https://gerrit.wikimedia.org/r/703855

gerritbot added a comment.Jul 12 2021, 2:04 PM

Change 703858 merged by jenkins-bot:

[mediawiki/extensions/VisualEditor@master] Full add/delete support for all 3 types in template sidebar

https://gerrit.wikimedia.org/r/703858

gerritbot added a comment.Jul 13 2021, 7:12 AM

Change 704276 had a related patch set uploaded (by Thiemo Kreuz (WMDE); author: Thiemo Kreuz (WMDE)):

[mediawiki/extensions/VisualEditor@master] More robust debug container for new template editor sitebar

https://gerrit.wikimedia.org/r/704276

gerritbot added a comment.Jul 13 2021, 8:20 AM

Change 704280 had a related patch set uploaded (by Thiemo Kreuz (WMDE); author: Thiemo Kreuz (WMDE)):

[mediawiki/extensions/VisualEditor@master] Update new sidebar when moving template parts up/down

https://gerrit.wikimedia.org/r/704280

gerritbot added a comment.Jul 13 2021, 8:58 AM

Change 704285 had a related patch set uploaded (by Thiemo Kreuz (WMDE); author: Thiemo Kreuz (WMDE)):

[mediawiki/extensions/VisualEditor@master] Various design tweaks to the new template dialog sidebar

https://gerrit.wikimedia.org/r/704285

gerritbot added a comment.Jul 13 2021, 9:25 AM

Change 704291 had a related patch set uploaded (by Thiemo Kreuz (WMDE); author: Thiemo Kreuz (WMDE)):

[mediawiki/extensions/VisualEditor@master] Reuse generic button widget for elements in the new sidebar

https://gerrit.wikimedia.org/r/704291

gerritbot added a comment.Jul 13 2021, 10:26 AM

Change 704306 had a related patch set uploaded (by Thiemo Kreuz (WMDE); author: Thiemo Kreuz (WMDE)):

[mediawiki/extensions/VisualEditor@master] Make new template editor sidebar items actual ButtonElements

https://gerrit.wikimedia.org/r/704306

gerritbot added a comment.Jul 13 2021, 10:34 AM

Change 704308 had a related patch set uploaded (by Thiemo Kreuz (WMDE); author: Thiemo Kreuz (WMDE)):

[mediawiki/extensions/VisualEditor@master] Make button to add undocumented template parameter work

https://gerrit.wikimedia.org/r/704308

gerritbot added a comment.Jul 13 2021, 11:06 AM

Change 704312 had a related patch set uploaded (by Thiemo Kreuz (WMDE); author: Thiemo Kreuz (WMDE)):

[mediawiki/extensions/VisualEditor@master] Focus template editor elements on click in the new sidebar

https://gerrit.wikimedia.org/r/704312

gerritbot added a comment.Jul 13 2021, 11:14 AM

Change 704276 merged by jenkins-bot:

[mediawiki/extensions/VisualEditor@master] More robust debug container for new template editor sitebar

https://gerrit.wikimedia.org/r/704276

ReleaseTaggerBot edited projects, added MW-1.37-notes (1.37.0-wmf.15; 2021-07-19); removed MW-1.37-notes (1.37.0-wmf.14; 2021-07-12).Jul 13 2021, 12:00 PM
gerritbot added a comment.Jul 13 2021, 7:09 PM

Change 704406 had a related patch set uploaded (by Thiemo Kreuz (WMDE); author: Thiemo Kreuz (WMDE)):

[mediawiki/extensions/VisualEditor@master] Finishing touches to new template editor sidebar

https://gerrit.wikimedia.org/r/704406

gerritbot added a comment.Jul 14 2021, 8:41 AM

Change 704280 merged by jenkins-bot:

[mediawiki/extensions/VisualEditor@master] Update new sidebar when moving template parts up/down

https://gerrit.wikimedia.org/r/704280

gerritbot added a comment.Jul 14 2021, 8:42 AM

Change 704285 merged by jenkins-bot:

[mediawiki/extensions/VisualEditor@master] Various design tweaks to the new template dialog sidebar

https://gerrit.wikimedia.org/r/704285

gerritbot added a comment.Jul 14 2021, 9:59 AM

Change 704291 merged by jenkins-bot:

[mediawiki/extensions/VisualEditor@master] Reuse generic button widget for elements in the new sidebar

https://gerrit.wikimedia.org/r/704291

gerritbot added a comment.Jul 15 2021, 8:39 AM

Change 704306 merged by jenkins-bot:

[mediawiki/extensions/VisualEditor@master] Make new template editor sidebar items actual ButtonElements

https://gerrit.wikimedia.org/r/704306

gerritbot added a comment.Jul 15 2021, 9:15 AM

Change 704308 merged by jenkins-bot:

[mediawiki/extensions/VisualEditor@master] Make button to add undocumented template parameter work

https://gerrit.wikimedia.org/r/704308

gerritbot added a comment.Jul 15 2021, 9:15 AM

Change 704312 merged by jenkins-bot:

[mediawiki/extensions/VisualEditor@master] Focus template editor elements on click in the new sidebar

https://gerrit.wikimedia.org/r/704312

gerritbot added a comment.Jul 15 2021, 9:15 AM

Change 704406 merged by jenkins-bot:

[mediawiki/extensions/VisualEditor@master] Finishing touches to new template editor sidebar

https://gerrit.wikimedia.org/r/704406

WMDE-Fisch moved this task from Doing to Demo on the WMDE-TechWish-Sprint-2021-07-07 board.Jul 15 2021, 12:15 PM
gerritbot added a comment.Jul 15 2021, 1:04 PM

Change 704783 had a related patch set uploaded (by Thiemo Kreuz (WMDE); author: Thiemo Kreuz (WMDE)):

[mediawiki/extensions/VisualEditor@master] Fix template editor showing more than one new sidebar

https://gerrit.wikimedia.org/r/704783

gerritbot added a comment.Jul 15 2021, 3:16 PM

Change 704804 had a related patch set uploaded (by Thiemo Kreuz (WMDE); author: Thiemo Kreuz (WMDE)):

[mediawiki/extensions/VisualEditor@master] Fix incomplete template dialog event handling in new sidebar

https://gerrit.wikimedia.org/r/704804

gerritbot added a comment.Jul 16 2021, 10:18 AM

Change 704783 merged by jenkins-bot:

[mediawiki/extensions/VisualEditor@master] Fix template editor showing more than one new sidebar

https://gerrit.wikimedia.org/r/704783

gerritbot added a comment.Jul 16 2021, 1:07 PM

Change 704804 merged by jenkins-bot:

[mediawiki/extensions/VisualEditor@master] Fix incomplete template dialog event handling in new sidebar

https://gerrit.wikimedia.org/r/704804

WMDE-Fisch closed this task as Resolved.Jul 20 2021, 9:16 AM
WMDE-Fisch updated the task description. (Show Details)
WMDE-Fisch moved this task from Demo to Done on the WMDE-TechWish-Sprint-2021-07-07 board.
gerritbot added a comment.Aug 10 2021, 3:03 PM

Change 711148 had a related patch set uploaded (by Thiemo Kreuz (WMDE); author: Thiemo Kreuz (WMDE)):

[mediawiki/extensions/VisualEditor@master] Remove unused code from ve.ui.MWTransclusionOutlinePartWidget

https://gerrit.wikimedia.org/r/711148

gerritbot added a comment.Aug 19 2021, 1:43 PM

Change 711148 merged by jenkins-bot:

[mediawiki/extensions/VisualEditor@master] Remove unused code from ve.ui.MWTransclusionOutlinePartWidget

https://gerrit.wikimedia.org/r/711148

Content licensed under Creative Commons Attribution-ShareAlike 4.0 (CC-BY-SA) unless otherwise noted; code licensed under GNU General Public License (GPL) or other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL