Page MenuHomePhabricator
Create Task
Maniphest T274545

Wire template parameters into the checkbox list view
Closed, ResolvedPublic5 Estimated Story Points
Actions

Description

  • Show all possible parameters as checkboxes.
  • Parameters are checked when present in content.
  • Don't worry about handling undocumented parameters yet. See T274550: Handle undocumented template parameters
  • Listen to content model events: add and remove parameters
  • Order param list in sidebar and main input area based on:
    • If existing, use TemplateData order (ParamOrder or order of parameters as listed in TemplateData)
    • If TemplateData is missing, auto-order based on the order of parameters in the template definition/source code
  • Parameters should be encapsulated in per-template containers.

Patch-For-Review:

Details

Show related patches Customize query in gerrit

Related Objects
Search...

StatusSubtypeAssignedTask
 ResolvedWMDE-FischT306967 Deploy VE template dialog improvements to enwiki
 ResolvedLena_WMDET296759 Deploy VE template dialog improvements to more wikis
 ResolvedLena_WMDET286992 Deploy VE template dialog improvements to small set of wikis
 ResolvedWMDE-FischT272487 New input for undocumented parameters
 ResolvedWMDE-FischT272482 Show/hide advanced toolbar when multi-part content is present
 ResolvedECohen_WMDET272368 Add checkboxes to param list sidebar in VE TemplateDialog
 ResolvedNoneT274548 VisualEditor template "required" parameter handling
 InvalidNoneT274549 Handle "no parameter" templates
 ResolvedthiemowmdeT274551 "deprecated" parameter handling
 ResolvedAndrew-WMDET275761 Remove the trash icons which show next to the parameter name when it's "in focus"
 ResolvedNoneT274547 Handle checkbox clicks in VisualEditor template dialog sidebar
 ResolvedNoneT272481 Add parameter search to sidebar of VE TemplateDialog
 ResolvedthiemowmdeT274544 Support multiple transclusions (i.e. templates) in the new template dialog sidebar
 ResolvedAndrew-WMDET274550 Handle undocumented template parameters
 ResolvedWMDE-FischT274545 Wire template parameters into the checkbox list view
 ResolvedLena_WMDET274538 Design new VisualEditor template dialog data model and data propagation
 ResolvedNoneT276325 Review proof-of-concept VE template dialog sidebar code
 ResolvedawightT274543 Create a new checkbox list view for the VisualEditor template dialog
 ResolvedAndrew-WMDET285044 Fix parameter sidebar overflowing text ellipsis
 InvalidNoneT285289 Sidebar containers should receive initial parameters through regular add events
 ResolvedthiemowmdeT285382 Preserve parameter serialization order
 ResolvedawightT216808 VE shuffles the order of template parameters in template dialog
 ResolvedECohen_WMDET285869 Add error handling for the undocumented parameter input
 InvalidNoneT291059 [DRAFT] Adjust messages for special alias edge cases

Event Timeline

awight created this task.Feb 11 2021, 3:07 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptFeb 11 2021, 3:07 PM
awight added a project: VisualEditor-MediaWiki-Templates.Feb 11 2021, 3:20 PM
Maintenance_bot added a project: VisualEditor.Feb 11 2021, 3:46 PM
matmarex moved this task from To Triage to Triaged on the VisualEditor board.Feb 11 2021, 4:08 PM
Lena_WMDE moved this task from Backlog to In preparation on the WMDE-Templates-FocusArea board.Mar 10 2021, 1:54 PM
awight added a subtask: T274538: Design new VisualEditor template dialog data model and data propagation.Mar 11 2021, 2:42 PM
awight added a subtask: T274543: Create a new checkbox list view for the VisualEditor template dialog.
awight added a parent task: T274548: VisualEditor template "required" parameter handling.Mar 11 2021, 2:44 PM
awight added a parent task: T274549: Handle "no parameter" templates.
awight added a parent task: T274550: Handle undocumented template parameters.
awight added a parent task: T274551: "deprecated" parameter handling.
awight added a parent task: T274547: Handle checkbox clicks in VisualEditor template dialog sidebar.Mar 11 2021, 2:47 PM
awight removed a parent task: T272368: Add checkboxes to param list sidebar in VE TemplateDialog.Mar 11 2021, 2:52 PM
Andrew-WMDE updated the task description. (Show Details)Apr 21 2021, 12:34 PM
Andrew-WMDE mentioned this in T274546: Maintain order of checkboxes and content.Apr 21 2021, 12:37 PM
Andrew-WMDE subscribed.Apr 21 2021, 12:42 PM

Watch out for paramOrder (https://www.mediawiki.org/wiki/Help:TemplateData#Required_property_%22paramOrder(number)%22_not_found)

awight added a parent task: T274544: Support multiple transclusions (i.e. templates) in the new template dialog sidebar.May 14 2021, 7:42 AM
Lena_WMDE moved this task from In preparation to Ready for pickup on the WMDE-Templates-FocusArea board.May 14 2021, 7:56 AM
awight added a comment.May 19 2021, 9:27 AM

There's an interesting implementation question here, about which module takes responsibility for interpreting the TemplateModel and ParameterModels and converting to inputs for creating checkboxes.

awight updated the task description. (Show Details)Jun 9 2021, 11:57 AM
awight claimed this task.Jun 17 2021, 8:36 AM
awight moved this task from Ready for pickup to In sprint on the WMDE-Templates-FocusArea board.

Pulling this in because it's a good way to explore the event-driven data flow.

gerritbot added a comment.Jun 17 2021, 11:30 AM

Change 700190 had a related patch set uploaded (by Awight; author: Awight):

[mediawiki/extensions/VisualEditor@master] [WIP] Wire model changes into new template sidebar

https://gerrit.wikimedia.org/r/700190

gerritbot added a project: Patch-For-Review.Jun 17 2021, 11:30 AM
gerritbot added a comment.Jun 18 2021, 8:51 AM

Change 700346 had a related patch set uploaded (by Awight; author: Awight):

[mediawiki/extensions/VisualEditor@master] [WIP] New function to get all potential template parameters, in order

https://gerrit.wikimedia.org/r/700346

gerritbot added a comment.Jun 18 2021, 9:05 AM

Change 700350 had a related patch set uploaded (by Awight; author: Awight):

[mediawiki/extensions/VisualEditor@master] [WIP] Fall back from explicit parameter order to TemplateData sort

https://gerrit.wikimedia.org/r/700350

gerritbot added a comment.Jun 18 2021, 11:30 AM

Change 700362 had a related patch set uploaded (by Awight; author: Awight):

[mediawiki/extensions/VisualEditor@master] Tests for MWTemplateModel parameter ordering

https://gerrit.wikimedia.org/r/700362

gerritbot added a comment.Jun 18 2021, 1:00 PM

Change 700362 merged by jenkins-bot:

[mediawiki/extensions/VisualEditor@master] Tests for MWTemplateModel parameter ordering

https://gerrit.wikimedia.org/r/700362

gerritbot added a comment.Jun 18 2021, 1:30 PM

Change 700346 merged by jenkins-bot:

[mediawiki/extensions/VisualEditor@master] Function to get all potential template parameters, in order

https://gerrit.wikimedia.org/r/700346

ReleaseTaggerBot added a project: MW-1.37-notes (1.37.0-wmf.11; 2021-06-21).Jun 18 2021, 2:00 PM
gerritbot added a comment.Jun 18 2021, 3:30 PM

Change 700392 had a related patch set uploaded (by Andrew-WMDE; author: Andrew-WMDE):

[mediawiki/extensions/VisualEditor@master] [WIP] Configure adding and removing parameters

https://gerrit.wikimedia.org/r/700392

gerritbot added a comment.Jun 18 2021, 4:02 PM

Change 700398 had a related patch set uploaded (by Awight; author: Awight):

[mediawiki/extensions/VisualEditor@master] Tests for getAllParametersOrdered

https://gerrit.wikimedia.org/r/700398

awight closed subtask T274543: Create a new checkbox list view for the VisualEditor template dialog as Resolved.Jun 18 2021, 5:15 PM
gerritbot added a comment.Jun 18 2021, 6:22 PM

Change 700408 had a related patch set uploaded (by Awight; author: Awight):

[mediawiki/extensions/VisualEditor@master] [WIP] Handle aliases when building parameter order

https://gerrit.wikimedia.org/r/700408

gerritbot added a comment.Jun 21 2021, 9:22 AM

Change 700485 had a related patch set uploaded (by Andrew-WMDE; author: Andrew-WMDE):

[mediawiki/extensions/VisualEditor@master] Remove extraneous ve.ui.MWTemplateOutlineCheckboxListWidget.js

https://gerrit.wikimedia.org/r/700485

gerritbot added a comment.Jun 21 2021, 10:53 AM

Change 700517 had a related patch set uploaded (by Awight; author: Awight):

[mediawiki/extensions/VisualEditor@master] Label for each template in sidebar

https://gerrit.wikimedia.org/r/700517

gerritbot added a comment.Jun 21 2021, 2:22 PM

Change 700619 had a related patch set uploaded (by Andrew-WMDE; author: Andrew-WMDE):

[mediawiki/extensions/VisualEditor@master] "Add more information" should be a button instead of a checkbox

https://gerrit.wikimedia.org/r/700619

awight edited projects, added WMDE-TechWish-Sprint-2021-06-09, Unplanned-Sprint-Work; removed WMDE-TechWish.Jun 22 2021, 6:56 AM

It made sense to do this work next, so pulling into the sprint.

awight closed subtask T285289: Sidebar containers should receive initial parameters through regular add events as Invalid.Jun 22 2021, 7:45 AM
Lena_WMDE closed subtask T274538: Design new VisualEditor template dialog data model and data propagation as Resolved.Jun 22 2021, 8:38 AM
gerritbot added a comment.Jun 22 2021, 12:37 PM

Change 700398 merged by jenkins-bot:

[mediawiki/extensions/VisualEditor@master] Tests for getAllParametersOrdered

https://gerrit.wikimedia.org/r/700398

gerritbot added a comment.Jun 22 2021, 12:43 PM

Change 700350 merged by jenkins-bot:

[mediawiki/extensions/VisualEditor@master] Fall back from explicit parameter order to TemplateData sort

https://gerrit.wikimedia.org/r/700350

awight added a comment.Jun 22 2021, 6:46 PM

Please note that this patch was reverted, https://gerrit.wikimedia.org/r/700350 "Fall back from explicit parameter order to TemplateData sort".

We need to reimplement but without affecting serialization order, it seems that the users don't want this behavior. According to T138200: TemplateData: Normalisation should not assume paramOrder, they expect paramOrder to cause parameter shuffling when saving, but do not expect the implicit order of parameters to do the same thing.

WMDE-Fisch set the point value for this task to 5.Jun 23 2021, 8:22 AM
WMDE-Fisch edited projects, added WMDE-TechWish-Sprint-2021-06-23; removed Unplanned-Sprint-Work.
awight mentioned this in T285382: Preserve parameter serialization order.Jun 23 2021, 10:28 AM
gerritbot added a comment.Jun 23 2021, 2:32 PM

Change 701115 had a related patch set uploaded (by Awight; author: Awight):

[mediawiki/extensions/VisualEditor@master] Revert "Revert "Fall back from explicit parameter order to TemplateData sort""

https://gerrit.wikimedia.org/r/701115

gerritbot added a comment.Jun 24 2021, 9:15 AM

Change 701115 merged by jenkins-bot:

[mediawiki/extensions/VisualEditor@master] Revert "Revert "Fall back from explicit parameter order to TemplateData sort""

https://gerrit.wikimedia.org/r/701115

gerritbot added a comment.Jun 24 2021, 9:31 AM

Change 700190 merged by jenkins-bot:

[mediawiki/extensions/VisualEditor@master] Wire model changes into new template sidebar

https://gerrit.wikimedia.org/r/700190

gerritbot added a comment.Jun 24 2021, 9:37 AM

Change 700485 merged by jenkins-bot:

[mediawiki/extensions/VisualEditor@master] Remove extraneous ve.ui.MWTemplateOutlineCheckboxListWidget.js

https://gerrit.wikimedia.org/r/700485

ReleaseTaggerBot edited projects, added MW-1.37-notes (1.37.0-wmf.12; 2021-06-28); removed MW-1.37-notes (1.37.0-wmf.11; 2021-06-21).Jun 24 2021, 10:00 AM
gerritbot added a comment.Jun 24 2021, 10:39 AM

Change 700619 merged by jenkins-bot:

[mediawiki/extensions/VisualEditor@master] "Add more information" should be a button instead of a checkbox

https://gerrit.wikimedia.org/r/700619

gerritbot added a comment.Jun 24 2021, 10:55 AM

Change 700392 merged by jenkins-bot:

[mediawiki/extensions/VisualEditor@master] Wiring for adding and removing parameters

https://gerrit.wikimedia.org/r/700392

gerritbot added a comment.Jun 24 2021, 12:34 PM

Change 700517 merged by jenkins-bot:

[mediawiki/extensions/VisualEditor@master] Label for each template in sidebar

https://gerrit.wikimedia.org/r/700517

Andrew-WMDE moved this task from Sprint Backlog to Doing on the WMDE-TechWish-Sprint-2021-06-23 board.Jun 26 2021, 1:59 PM
ECohen_WMDE updated the task description. (Show Details)Jun 30 2021, 8:41 AM
ECohen_WMDE mentioned this in T272368: Add checkboxes to param list sidebar in VE TemplateDialog.Jun 30 2021, 12:21 PM
lilients_WMDE moved this task from Doing to Sprint Backlog on the WMDE-TechWish-Sprint-2021-06-23 board.Jul 2 2021, 7:50 AM
thiemowmde removed awight as the assignee of this task.Jul 2 2021, 7:51 AM
gerritbot added a comment.Jul 5 2021, 8:14 AM

Change 701885 had a related patch set uploaded (by WMDE-Fisch; author: Andrew-WMDE):

[mediawiki/extensions/VisualEditor@master] Fix parameter ordering when using aliases

https://gerrit.wikimedia.org/r/701885

gerritbot added a comment.Jul 5 2021, 8:33 AM

Change 701885 merged by jenkins-bot:

[mediawiki/extensions/VisualEditor@master] Fix parameter ordering when using aliases

https://gerrit.wikimedia.org/r/701885

ReleaseTaggerBot edited projects, added MW-1.37-notes (1.37.0-wmf.14; 2021-07-12); removed MW-1.37-notes (1.37.0-wmf.12; 2021-06-28).Jul 5 2021, 9:00 AM
thiemowmde moved this task from Sprint Backlog to Demo on the WMDE-TechWish-Sprint-2021-06-23 board.Jul 5 2021, 3:22 PM
thiemowmde updated the task description. (Show Details)
WMDE-Fisch closed subtask T285382: Preserve parameter serialization order as Resolved.Jul 6 2021, 11:27 AM
WMDE-Fisch closed this task as Resolved.Jul 6 2021, 11:30 AM
WMDE-Fisch claimed this task.
WMDE-Fisch moved this task from Demo to Done on the WMDE-TechWish-Sprint-2021-06-23 board.Jul 6 2021, 11:40 AM
Winston_Sung added a subtask: T216808: VE shuffles the order of template parameters in template dialog.Nov 29 2021, 4:04 PM
gerritbot added a comment.Mar 24 2023, 7:45 PM

Change 700408 abandoned by Bartosz Dziewoński:

[mediawiki/extensions/VisualEditor@master] Handle aliases when building parameter order

Reason:

Associated task is already resolved, so presumably this patch is no longer needed.

https://gerrit.wikimedia.org/r/700408

Maintenance_bot removed a project: Patch-For-Review.Mar 24 2023, 8:10 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits