Page MenuHomePhabricator
Create Task
Maniphest T274547

Handle checkbox clicks in VisualEditor template dialog sidebar
Closed, ResolvedPublic5 Estimated Story Points
Actions

Description

  • When a parameter is not yet added, then clicking on the parameter name adds it. Clicking on the name again though does not remove it.
  • Clickable area for the add/remove function is limited to the checkbox itself and does not include the name of the parameter
  • When a parameter is removed, keep the parameter "in focus"/selected if it's a named parameter and will remain in the sidebar → T274552
  • Update content pane to synchronize with removal and addition

Related Objects
Search...

StatusSubtypeAssignedTask
 ResolvedWMDE-FischT306967 Deploy VE template dialog improvements to enwiki
 ResolvedLena_WMDET296759 Deploy VE template dialog improvements to more wikis
 ResolvedLena_WMDET286992 Deploy VE template dialog improvements to small set of wikis
 ResolvedWMDE-FischT272487 New input for undocumented parameters
 ResolvedWMDE-FischT272482 Show/hide advanced toolbar when multi-part content is present
 ResolvedECohen_WMDET272368 Add checkboxes to param list sidebar in VE TemplateDialog
 ResolvedAndrew-WMDET275761 Remove the trash icons which show next to the parameter name when it's "in focus"
 ResolvedNoneT274547 Handle checkbox clicks in VisualEditor template dialog sidebar
 ResolvedWMDE-FischT274545 Wire template parameters into the checkbox list view
 ResolvedLena_WMDET274538 Design new VisualEditor template dialog data model and data propagation
 ResolvedNoneT276325 Review proof-of-concept VE template dialog sidebar code
 ResolvedawightT274543 Create a new checkbox list view for the VisualEditor template dialog
 ResolvedAndrew-WMDET285044 Fix parameter sidebar overflowing text ellipsis
 InvalidNoneT285289 Sidebar containers should receive initial parameters through regular add events
 ResolvedthiemowmdeT285382 Preserve parameter serialization order
 ResolvedawightT216808 VE shuffles the order of template parameters in template dialog
 ResolvedECohen_WMDET285869 Add error handling for the undocumented parameter input
 InvalidNoneT291059 [DRAFT] Adjust messages for special alias edge cases

Event Timeline

awight created this task.Feb 11 2021, 3:14 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptFeb 11 2021, 3:14 PM
awight added a project: VisualEditor-MediaWiki-Templates.Feb 11 2021, 3:20 PM
Maintenance_bot added a project: VisualEditor.Feb 11 2021, 3:46 PM
matmarex moved this task from To Triage to Triaged on the VisualEditor board.Feb 11 2021, 4:08 PM
Lena_WMDE moved this task from Backlog to In preparation on the WMDE-Templates-FocusArea board.Mar 10 2021, 1:54 PM
awight added a subtask: T274545: Wire template parameters into the checkbox list view.Mar 11 2021, 2:47 PM
Lena_WMDE updated the task description. (Show Details)Apr 14 2021, 1:30 PM
Lena_WMDE set the point value for this task to 5.
awight updated the task description. (Show Details)May 14 2021, 7:48 AM
Lena_WMDE moved this task from In preparation to Ready for pickup on the WMDE-Templates-FocusArea board.May 14 2021, 7:56 AM
awight added a parent task: T275761: Remove the trash icons which show next to the parameter name when it's "in focus".May 14 2021, 7:57 AM
awight updated the task description. (Show Details)Jun 21 2021, 10:23 AM
WMDE-Fisch closed subtask T274545: Wire template parameters into the checkbox list view as Resolved.Jul 6 2021, 11:30 AM
thiemowmde added a project: WMDE-TechWish-Sprint-2021-07-07.Jul 16 2021, 9:25 AM
thiemowmde updated the task description. (Show Details)
thiemowmde moved this task from Sprint Backlog to Demo on the WMDE-TechWish-Sprint-2021-07-07 board.
thiemowmde moved this task from Ready for pickup to In sprint on the WMDE-Templates-FocusArea board.Jul 16 2021, 9:28 AM
WMDE-Fisch closed this task as Resolved.Jul 20 2021, 9:14 AM
WMDE-Fisch moved this task from Demo to Done on the WMDE-TechWish-Sprint-2021-07-07 board.
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL