Handle undocumented template parameters
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	awight
	Feb 11 2021, 3:17 PM

Description

Requirements

When an undocumented parameter is unchecked, its outline element should remain for that edit session only. If the template is saved while it's unchecked, then re-opened its outline element should be gone.
Focus changes in the same way as documented parameters when checked/unchecked.
Add a message next to the label "(Undocumented parameter)" 13px, Base30, italic.

Related: the input for undocumented parameter is done in T272487: New input for undocumented parameters

Mock

Undoc param marking.png (642×800 px, 38 KB)

Details

	Subject	Repo	Branch	Lines +/-
	Add a message next to undocumented parameters	mediawiki/extensions/VisualEditor	master	+37 -2
	Keep undocumented parameters in the sidebar when unchecked	mediawiki/extensions/VisualEditor	master	+1 -7

Customize query in gerrit

Related Objects
Search...

Status	Assigned	Task
Resolved	WMDE-Fisch	T306967 Deploy VE template dialog improvements to enwiki
Resolved	Lena_WMDE	T296759 Deploy VE template dialog improvements to more wikis
Resolved	Lena_WMDE	T286992 Deploy VE template dialog improvements to small set of wikis
Resolved	WMDE-Fisch	T272487 New input for undocumented parameters
Resolved	WMDE-Fisch	T272482 Show/hide advanced toolbar when multi-part content is present
Resolved	ECohen_WMDE	T272368 Add checkboxes to param list sidebar in VE TemplateDialog
Resolved	None	T272481 Add parameter search to sidebar of VE TemplateDialog
Resolved	Andrew-WMDE	T274550 Handle undocumented template parameters
Resolved	WMDE-Fisch	T274545 Wire template parameters into the checkbox list view
Resolved	Lena_WMDE	T274538 Design new VisualEditor template dialog data model and data propagation
Resolved	None	T276325 Review proof-of-concept VE template dialog sidebar code
Resolved	awight	T274543 Create a new checkbox list view for the VisualEditor template dialog
Resolved	Andrew-WMDE	T285044 Fix parameter sidebar overflowing text ellipsis
Invalid	None	T285289 Sidebar containers should receive initial parameters through regular add events
Resolved	thiemowmde	T285382 Preserve parameter serialization order
Resolved	awight	T216808 VE shuffles the order of template parameters in template dialog
Resolved	ECohen_WMDE	T285869 Add error handling for the undocumented parameter input
Invalid	None	T291059 [DRAFT] Adjust messages for special alias edge cases

Event Timeline

awight created this task.Feb 11 2021, 3:17 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptFeb 11 2021, 3:17 PM

awight added a project: VisualEditor-MediaWiki-Templates.Feb 11 2021, 3:20 PM

Maintenance_bot added a project: VisualEditor.Feb 11 2021, 3:45 PM

matmarex moved this task from To Triage to Triaged on the VisualEditor board.Feb 11 2021, 4:08 PM

Lena_WMDE moved this task from Backlog to In preparation on the WMDE-Templates-FocusArea board.Mar 10 2021, 1:54 PM

awight updated the task description. (Show Details)Mar 10 2021, 2:45 PM

awight added a subtask: T274545: Wire template parameters into the checkbox list view.Mar 11 2021, 2:44 PM

Andrew-WMDE added a subtask: T274551: "deprecated" parameter handling.Apr 14 2021, 1:22 PM

Andrew-WMDE updated the task description. (Show Details)Apr 21 2021, 12:30 PM

Andrew-WMDE mentioned this in T274546: Maintain order of checkboxes and content.Apr 21 2021, 12:37 PM

awight removed a subtask: T274551: "deprecated" parameter handling.May 14 2021, 7:58 AM

Lena_WMDE moved this task from In preparation to Ready for pickup on the WMDE-Templates-FocusArea board.May 14 2021, 8:09 AM

awight added a parent task: T272481: Add parameter search to sidebar of VE TemplateDialog.May 14 2021, 8:12 AM

awight mentioned this in T274543: Create a new checkbox list view for the VisualEditor template dialog.May 17 2021, 2:08 PM

ECohen_WMDE mentioned this in T274545: Wire template parameters into the checkbox list view.Jun 30 2021, 8:41 AM

ECohen_WMDE updated the task description. (Show Details)Jun 30 2021, 8:46 AM

ECohen_WMDE mentioned this in T272368: Add checkboxes to param list sidebar in VE TemplateDialog.Jun 30 2021, 12:21 PM

ECohen_WMDE updated the task description. (Show Details)Jun 30 2021, 1:07 PM

ECohen_WMDE updated the task description. (Show Details)Jun 30 2021, 1:12 PM

ECohen_WMDE updated the task description. (Show Details)Jun 30 2021, 3:19 PM

Change 702204 had a related patch set uploaded (by WMDE-Fisch; author: Andrew-WMDE):

[mediawiki/extensions/VisualEditor@master] Keep undocumented parameters in the sidebar when unchecked

https://gerrit.wikimedia.org/r/702204

gerritbot added a project: Patch-For-Review.Jul 5 2021, 8:19 AM

Change 702204 merged by jenkins-bot:

[mediawiki/extensions/VisualEditor@master] Keep undocumented parameters in the sidebar when unchecked

https://gerrit.wikimedia.org/r/702204

Maintenance_bot removed a project: Patch-For-Review.Jul 5 2021, 9:10 AM

ReleaseTaggerBot added a project: MW-1.37-notes (1.37.0-wmf.14; 2021-07-12).Jul 5 2021, 10:00 AM

WMDE-Fisch closed subtask T274545: Wire template parameters into the checkbox list view as Resolved.Jul 6 2021, 11:30 AM

Andrew-WMDE claimed this task.Jul 15 2021, 9:29 AM

Andrew-WMDE added projects: WMDE-TechWish-Sprint-2021-07-07, Unplanned-Sprint-Work.

Andrew-WMDE moved this task from Sprint Backlog to Doing on the WMDE-TechWish-Sprint-2021-07-07 board.

WMDE-Fisch updated the task description. (Show Details)Jul 15 2021, 12:11 PM

WMDE-Fisch updated the task description. (Show Details)

Change 704782 had a related patch set uploaded (by Andrew-WMDE; author: Andrew-WMDE):

[mediawiki/extensions/VisualEditor@master] Add a message next to undocumented parameters

https://gerrit.wikimedia.org/r/704782

gerritbot added a project: Patch-For-Review.Jul 15 2021, 12:58 PM

Andrew-WMDE moved this task from Ready for pickup to In sprint on the WMDE-Templates-FocusArea board.Jul 15 2021, 1:10 PM

Andrew-WMDE moved this task from Doing to Review on the WMDE-TechWish-Sprint-2021-07-07 board.Jul 15 2021, 1:17 PM

Just as small FYI, that we're now having two different words used for these parameters now. (Unknown and Undocumented) I guess this will be resolved, when the "Add more information" field is removed, but I still wanted to write that down.