Page MenuHomePhabricator
Create Task
Maniphest T274604

Add i18n for the tags display
Closed, ResolvedPublic2 Estimated Story Points
Actions

Description

Instead of hard-coding English Tags: , we should use a message

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
Clean up tags handlingmediawiki/extensions/GlobalWatchlistmaster+47 -9
Customize query in gerrit

Related Objects

Event Timeline

DannyS712 created this task.Feb 11 2021, 11:21 PM
Restricted Application added a project: User-DannyS712. · View Herald TranscriptFeb 11 2021, 11:21 PM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
DannyS712 triaged this task as Low priority.Feb 11 2021, 11:22 PM
DannyS712 moved this task from Unsorted to Next on the User-DannyS712 board.
DannyS712 set the point value for this task to 2.
DannyS712 updated the task description. (Show Details)Feb 17 2021, 11:18 PM
gerritbot added a comment.Feb 18 2021, 12:07 AM

Change 664664 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/extensions/GlobalWatchlist@master] Clean up tags handling

https://gerrit.wikimedia.org/r/664664

gerritbot added a project: Patch-For-Review.Feb 18 2021, 12:07 AM
DannyS712 claimed this task.Feb 18 2021, 12:51 AM
DannyS712 moved this task from Backlog to In progress on the MediaWiki-extensions-GlobalWatchlist board.
DannyS712 moved this task from Next to Awaiting review and deployment on the User-DannyS712 board.
gerritbot added a comment.Jul 7 2021, 10:42 PM

Change 664664 merged by jenkins-bot:

[mediawiki/extensions/GlobalWatchlist@master] Clean up tags handling

https://gerrit.wikimedia.org/r/664664

jenkins-bot mentioned this in rEGLW813d861340bd: Clean up tags handling.Jul 7 2021, 10:42 PM
DannyS712 closed this task as Resolved.Jul 7 2021, 11:01 PM
DannyS712 moved this task from In progress to Done on the MediaWiki-extensions-GlobalWatchlist board.
DannyS712 set Final Story Points to 2.

Testing on the beta cluster shows that there is now an i18n message instead of the hardcoded English (confirmed via uselang=qqx) and for the English display correctly switches between "Tag:" and "Tags:"

DannyS712 mentioned this in T286309: Links in tags should also open in separate tabs.Jul 7 2021, 11:05 PM
Maintenance_bot removed a project: Patch-For-Review.Jul 7 2021, 11:11 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits