Page MenuHomePhabricator

libup should remove exclude of vendor/node_modules from .phpcs.xml
Open, Needs TriagePublic


Since the following command in .phpcs.xml no longer needed:



<exclude-pattern type="relative">^vendor/</exclude-pattern>
<exclude-pattern type="relative">^node_modules/</exclude-pattern>

Mininum version would be mediawiki/mediawiki-codesniffer v0.10.0, but that is very old and may not needed explicit check

Current repo with some variants:

Event Timeline

Now also coverage is ignored (done by and libup can remove it, for this part the version is v36.0.0 (release planned as of this now)

Change 694603 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[labs/libraryupgrader@master] remove exclude of vendor/node_modules from .phpcs.xml