Page MenuHomePhabricator

libup should remove exclude of vendor/node_modules from .phpcs.xml
Open, Needs TriagePublic

Description

Since https://gerrit.wikimedia.org/r/c/mediawiki/tools/codesniffer/+/362266 the following command in .phpcs.xml no longer needed:

<exclude-pattern>vendor</exclude-pattern>
<exclude-pattern>node_modules</exclude-pattern>

or

<exclude-pattern type="relative">^vendor/</exclude-pattern>
<exclude-pattern type="relative">^node_modules/</exclude-pattern>

Mininum version would be mediawiki/mediawiki-codesniffer v0.10.0, but that is very old and may not needed explicit check

Current repo with some variants:
https://codesearch.wmcloud.org/search/?q=%3Cexclude-pattern(%20type%3D%22relative%22)%3F%3E%5C%5E%3F%2F%3F(%5C.git%7Cvendor%7Cnode_modules)%2F%3F%3C%2Fexclude-pattern%3E&i=nope&files=%5C.phpcs%5C.xml%24&excludeFiles=&repos=

Event Timeline

Now also coverage is ignored (done by https://gerrit.wikimedia.org/r/c/mediawiki/tools/codesniffer/+/681483) and libup can remove it, for this part the version is v36.0.0 (release planned as of this now)

Change 694603 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[labs/libraryupgrader@master] remove exclude of vendor/node_modules from .phpcs.xml

https://gerrit.wikimedia.org/r/694603