Page MenuHomePhabricator

Remove redundant message "sites with changes"
Closed, ResolvedPublic2 Estimated Story PointsDesign

Description

Hi. Now we have maximum five sites to watch. So it looks redundant to show the message "sites with changes" in cases when all sites have changes. It makes sense only if at least one haven't, in opposite to "sites without changes" section. I suggest to remove the first message if the second does not appear. I do not suggest to remove the second message if no site has changes, for clarity. Thanks.

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald Transcript
IKhitron changed the subtype of this task from "Task" to "Design".Feb 14 2021, 12:10 AM
DannyS712 updated the task description. (Show Details)
DannyS712 set the point value for this task to 2.
DannyS712 moved this task from Unsorted to Next on the User-DannyS712 board.

This would also be an opportunity to solve the bug I was about to report of the "sites with changes" not disappearing during refresh
We also probably don't need to collapse the list of sites without changes if its so few

Change 664663 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/extensions/GlobalWatchlist@master] Cleanup display of sites with vs. without changes

https://gerrit.wikimedia.org/r/664663

Change 664663 merged by jenkins-bot:
[mediawiki/extensions/GlobalWatchlist@master] Cleanup display of sites with vs. without changes

https://gerrit.wikimedia.org/r/664663

@DannyS712, something's wrong. Looks like this merge brokes the structure when there are site sites without changes, they appear in a list without any collapsing or collapsable.

@DannyS712, something's wrong. Looks like this merge brokes the structure when there are site sites without changes, they appear in a list without any collapsing or collapsable.

That was intentional, since at the time there were only 5 sites max... might be worth adding it back though now that its up to 50