Hi. Now we have maximum five sites to watch. So it looks redundant to show the message "sites with changes" in cases when all sites have changes. It makes sense only if at least one haven't, in opposite to "sites without changes" section. I suggest to remove the first message if the second does not appear. I do not suggest to remove the second message if no site has changes, for clarity. Thanks.
Description
Description
Details
Details
| Project | Branch | Lines +/- | Subject | |
|---|---|---|---|---|
| mediawiki/extensions/GlobalWatchlist | master | +20 -47 | Cleanup display of sites with vs. without changes |
Related Objects
Related Objects
Event Timeline
Comment Actions
This would also be an opportunity to solve the bug I was about to report of the "sites with changes" not disappearing during refresh
We also probably don't need to collapse the list of sites without changes if its so few
Comment Actions
Change 664663 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/extensions/GlobalWatchlist@master] Cleanup display of sites with vs. without changes
Comment Actions
Change 664663 merged by jenkins-bot:
[mediawiki/extensions/GlobalWatchlist@master] Cleanup display of sites with vs. without changes
Comment Actions
@DannyS712, something's wrong. Looks like this merge brokes the structure when there are site sites without changes, they appear in a list without any collapsing or collapsable.
Comment Actions
That was intentional, since at the time there were only 5 sites max... might be worth adding it back though now that its up to 50