Page MenuHomePhabricator

Guide UX for submitting a patch through the web interface
Closed, InvalidPublic

Description

Due to habit and configuration problems, I tend to use the web interface to submit patches. The interface is obviously relatively hidden and somewhat inconvenient. I write here in anticipation of some improvements.
https://www.mediawiki.org/wiki/Gerrit/Tutorial#Editing_via_the_web-interface

  1. The "Commands" menu is unremarkable in repo interface.
  2. I expect the destination branch to be pre-filled with the default branch name in "Create Change".
  3. Make it clear that this will be a draft submission. Allow leave blank the commit message to fill in later.
  4. The blue Reply (comment) button I expect bigger and lower, not at the top, my eyes always miss it.
  5. When you haven't clicked the "Publish Changes", the submitted changes are empty, Gerrit or robots does not give me a warning when/after click the mark as active (roughly means), I wrongly thought the changes have been posted. example A, example B and example C.

Event Timeline

Aklapper removed a project: Documentation.

The "Commands" menu is unremarkable in repo interface.

I don't know what that means, or what exactly you expect, or why it should be more "remarkable" than other items. Please see https://www.mediawiki.org/wiki/How_to_report_a_bug which also asks you to describe what you expect. This is how things look here:

Screenshot from 2021-02-14 18-15-23.png (445×1 px, 87 KB)

Screenshot from 2021-02-14 18-15-40.png (445×499 px, 63 KB)

I expect the destination branch to be pre-filled with the default branch name in "Create Change".

That's a separate feature request for upstream.

Make it clear that this will be a draft submission.

What is a "draft"? Why do you think something is a draft? If you refer to the "Work in Progress" flag, I now documented this on https://www.mediawiki.org/wiki/Gerrit/Tutorial

Allow leave blank the commit message to fill in later.

This lacks any explanation why - it's a proposed solution without a problem. Please follow https://www.mediawiki.org/wiki/How_to_report_a_bug .

The blue Reply (comment) button I expect bigger and lower, not at the top, my eyes always miss it.

There is no "Reply" button while creating a draft.

When you haven't clicked the "Publish Changes", the submitted changes are empty

That's why the instructions tell you to click "Publish Changes". It's unclear to me what you expect, please see https://www.mediawiki.org/wiki/How_to_report_a_bug .

This task covers too many different things and is not actionable, so I am closing it.
For future reference, please follow https://www.mediawiki.org/wiki/How_to_report_a_bug .
Furthermore, most aspects seem to refer to upstream user interface issues. It is very unlikely that Wikimedia itself will make any such custom changes and maintain them. You can find upstream's issue tracker at https://bugs.chromium.org/p/gerrit/issues/list where it's more likely that people might be interested in make such changes.

This is how things look here:

Interesting. I always look for it from the left sidebar, and it looks unremarkable.

That's a separate feature request for upstream.

Okay, it's fair.

What is a "draft"? Why do you think something is a draft? If you refer to the "Work in Progress" flag, I now documented this on

Well, maybe I want to say that it will be modifiable? This may not matter.

There is no "Reply" button while creating a draft.

I would like to add some comments to the requests I have created, but I often cannot find the button. This is probably a feature request to upstream...

That's why the instructions tell you to click "Publish Changes".

This is easy to miss. One complaint to upstream, probably.

Thank you for your response, maybe I need more experience for Gerrit.