Clicking a link in the original panel leaves the editor
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Pginer-WMF
	Feb 16 2021, 10:47 AM

Description

Currently when the user is in the "edit a sentence" step (T251928) to correct the initial machine translation, clicking on a link from the original panel causes the browser to navigate away:

Screenshot 2021-02-16 at 11.36.36 2.png (548×531 px, 92 KB)

In order to better support the exploration of links we can consider one of the options below:

Show a preview card for the link at the bottom of the page. Ideally reusing work form Page previews or the Android app equivalent.
Open links in a new tab/window if the above is too complicated technically.

Details

	Subject	Repo	Branch	Lines +/-
	Fix: Clicking a link in the original content panel leaves the editor	mediawiki/extensions/ContentTranslation	master	+13 -0

Customize query in gerrit

Related Objects
Search...

Status	Assigned	Task
Open	None	T243495 [Epic] Support for Section Translation
Open	None	T251928 Section Translation Editor: Edit a sentence
Resolved	• santhosh	T274868 Clicking a link in the original panel leaves the editor

Event Timeline

Pginer-WMF triaged this task as Medium priority.Feb 16 2021, 10:47 AM

Pginer-WMF created this task.

Pginer-WMF moved this task from Backlog to Mobile editor on the SectionTranslation board.Feb 16 2021, 2:33 PM

Pginer-WMF edited projects, added Language-Team (Language-2021-April-June); removed Language-Team (Language-2021-January-March).Apr 1 2021, 4:16 PM

Pginer-WMF edited projects, added Language-Team (Language-2021-July-September); removed Language-Team (Language-2021-April-June).Jul 12 2021, 1:44 PM

Pginer-WMF edited projects, added Language-Team (Language-2021-October-December); removed Language-Team (Language-2021-July-September).Oct 1 2021, 12:36 PM

Pginer-WMF edited projects, added Language-Team (Language-2022-January-March); removed Language-Team (Language-2021-October-December).Dec 3 2021, 12:03 PM

Pginer-WMF updated the task description. (Show Details)Jan 21 2022, 11:11 AM

Pginer-WMF mentioned this in T299755: Clicking a link in the reference inspector leaves the editor.

Pginer-WMF updated the task description. (Show Details)Jan 21 2022, 11:21 AM

Pginer-WMF edited projects, added Language-Team (Language-2022-April-June); removed Language-Team (Language-2022-January-March).Mar 30 2022, 5:27 PM

Pginer-WMF moved this task from Quarter Backlog to Priority: SX Adoption on the Language-Team (Language-2022-April-June) board.

Pginer-WMF moved this task from Priority: SX Adoption to Quarter Backlog on the Language-Team (Language-2022-April-June) board.Apr 1 2022, 2:32 PM

Wikipedia preview component could be used to support this feature but it would bring an increase of 46.1kb (when minified + gzipped) in size - according to bundlephobia.com -, which is probably not acceptable for this case.

Pginer-WMF moved this task from Quarter Backlog to Priority: SX Adoption on the Language-Team (Language-2022-April-June) board.Jun 7 2022, 3:03 PM

Change 805109 had a related patch set uploaded (by Santhosh; author: Santhosh):

[mediawiki/extensions/ContentTranslation@master] Fix: Clicking a link in the original content panel leaves the editor

https://gerrit.wikimedia.org/r/805109

gerritbot added a project: Patch-For-Review.Jun 13 2022, 11:31 AM

In T274868#7967544, @ngkountas wrote:

Wikipedia preview component could be used to support this feature but it would bring an increase of 46.1kb (when minified + gzipped) in size - according to bundlephobia.com -, which is probably not acceptable for this case.

I had filed a bug about this long time back - https://github.com/wikimedia/wikipedia-preview/issues/137That libraries bundle size is unreasonabbly high.

In https://gerrit.wikimedia.org/r/805109 I just added target="_blank" to all links in the panel.

• santhosh moved this task from Priority: SX Adoption to In Review on the Language-Team (Language-2022-April-June) board.Jun 13 2022, 11:35 AM

Change 805109 merged by jenkins-bot:

[mediawiki/extensions/ContentTranslation@master] Fix: Clicking a link in the original content panel leaves the editor

https://gerrit.wikimedia.org/r/805109

ReleaseTaggerBot added a project: MW-1.39-notes (1.39.0-wmf.17; 2022-06-20).Jun 14 2022, 8:00 AM

Maintenance_bot removed a project: Patch-For-Review.Jun 14 2022, 8:30 AM

• santhosh moved this task from In Review to Needs QA on the Language-Team (Language-2022-April-June) board.Jun 28 2022, 4:37 AM

@santhosh it does seem this is still happening.

Article used: Meningitis
SX Translation: english --> igbo
browser: Google Chrome

See attachment

clicking_link_navigates-away.mp4426 KBDownload

I am going to push this story back to in progress

Pginer-WMF edited projects, added Language-Team (Language-2022-July-September); removed Language-Team (Language-2022-April-June).Jul 4 2022, 10:56 AM

Pginer-WMF moved this task from Quarter Backlog to In Progress on the Language-Team (Language-2022-July-September) board.

As demonstrated by the following screencast this issue seems to be currently fixed. The test case is exact the same that Emeka used in the previous screencast. Another issue appears, as the link redirects to an invalid URL but we can create a separate task for this one. Moving this one to "Needs QA" so that it can be verified.

ngkountas moved this task from In Progress to Needs QA on the Language-Team (Language-2022-July-September) board.Aug 2 2022, 3:39 PM

@ngkountas in your video it did open the link in another tab in the browser

I am using a mobile emulator ( it should not matter). It is displayed a preview card for the link ( see attached pic and video), but in your video it is skiping the preview card for the link and then opens in a new tab in the mobile browser.

I want to confirm , that according to the story description, that it is either of both methods ? correct ?

T274868_test.mp41 MBDownload

Screen Shot 2022-08-03 at 9.45.58 PM.png (853×1 px, 87 KB)

In T274868#8130146, @EChukwukere-WMF wrote:

I want to confirm , that according to the story description, that it is either of both methods ? correct ?

Both cases are different. Links inside the editor show the link card at the bottom to preview or edit them. However, this ticket is focused on those links at the grey panel above the editor. This panel is intended to show the original sentence which can also include links.

In T274868#8124739, @ngkountas wrote:

As demonstrated by the following screencast this issue seems to be currently fixed. The test case is exact the same that Emeka used in the previous screencast. Another issue appears, as the link redirects to an invalid URL but we can create a separate task for this one. Moving this one to "Needs QA" so that it can be verified.

I created a separate ticket for the issue described: T314558: Links in the original panel lead to the wrong url
Thanks for the clear description and illustrative video!

@Pginer-WMF thanks for that clarification. It does makes sense. I have attached two screens here from chrome and safari

Screen Shot 2022-08-08 at 10.00.53 PM.png (769×472 px, 161 KB)

Screen Shot 2022-08-08 at 10.16.28 PM.png (793×476 px, 104 KB)

moving this to done

EChukwukere-WMF moved this task from Needs QA to Done on the Language-Team (Language-2022-July-September) board.Aug 9 2022, 3:19 AM

Pginer-WMF closed this task as Resolved.Aug 31 2022, 8:45 AM

	F35412183: Screen Shot 2022-08-08 at 10.16.28 PM.png
	Aug 9 2022, 3:19 AM

	F35412184: Screen Shot 2022-08-08 at 10.00.53 PM.png
	Aug 9 2022, 3:19 AM

	F35393383: Screen Shot 2022-08-03 at 9.45.58 PM.png
	Aug 4 2022, 2:55 AM

	F35382848: Screen Recording 2022-08-02 at 6.35.12 PM.webm
	Aug 2 2022, 3:39 PM

	F35285818: clicking_link_navigates-away.mp4
	Jun 29 2022, 5:34 AM

	F34107174: Screenshot 2021-02-16 at 11.36.36 2.png
	Feb 16 2021, 10:47 AM

Clicking a link in the original panel leaves the editorClosed, ResolvedPublicActions

Description

Details

Related ObjectsSearch...

Event Timeline

Clicking a link in the original panel leaves the editor
Closed, ResolvedPublic
Actions

Related Objects
Search...