Page MenuHomePhabricator

Mark "Personal data" heading for translation
Closed, ResolvedPublic


The heading string for "Personal data" on user profiles is not tagged for translation, so it always shows in English despite the language selected.

The string is located at TWLight/users/templates/users/editor_detail_data.html#L248 and should be updated from <h3>Personal data</h3> to <h3>{% trans "Personal data" %}</h3>. A translator comment should be placed on the line immediately above this, like so:

# Translators: This is a heading for a section of the user profile which contains personal data about the user, such as their real name.
<h3>{% trans "Personal data" %}</h3>

Good first task

This task has been placed in the good first task category. This means it has been scoped and written in a way that makes it simpler for folks who haven’t contributed to the tool’s development or open source software in the past.

If that’s you, welcome! Please feel free to ask questions here about this specific task or the codebase more generally. We’ll be more than happy to help you and clarify the steps needed to complete the task, whether that’s setting up the repository, implementing the necessary changes, or pushing your changes to Github.

If you have experience contributing to this project or similar ones, please consider leaving this one for someone new, and taking a look at the Open Tasks column of the workboard for another task. Also feel free to help out if you see unanswered questions here!

How to contribute

Assign yourself to this task: Click the ‘Add Action’ dropdown menu below and then select Assign / Claim. The box should fill your username in automatically, then click Submit!

The Library Card platform repository can be found at WikipediaLibrary/TWLight. Please see the Getting Started and Local Setup guides to get up and running with a local development environment.

To submit your changes, you should fork the repository and create a new branch. After pushing your changes to your Github branch, you can open a pull request. Please link your pull request in a comment here when it has been submitted, and include the Phabricator task number in the pull request. Experienced contributors to the project will review your code and either provide feedback or merge it in!

Event Timeline

Samwalton9 renamed this task from The "Personal data" heading in Wikipedia Library profile is not translatable to Mark "Personal data" heading for translation.Feb 18 2021, 2:12 PM
Samwalton9 added a project: good first task.
Samwalton9 updated the task description. (Show Details)