Page MenuHomePhabricator
Create Task
Maniphest T274887

Add a title attribute to the settings cogwheel
Closed, ResolvedPublic
Actions

Assigned To
ovasileva
Authored By
WMDE-Fisch
Feb 16 2021, 2:41 PM
Project Tags
Referenced Files
F34257081: Screen Recording 2021-04-05 at 11.44.13 AM.mov.gif
Apr 5 2021, 6:47 PM
F34192009: Screen Shot 2021-03-26 at 9.53.42 AM.png
Mar 26 2021, 4:01 PM
Subscribers
Aklapper
cjming
Edtadros
Lena_WMDE
• nray
ovasileva
Volker_E
WMDE-Fisch

Description

Currently the cogwheel used in the previews to get to the settings is missing a meaningful title. Would also be helpful for further accessibility support with screen readers.

Screen Shot 2021-03-26 at 9.53.42 AM.png (2,880×704 px, 558 KB)

Acceptance Criteria

  • A title attribute is added to .mwe-popups-settings-icon with an i18n message (copy: "Change page preview settings")

Developer Notes

This change will be in the Popups extension. Popups appear when you hover over article links (e.g. see https://en.wikipedia.org/wiki/Barack_Obama)

One of its steps will require adding a message to en.json in i18n/en.json and a description of that message in i18n/qqq.json. https://gerrit.wikimedia.org/r/c/mediawiki/extensions/Popups/+/495927 might be a helpful reference to use as it was a change involving i18n messages

QA Steps

  • Visit https://en.wikipedia.beta.wmflabs.org/wiki/Dog
  • Hover over the "domestic" link in the first sentence of the article
  • Wait for popup to appear
  • Hover over the Cog icon/link
  • Verify a tooltip that says "Change page preview settings" appears

QA Results - Beta

ACStatusDetails
1✅T274887#6973268

QA Results - Prod

ACStatusDetails
1✅T274887#6994121

Details

Related Changes in Gerrit:
SubjectAuthorRepoBranchLines +/-
Add title attribute to settings gear iconClare Mingmediawiki/extensions/Popupsmaster+21 -8
Customize query in gerrit

Event Timeline

WMDE-Fisch created this task.Feb 16 2021, 2:41 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptFeb 16 2021, 2:41 PM
Jdlrobson added a project: Web-Team-Backlog-Archived.Feb 16 2021, 3:48 PM
Jdlrobson added a subscriber: Volker_E.
Jdlrobson moved this task from Incoming to Triaged but Future on the Web-Team-Backlog-Archived board.Feb 16 2021, 7:35 PM
ovasileva triaged this task as Medium priority.Feb 22 2021, 1:42 PM
• nray added subscribers: ovasileva, • nray.Mar 23 2021, 10:57 PM

@Volker_E @ovasileva Any preference on what the title attribute should say? I'm thinking this might be a good task for Clare or Bernard

ovasileva added a subscriber: Lena_WMDE.Mar 24 2021, 9:34 AM

I think "Change preview settings" should do. Could also be more direct and say "Turn off previews" but I'm leaning towards the former. @Lena_WMDE - does this sound okay to you?

• nray updated the task description. (Show Details)Mar 26 2021, 4:01 PM
• nray updated the task description. (Show Details)Mar 26 2021, 6:11 PM
• nray updated the task description. (Show Details)Mar 26 2021, 6:14 PM
• nray updated the task description. (Show Details)
• nray updated the task description. (Show Details)Mar 26 2021, 6:22 PM
• nray updated the task description. (Show Details)Mar 26 2021, 6:28 PM
cjming claimed this task.Mar 26 2021, 6:34 PM
cjming moved this task from Triaged but Future to Kanbanana-FY-2020-21 on the Web-Team-Backlog-Archived board.Mar 26 2021, 6:41 PM
cjming edited projects, added: Web-Team-Backlog-Archived (Kanbanana-FY-2020-21); removed: Web-Team-Backlog-Archived.
cjming moved this task from Needs Analysis to Doing on the Web-Team-Backlog-Archived (Kanbanana-FY-2020-21) board.
ovasileva added a comment.Mar 29 2021, 8:26 AM

Checked with @Lena_WMDE - seems that the page previews and reference previews settings will be separated after all. In this case, let's go for: "Change page preview settings"

ovasileva updated the task description. (Show Details)Mar 29 2021, 8:26 AM
• nray added a comment.Mar 29 2021, 3:18 PM

Thank you for the update @ovasileva!

gerritbot added a comment.Mar 31 2021, 2:37 AM

Change 675938 had a related patch set uploaded (by Clare Ming; author: Clare Ming):

[mediawiki/extensions/Popups@master] Add Title::attribute to settings gear icon

https://gerrit.wikimedia.org/r/675938

gerritbot added a project: Patch-For-Review.Mar 31 2021, 2:37 AM
cjming moved this task from Doing to Code Review on the Web-Team-Backlog-Archived (Kanbanana-FY-2020-21) board.Mar 31 2021, 9:33 PM
• nray reassigned this task from cjming to Edtadros.Apr 2 2021, 7:52 PM
• nray reassigned this task from Edtadros to cjming.
• nray moved this task from Code Review to QA on the Web-Team-Backlog-Archived (Kanbanana-FY-2020-21) board.
• nray added a subscriber: cjming.
• nray added a subscriber: Edtadros.
gerritbot added a comment.Apr 2 2021, 7:57 PM

Change 675938 merged by jenkins-bot:

[mediawiki/extensions/Popups@master] Add title attribute to settings gear icon

https://gerrit.wikimedia.org/r/675938

ReleaseTaggerBot added a project: MW-1.36-notes (1.36.0-wmf.38; 2021-04-06).Apr 2 2021, 8:00 PM
• nray updated the task description. (Show Details)Apr 2 2021, 8:01 PM
• nray updated the task description. (Show Details)
Maintenance_bot removed a project: Patch-For-Review.Apr 2 2021, 8:10 PM
• nray reassigned this task from cjming to Edtadros.Apr 2 2021, 8:19 PM
Edtadros moved this task from QA to QA in Prod on the Web-Team-Backlog-Archived (Kanbanana-FY-2020-21) board.Apr 5 2021, 6:47 PM

Test Result - Beta

Status: ✅ PASS
Environment: beta
OS: macOS Big Sur
Browser: Chrome
Device: MBP
Emulated Device: NA

Test Artifact(s):

QA Steps

Visit https://en.wikipedia.beta.wmflabs.org/wiki/Dog
Hover over the "domestic" link in the first sentence of the article
Wait for the popup to appear
Hover over the Cog icon/link
AC1: Verify a tooltip that says "Change page preview settings" appears

Screen Recording 2021-04-05 at 11.44.13 AM.mov.gif (1,974×1,308 px, 1 MB)

Edtadros updated the task description. (Show Details)Apr 5 2021, 6:48 PM
Edtadros updated the task description. (Show Details)
Edtadros reassigned this task from Edtadros to ovasileva.Apr 13 2021, 1:00 PM
Edtadros moved this task from QA in Prod to Ready for Signoff on the Web-Team-Backlog-Archived (Kanbanana-FY-2020-21) board.

Test Result - Prod

Status: ✅ PASS
Environment: beta
OS: macOS Big Sur
Browser: Chrome
Device: MBP
Emulated Device: NA

Test Artifact(s):

QA Steps

Visit https://en.wikipedia.beta.wmflabs.org/wiki/Dog
Hover over the "domestic" link in the first sentence of the article
Wait for the popup to appear
Hover over the Cog icon/link
AC1: Verify a tooltip that says "Change page preview settings" appears

Screen Recording 2021-04-05 at 11.44.13 AM.mov.gif (1,974×1,308 px, 1 MB)

Edtadros updated the task description. (Show Details)Apr 13 2021, 1:00 PM
Edtadros updated the task description. (Show Details)
ovasileva closed this task as Resolved.Apr 15 2021, 2:24 PM

Looks good!

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits