Page MenuHomePhabricator

Add a title attribute to the settings cogwheel
Closed, ResolvedPublic

Description

Currently the cogwheel used in the previews to get to the settings is missing a meaningful title. Would also be helpful for further accessibility support with screen readers.

Screen Shot 2021-03-26 at 9.53.42 AM.png (704×2 px, 558 KB)

Acceptance Criteria

  • A title attribute is added to .mwe-popups-settings-icon with an i18n message (copy: "Change page preview settings")

Developer Notes

This change will be in the Popups extension. Popups appear when you hover over article links (e.g. see https://en.wikipedia.org/wiki/Barack_Obama)

One of its steps will require adding a message to en.json in i18n/en.json and a description of that message in i18n/qqq.json. https://gerrit.wikimedia.org/r/c/mediawiki/extensions/Popups/+/495927 might be a helpful reference to use as it was a change involving i18n messages

QA Steps

  • Visit https://en.wikipedia.beta.wmflabs.org/wiki/Dog
  • Hover over the "domestic" link in the first sentence of the article
  • Wait for popup to appear
  • Hover over the Cog icon/link
  • Verify a tooltip that says "Change page preview settings" appears

QA Results - Beta

ACStatusDetails
1T274887#6973268

QA Results - Prod

ACStatusDetails
1T274887#6994121

Event Timeline

ovasileva triaged this task as Medium priority.Feb 22 2021, 1:42 PM

@Volker_E @ovasileva Any preference on what the title attribute should say? I'm thinking this might be a good task for Clare or Bernard

I think "Change preview settings" should do. Could also be more direct and say "Turn off previews" but I'm leaning towards the former. @Lena_WMDE - does this sound okay to you?

nray updated the task description. (Show Details)

Checked with @Lena_WMDE - seems that the page previews and reference previews settings will be separated after all. In this case, let's go for: "Change page preview settings"

Change 675938 had a related patch set uploaded (by Clare Ming; author: Clare Ming):

[mediawiki/extensions/Popups@master] Add Title::attribute to settings gear icon

https://gerrit.wikimedia.org/r/675938

nray reassigned this task from Edtadros to cjming.
nray moved this task from Code Review to QA on the Readers-Web-Backlog (Kanbanana-FY-2020-21) board.
nray added a subscriber: cjming.
nray added a subscriber: Edtadros.

Change 675938 merged by jenkins-bot:

[mediawiki/extensions/Popups@master] Add title attribute to settings gear icon

https://gerrit.wikimedia.org/r/675938

nray updated the task description. (Show Details)

Test Result - Beta

Status: ✅ PASS
Environment: beta
OS: macOS Big Sur
Browser: Chrome
Device: MBP
Emulated Device: NA

Test Artifact(s):

QA Steps

Visit https://en.wikipedia.beta.wmflabs.org/wiki/Dog
Hover over the "domestic" link in the first sentence of the article
Wait for the popup to appear
Hover over the Cog icon/link
AC1: Verify a tooltip that says "Change page preview settings" appears

Screen Recording 2021-04-05 at 11.44.13 AM.mov.gif (1×1 px, 1 MB)

Edtadros updated the task description. (Show Details)

Test Result - Prod

Status: ✅ PASS
Environment: beta
OS: macOS Big Sur
Browser: Chrome
Device: MBP
Emulated Device: NA

Test Artifact(s):

QA Steps

Visit https://en.wikipedia.beta.wmflabs.org/wiki/Dog
Hover over the "domestic" link in the first sentence of the article
Wait for the popup to appear
Hover over the Cog icon/link
AC1: Verify a tooltip that says "Change page preview settings" appears

Screen Recording 2021-04-05 at 11.44.13 AM.mov.gif (1×1 px, 1 MB)

Edtadros updated the task description. (Show Details)