Page MenuHomePhabricator

Make RemoveDeletedItemsFromTermStore.php maintenance script remove wbt_item_terms rows
Closed, ResolvedPublic

Description

As outlined in the comments of T270249, the maintenance script to remove deleted items from the term store (which was introduced in T270247) is not useful in its current form. It should be changed so it receives a set of item IDs (not term IDs), checks that they really don’t exist, collects their term IDs, deletes the wbt_item_terms rows, and then cleans those term IDs (like the current version of the script does). See the second half of T270249#6830469 for a rough sketch.

Event Timeline

Change 664589 had a related patch set uploaded (by Lucas Werkmeister (WMDE); owner: Lucas Werkmeister (WMDE)):
[mediawiki/extensions/Wikibase@master] Add existsBatch() method to EntityExistenceChecker

https://gerrit.wikimedia.org/r/664589

Change 664590 had a related patch set uploaded (by Lucas Werkmeister (WMDE); owner: Lucas Werkmeister (WMDE)):
[mediawiki/extensions/Wikibase@master] Make RemoveDeletedItemsFromTermStore work on item IDs

https://gerrit.wikimedia.org/r/664590

Change 664589 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] Add existsBatch() method to EntityExistenceChecker

https://gerrit.wikimedia.org/r/664589

Change 664590 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] Make RemoveDeletedItemsFromTermStore work on item IDs

https://gerrit.wikimedia.org/r/664590