Show wikitext warning for sequences disabled in Reply Tool's visual mode
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	• ppelberg
	Feb 16 2021, 6:24 PM

Description

This task is about making sure the Wikitext markup detected feedback message [i] is shown when someone types a "sequence" in the Reply Tool's visual mode that is not currently supported.

Behavior

Open the Reply Tool in visual mode
Type one of the sequences below (e.g. ==)

Current

The typed sequence appears within the Reply Tool's text input area; nothing else happens

Desired

✅The typed sequence appears within the Reply Tool's text input area AND the Wikitext markup detect warning appears [i]

Sequences

== (only at the start of a line)
{{
{|
: (only at the start of a line)

Done

"Desired" behavior is implemented
User:JohnFromPinckney is notified of change here.

Screen Shot 2021-02-16 at 10.25.51 AM.png (270×576 px, 41 KB)

Details

	Subject	Repo	Branch	Lines +/-
	Show wikitext warnings for sequences not in reply tools	mediawiki/extensions/DiscussionTools	master	+21 -0

Customize query in gerrit

Related Objects

Mentioned In: T257709: Revise how Reply tool behaves when ":" is typed in its visual mode

Event Timeline

• ppelberg created this task.Feb 16 2021, 6:24 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptFeb 16 2021, 6:24 PM

• ppelberg updated the task description. (Show Details)Feb 16 2021, 6:28 PM

• ppelberg moved this task from Incoming to Ready to Be Worked On on the Editing-team (Kanban Board) board.

• ppelberg updated the task description. (Show Details)Feb 16 2021, 6:30 PM

• ppelberg added a subscriber: • Whatamidoing-WMF.

Change 664640 had a related patch set uploaded (by Esanders; owner: Esanders):
[mediawiki/extensions/DiscussionTools@master] Show wikitext warnings for sequences not in reply tools

https://gerrit.wikimedia.org/r/664640

gerritbot added a project: Patch-For-Review.Feb 16 2021, 7:59 PM

Esanders claimed this task.Feb 16 2021, 7:59 PM

Esanders updated the task description. (Show Details)

Esanders moved this task from Ready to Be Worked On to Code Review on the Editing-team (Kanban Board) board.

• Whatamidoing-WMF updated the task description. (Show Details)Feb 16 2021, 9:25 PM

Test wiki created on Patch Demo by ESanders (WMF) using patch(es) linked to this task:

https://patchdemo.wmflabs.org/wikis/f3bca2041b0c8161621654793907583c/w/

Change 664640 merged by jenkins-bot:
[mediawiki/extensions/DiscussionTools@master] Show wikitext warnings for sequences not in reply tools

https://gerrit.wikimedia.org/r/664640

matmarex moved this task from Code Review to Ready for Sign Off on the Editing-team (Kanban Board) board.Feb 19 2021, 12:30 AM

matmarex added a project: Skipped QA.

ReleaseTaggerBot added a project: MW-1.36-notes (1.36.0-wmf.32; 2021-02-23).Feb 19 2021, 1:00 AM

Maintenance_bot removed a project: Patch-For-Review.Feb 19 2021, 1:10 AM

Test wiki on Patch Demo by ESanders (WMF) using patch(es) linked to this task was deleted:

~~https://patchdemo.wmflabs.org/wikis/f3bca2041b0c8161621654793907583c/w/~~

@Whatamidoing-WMF, I see you added the "(only at the start of a line)" condition to the ==, : and {| sequences.

To me, this condition seems intuitively valuable for the == and : sequences. The value this condition has for the {| is not as clear to me...can you share what's leading you to think it's imprtant to suppress the Wikitext markup detected warning when {| is typed anywhere besides the start of a line?

Is it because table, "...marks must start on a new line, except the double marks (|| and !!) for optionally adding consecutive cells to a single line.` [i]

i. https://en.wikipedia.org/wiki/Help:Table#Basic_table_markup_summary

• ppelberg added a subscriber: • iamjessklein.Feb 24 2021, 5:16 PM

Is it because table, "...marks must start on a new line, except the double marks (|| and !!) for optionally adding consecutive cells to a single line.` [i]

Yes, however:

{| is a sequence in VE that can be triggered from anywhere, e.g. I can type Hello {| and it will insert a table on a new line after your text.

Additionally, {| is quite a rare sequence (more so than == or :), so it's less problematic to warn when we see it anywhere.

As discussed in code review:

Esanders updated the task description. (Show Details)Feb 24 2021, 5:18 PM

JohnFromPinckney subscribed.Feb 26 2021, 1:37 AM

matmarex mentioned this in T257709: Revise how Reply tool behaves when ":" is typed in its visual mode.Feb 26 2021, 6:12 PM

• ppelberg moved this task from Blocked / Needs More Work to Ready for Sign Off on the Editing-team (Kanban Board) board.Mar 3 2021, 5:22 PM

• ppelberg closed this task as Resolved.Mar 6 2021, 2:04 AM

	F34107966: Screen Shot 2021-02-16 at 10.25.51 AM.png
	Feb 16 2021, 6:28 PM

	F34121402: image.png
	Feb 24 2021, 6:55 PM

	F34121400: image.png
	Feb 24 2021, 6:55 PM

Show wikitext warning for sequences disabled in Reply Tool's visual modeClosed, ResolvedPublicActions