1.36.0-wmf.33 deployment blockers
Closed, ResolvedPublicRelease
Actions

Assigned To

Authored By

	thcipriani
	Feb 16 2021, 7:58 PM

Details

Backup Train Conductor: jeena
Release Version: 1.36.0-wmf.33
Release Date: Mar 1 2021, 12:00 AM

Train Status

Train is at Group0

2021 week 09 1.36-wmf.33 Changes wmf/1.36.0-wmf.33

This MediaWiki Train Deployment is scheduled for the week of Monday, March 1st:

Monday March 1st	Tuesday, March 2nd	Wednesday, March 3rd	Thursday, March 4th	Friday
Backports only.	Branch `wmf.33` and deploy to Group 0 Wikis.	Deploy `wmf.33` to Group 1 Wikis.	Deploy `wmf.33` to all Wikis.	No deployments on fridays

See https://wikitech.wikimedia.org/wiki/Deployments for full schedule.

How this works

Any serious bugs affecting wmf.33 should be added as subtasks beneath this one.
- Use this form to create one.
Any open subtask(s) block the train from moving forward. This means no further deployments until the blockers are resolved.
If something is serious enough to warrant a rollback then you should bring it to the attention of deployers on the #wikimedia-operations IRC channel.
If you have a risky change in this week's train add a comment to this task using the Risky patch template
For more info about deployment blockers, see Holding the train.

Other Deployments

Previous: 1.36.0-wmf.32

Next: 1.36.0-wmf.34

	Subject	Repo	Branch	Lines +/-
	Branch commit for wmf/1.36.0-wmf.33	mediawiki/core	wmf/1.36.0-wmf.33	+976 -3

Customize query in gerrit

Related Objects

Mentioned In: T277507: Core subproject commits aren't updated for backports if wmf branch commit has not yet been merged.
T276720: User::loadFromSession called before the end of Setup.php
Mentioned Here: T276476: Creating a page with {{safesubst:self}} throws RevisionAccessException: No such slot: main
T276461: LogicException: Process cache for 'en-screenshot' should be set by now (from MessageCache)
T276353: PHP Notice: Undefined index: timestamp
T276307: Expectation (masterConns <= 0) not met (via GrowthExperimentsLinkRecommendationStore constructor)
T276316: Argument 1 passed to MediaWiki\User\UserNameUtils::getCanonical() must be of the type string, null given, called in /srv/mediawiki/php-1.36.0-wmf.33/extensions/CentralAuth/includes/CentralAuthGroupMembershipProxy.php on line 48
rMW800e1f8cea16: Merge "Don't worry about something before when armoring french spaces"

Event Timeline

thcipriani created this task.Feb 16 2021, 7:58 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptFeb 16 2021, 7:58 PM

thcipriani assigned this task to • LarsWirzenius.Feb 16 2021, 7:59 PM

thcipriani triaged this task as Medium priority.

thcipriani updated Other Assignee, added: jeena.

thcipriani added a project: Release-Engineering-Team-TODO (2021-01-01 to 2021-03-31 (Q3)).

thcipriani moved this task from INBOX to Deployment on the Release-Engineering-Team-TODO (2021-01-01 to 2021-03-31 (Q3)) board.

Change 667743 had a related patch set uploaded (by DannyS712; owner: trainbranchbot):
[mediawiki/core@wmf/1.36.0-wmf.33] Branch commit for wmf/1.36.0-wmf.33

https://gerrit.wikimedia.org/r/667743

gerritbot added a project: Patch-For-Review.Mar 2 2021, 2:38 AM

Change 667743 merged by jenkins-bot:
[mediawiki/core@wmf/1.36.0-wmf.33] Branch commit for wmf/1.36.0-wmf.33

https://gerrit.wikimedia.org/r/667743

Mentioned in SAL (#wikimedia-operations) [2021-03-02T07:59:26Z] <liw> 1.36.0-wmf.33 was branched at 800e1f8cea169fc9c6e72ac1dc197591a06701bd for T274937

Train is at group0.

thcipriani edited Train Status. (Show Details)Mar 2 2021, 6:50 PM

Reported T276316: Argument 1 passed to MediaWiki\User\UserNameUtils::getCanonical() must be of the type string, null given, called in /srv/mediawiki/php-1.36.0-wmf.33/extensions/CentralAuth/includes/CentralAuthGroupMembershipProxy.php on line 48, but not as a blocker, since it's only happened once so far.

Not sure if T276307: Expectation (masterConns <= 0) not met (via GrowthExperimentsLinkRecommendationStore constructor) should be a blocker considering the volume of logspam it's generating, but in any case backporting a fix to wmf.33 now.

Eh, editing wrong task I am.

• LarsWirzenius added a subtask: T276316: Argument 1 passed to MediaWiki\User\UserNameUtils::getCanonical() must be of the type string, null given, called in /srv/mediawiki/php-1.36.0-wmf.33/extensions/CentralAuth/includes/CentralAuthGroupMembershipProxy.php on line 48.Mar 3 2021, 12:12 PM

RhinosF1 subscribed.Mar 3 2021, 12:13 PM

taavi subscribed.Mar 3 2021, 12:14 PM

Train is on group1 now.

Reported T276353: PHP Notice: Undefined index: timestamp, as a blocker.

• LarsWirzenius added a subtask: T276353: PHP Notice: Undefined index: timestamp.Mar 3 2021, 4:46 PM

T276316: Argument 1 passed to MediaWiki\User\UserNameUtils::getCanonical() must be of the type string, null given, called in /srv/mediawiki/php-1.36.0-wmf.33/extensions/CentralAuth/includes/CentralAuthGroupMembershipProxy.php on line 48 has a workaround in this train, but bug is kept open so it's not forgotten. It's a blocker for next week's train. However, I'm dropping it as a blocker for this train.

T276353: PHP Notice: Undefined index: timestamp has a workaround/fix in this train, but bug is open to allow monitoring better. I'm dropping it as a blocker, though.

• LarsWirzenius removed a subtask: T276353: PHP Notice: Undefined index: timestamp.Mar 4 2021, 1:58 PM

All wikis on 1.36.0-wmf.33 now. Watching logs for problems.

Reported T276461: LogicException: Process cache for 'en-screenshot' should be set by now (from MessageCache) but it's not happening enough to be a blocker.