| Gopavasanth | |
| Feb 17 2021, 12:50 PM |
| F34111570: before.png | |
| Feb 18 2021, 7:54 AM |
| F34111579: after.png | |
| Feb 18 2021, 7:54 AM |
@Khr2003 Feedback on T270832#6828304
3- There is an empty space at the bottom. I can fix this by making the main div full height. This will be universal not just part of dark theme. Should I add in this change (with a separate commit) or create a separate task for it?
| Subject | Repo | Branch | Lines +/- | |
|---|---|---|---|---|
| Fixed main section height | labs/tools/VideoCutTool | master | +7 -1 |
Change 664825 had a related patch set uploaded (by Khr2003; owner: Khr2003):
[labs/tools/VideoCutTool@master] Fixed main section height
@Gopavasanth I was not able to post photo on Gerrit. That's why I am posting it here.
There is an empty space at the very bottom of the page as seen in this photo:
I modified the main section so that the main section covers the entire page and the footer always at the very bottom.
This was done by applying display:flex on the main section as well as other rules as seen in the commit).
Aah @Khr2003, I was wondering in which browser you are facing that issue? I tested in Chrome and Firefox the behavior is not like the above.
@Gopavasanth I am getting this issue in both Chrome and Firefox. I think I can see because of my screen dimensions. The viewport height is 977px in Chrome and 1006px in Firefox.
Change 664825 merged by jenkins-bot:
[labs/tools/VideoCutTool@master] Fixed main section height
Thanks!!! @Khr2003 :-)
\o/ It's live with a better look in many devices now https://videocuttool.wmflabs.org/