Page MenuHomePhabricator
Create Task
Maniphest T275030

Avoid using User ::isUsableName, ::isCreatableName, ::getCanonicalName
Closed, ResolvedPublic
Actions

Assigned To
Vlad.shapik
Authored By
Vlad.shapik
Feb 17 2021, 2:13 PM
Tags
Referenced Files
None
Subscribers
Aklapper
Nikerabbit
• Pchelolo
Peter.ovchyn
Vlad.shapik

Description

User::isUsableName, User::isCreatableName, User::getCanonicalName were soft deprecated and now need to be hard deprecated. So we need to remove using from the extensions:

  • CentralAuth
  • FlaggedRevs
  • OpenStackManager
  • AbuseFilter
  • ConfirmEdit
  • Translate
  • Echo
  • LdapAuthentication
  • BlueSpicePrivacy
  • RegexBlock
  • BlueSpiceFoundation
  • ApprovedRevs
  • Auth_remoteuser
  • ImapAuthorization

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
Avoid using User::getCanonicalNamemediawiki/extensions/ApprovedRevsmaster+7 -1
Implement injecting of dependencies to an AuthenticationProvidermediawiki/coremaster+479 -210
Hard Deprecate User ::getCanonicalName, ::isUsableName, ::isCreatableNamemediawiki/coremaster+97 -37
Create an initialization method in the SessionProvider classmediawiki/coremaster+340 -106
Hard Deprecate User ::getCanonicalName, ::isUsableName, ::isCreatableNamemediawiki/coremaster+311 -117
Hard Deprecate User ::getCanonicalName, ::isUsableName, ::isCreatableNamemediawiki/coremaster+308 -117
Hard Deprecate User ::getCanonicalName, ::isUsableName, ::isCreatableNamemediawiki/coremaster+308 -117
Avoid using User ::isCreatableName, ::isUsableNamemediawiki/extensions/BlueSpiceFoundationmaster+4 -3
Avoid using User::isUsableNamemediawiki/extensions/RegexBlockmaster+48 -4
Avoid using User::getCanonicalNamemediawiki/extensions/ImapAuthorizationmaster+16 -2
Avoid using User ::getCanonicalName, ::isUsableNamemediawiki/extensions/Auth_remoteusermaster+2 -2
Avoid using User ::newFromName, ::isCreatableNamemediawiki/extensions/BlueSpicePrivacymaster+4 -2
Avoid using User ::getCanonicalNamemediawiki/extensions/Echomaster+6 -4
Avoid using User ::getCanonicalNamemediawiki/extensions/Translatemaster+13 -1
Avoid using User ::isUsableName, ::isCreatableName, ::getCanonicalNamemediawiki/extensions/CentralAuthmaster+249 -74
Avoid using User ::getCanonicalNamemediawiki/extensions/LdapAuthenticationmaster+17 -7
Avoid using User ::getCanonicalNamemediawiki/extensions/ConfirmEditmaster+3 -1
Avoid using User ::isCreatableNamemediawiki/extensions/OpenStackManagermaster+2 -1
Avoid using User ::isUsableNamemediawiki/extensions/FlaggedRevsmaster+2 -1
Avoid using User ::getCanonicalNamemediawiki/extensions/AbuseFiltermaster+12 -2
Show related patches Customize query in gerrit

Related Objects
Search...

Event Timeline

Vlad.shapik created this task.Feb 17 2021, 2:13 PM
• Pchelolo moved this task from Unsorted pile to UserStore pile on the Platform Team Workboards (MW Expedition) board.Feb 17 2021, 2:44 PM
gerritbot added a comment.Feb 17 2021, 5:51 PM

Change 664877 had a related patch set uploaded (by Vlad.shapik; owner: Vlad.shapik):
[mediawiki/extensions/CentralAuth@master] Avoid using User ::isUsableName, ::isCreatableName, ::getCanonicalName

https://gerrit.wikimedia.org/r/664877

gerritbot added a project: Patch-For-Review.Feb 17 2021, 5:51 PM
gerritbot added a comment.Feb 20 2021, 2:48 PM

Change 665475 had a related patch set uploaded (by Vlad.shapik; owner: Vlad.shapik):
[mediawiki/extensions/FlaggedRevs@master] Avoid using User ::isUsableName

https://gerrit.wikimedia.org/r/665475

gerritbot added a comment.Feb 21 2021, 6:16 PM

Change 665655 had a related patch set uploaded (by Vlad.shapik; owner: Vlad.shapik):
[mediawiki/extensions/OpenStackManager@master] Avoid using User ::isCreatableName

https://gerrit.wikimedia.org/r/665655

gerritbot added a comment.Feb 21 2021, 8:49 PM

Change 665660 had a related patch set uploaded (by Vlad.shapik; owner: Vlad.shapik):
[mediawiki/extensions/AbuseFilter@master] Avoid using User ::getCanonicalName

https://gerrit.wikimedia.org/r/665660

gerritbot added a comment.Feb 21 2021, 9:37 PM

Change 665662 had a related patch set uploaded (by Vlad.shapik; owner: Vlad.shapik):
[mediawiki/extensions/ConfirmEdit@master] Avoid using User ::getCanonicalName

https://gerrit.wikimedia.org/r/665662

gerritbot added a comment.Feb 21 2021, 10:38 PM

Change 665760 had a related patch set uploaded (by Vlad.shapik; owner: Vlad.shapik):
[mediawiki/extensions/Translate@master] Avoid using User ::getCanonicalName

https://gerrit.wikimedia.org/r/665760

gerritbot added a comment.Feb 21 2021, 11:02 PM

Change 665801 had a related patch set uploaded (by Vlad.shapik; owner: Vlad.shapik):
[mediawiki/extensions/Echo@master] Avoid using User ::getCanonicalName

https://gerrit.wikimedia.org/r/665801

gerritbot added a comment.Feb 21 2021, 11:54 PM

Change 665803 had a related patch set uploaded (by Vlad.shapik; owner: Vlad.shapik):
[mediawiki/extensions/LdapAuthentication@master] Avoid using User ::getCanonicalName

https://gerrit.wikimedia.org/r/665803

gerritbot added a comment.Feb 22 2021, 4:56 PM

Change 665660 merged by jenkins-bot:
[mediawiki/extensions/AbuseFilter@master] Avoid using User ::getCanonicalName

https://gerrit.wikimedia.org/r/665660

ReleaseTaggerBot added a project: MW-1.36-notes (1.36.0-wmf.32; 2021-02-23).Feb 22 2021, 5:00 PM
gerritbot added a comment.Feb 22 2021, 11:11 PM

Change 665475 merged by jenkins-bot:
[mediawiki/extensions/FlaggedRevs@master] Avoid using User ::isUsableName

https://gerrit.wikimedia.org/r/665475

• Pchelolo moved this task from UserStore pile to Waiting for Review on the Platform Team Workboards (MW Expedition) board.Feb 23 2021, 5:59 PM
daniel triaged this task as Medium priority.Feb 23 2021, 6:43 PM
gerritbot added a comment.Feb 23 2021, 9:21 PM

Change 665655 merged by jenkins-bot:
[mediawiki/extensions/OpenStackManager@master] Avoid using User ::isCreatableName

https://gerrit.wikimedia.org/r/665655

gerritbot added a comment.Feb 23 2021, 9:41 PM

Change 665662 merged by jenkins-bot:
[mediawiki/extensions/ConfirmEdit@master] Avoid using User ::getCanonicalName

https://gerrit.wikimedia.org/r/665662

ReleaseTaggerBot edited projects, added MW-1.36-notes (1.36.0-wmf.33; 2021-03-02); removed MW-1.36-notes (1.36.0-wmf.32; 2021-02-23).Feb 23 2021, 11:00 PM
gerritbot added a comment.Feb 24 2021, 8:50 PM

Change 665803 merged by jenkins-bot:
[mediawiki/extensions/LdapAuthentication@master] Avoid using User ::getCanonicalName

https://gerrit.wikimedia.org/r/665803

gerritbot added a comment.Feb 24 2021, 9:13 PM

Change 664877 merged by jenkins-bot:
[mediawiki/extensions/CentralAuth@master] Avoid using User ::isUsableName, ::isCreatableName, ::getCanonicalName

https://gerrit.wikimedia.org/r/664877

gerritbot added a comment.Mar 1 2021, 6:30 AM

Change 665760 merged by jenkins-bot:
[mediawiki/extensions/Translate@master] Avoid using User ::getCanonicalName

https://gerrit.wikimedia.org/r/665760

gerritbot added a comment.Mar 1 2021, 8:16 PM

Change 665801 merged by jenkins-bot:
[mediawiki/extensions/Echo@master] Avoid using User ::getCanonicalName

https://gerrit.wikimedia.org/r/665801

taavi mentioned this in T276316: Argument 1 passed to MediaWiki\User\UserNameUtils::getCanonical() must be of the type string, null given, called in /srv/mediawiki/php-1.36.0-wmf.33/extensions/CentralAuth/includes/CentralAuthGroupMembershipProxy.php on line 48.Mar 3 2021, 12:00 PM
• Pchelolo added a comment.Mar 5 2021, 6:29 PM

Seems like it's ready to introduce a hard-deprecation patch.

• Pchelolo moved this task from Waiting for Review to Doing on the Platform Team Workboards (MW Expedition) board.Mar 5 2021, 6:30 PM
Vlad.shapik added a comment.EditedMar 5 2021, 6:36 PM
In T275030#6887276, @Pchelolo wrote:

Seems like it's ready to introduce a hard-deprecation patch.

Do you mean to introduce for the core with this group of methods?

• Pchelolo added a comment.Mar 5 2021, 6:36 PM

Yes. Seems like all usages in extensions were removed.

Vlad.shapik added a comment.Mar 5 2021, 6:40 PM
In T275030#6887306, @Pchelolo wrote:

Yes. Seems like all usages in extensions were removed.

Yes, I removed all usages of these methods in all deployed extensions. So, I will create hard-deprecation patch for the core under this ticket.

Vlad.shapik added projects: MediaWiki-extensions-CentralAuth, FlaggedRevs, MediaWiki-extensions-OpenStackManager, AbuseFilter, ConfirmEdit (CAPTCHA extension), translatewiki.net, Notifications (Echo), MediaWiki-extensions-LdapAuthentication, BlueSpice, RegexBlock, MediaWiki-extensions-Approved-Revs, MediaWiki-extensions-Auth_remoteuser, MediaWiki-extensions-Other.Mar 18 2021, 12:55 PM
Vlad.shapik updated the task description. (Show Details)
Restricted Application added a project: Growth-Team. · View Herald TranscriptMar 18 2021, 12:55 PM
gerritbot added a comment.Mar 18 2021, 1:55 PM

Change 673274 had a related patch set uploaded (by Vlad.shapik; owner: Vlad.shapik):
[mediawiki/extensions/BlueSpicePrivacy@master] Avoid using User ::newFromName, ::isCreatableName

https://gerrit.wikimedia.org/r/673274

gerritbot added a comment.Mar 18 2021, 2:16 PM

Change 673274 merged by jenkins-bot:
[mediawiki/extensions/BlueSpicePrivacy@master] Avoid using User ::newFromName, ::isCreatableName

https://gerrit.wikimedia.org/r/673274

Vlad.shapik mentioned this in rEBUC26a19f50449e: Avoid using User ::newFromName, ::isCreatableName.Mar 18 2021, 2:17 PM
gerritbot added a comment.Mar 18 2021, 3:48 PM

Change 673294 had a related patch set uploaded (by Vlad.shapik; owner: Vlad.shapik):
[mediawiki/extensions/RegexBlock@master] Avoid using User::isUsableName

https://gerrit.wikimedia.org/r/673294

Vlad.shapik updated the task description. (Show Details)Mar 18 2021, 3:55 PM
Nikerabbit edited projects, added MediaWiki-extensions-Translate; removed translatewiki.net.Mar 18 2021, 4:15 PM
Nikerabbit subscribed.

I suppose you meant Translate instead of translatewiki.

Nikerabbit moved this task from Backlog to maintenance and operational issues on the MediaWiki-extensions-Translate board.Mar 18 2021, 4:15 PM
Vlad.shapik added a comment.Mar 18 2021, 4:34 PM

Yes, sorry!

gerritbot added a comment.Mar 18 2021, 5:03 PM

Change 673305 had a related patch set uploaded (by Vlad.shapik; owner: Vlad.shapik):
[mediawiki/extensions/BlueSpiceFoundation@master] Avoid using User ::isCreatableName, ::isUsableName

https://gerrit.wikimedia.org/r/673305

gerritbot added a comment.Mar 19 2021, 9:14 AM

Change 673444 had a related patch set uploaded (by Vlad.shapik; owner: Vlad.shapik):
[mediawiki/extensions/ApprovedRevs@master] Avoid using User::getCanonicalName

https://gerrit.wikimedia.org/r/673444

gerritbot added a comment.Mar 19 2021, 9:36 AM

Change 673445 had a related patch set uploaded (by Vlad.shapik; owner: Vlad.shapik):
[mediawiki/extensions/Auth_remoteuser@master] Avoid using User ::getCanonicalName, ::isUsableName

https://gerrit.wikimedia.org/r/673445

gerritbot added a comment.Mar 19 2021, 10:19 AM

Change 673449 had a related patch set uploaded (by Vlad.shapik; owner: Vlad.shapik):
[mediawiki/extensions/ImapAuthorization@master] Avoid using User::getCanonicalName

https://gerrit.wikimedia.org/r/673449

Vlad.shapik updated the task description. (Show Details)Mar 19 2021, 10:22 AM
gerritbot added a comment.Mar 19 2021, 11:44 AM

Change 673445 merged by jenkins-bot:
[mediawiki/extensions/Auth_remoteuser@master] Avoid using User ::getCanonicalName, ::isUsableName

https://gerrit.wikimedia.org/r/673445

gerritbot added a comment.Mar 19 2021, 9:14 PM

Change 673449 merged by Alphanoob1337:
[mediawiki/extensions/ImapAuthorization@master] Avoid using User::getCanonicalName

https://gerrit.wikimedia.org/r/673449

Vlad.shapik mentioned this in rEIAUcde5c56bfbce: Avoid using User::getCanonicalName.Mar 19 2021, 11:33 PM
gerritbot added a comment.Mar 22 2021, 3:56 PM

Change 673294 merged by Jack Phoenix:
[mediawiki/extensions/RegexBlock@master] Avoid using User::isUsableName

https://gerrit.wikimedia.org/r/673294

Vlad.shapik mentioned this in rERXB182bd435d966: Avoid using User::isUsableName.Mar 22 2021, 3:58 PM
gerritbot added a comment.Mar 24 2021, 4:35 PM

Change 673305 merged by jenkins-bot:
[mediawiki/extensions/BlueSpiceFoundation@master] Avoid using User ::isCreatableName, ::isUsableName

https://gerrit.wikimedia.org/r/673305

gerritbot added a comment.Mar 29 2021, 7:18 PM

Change 675572 had a related patch set uploaded (by Peter.ovchyn; author: Peter.ovchyn):
[mediawiki/core@master] Hard Deprecate User ::getCanonicalName, ::isUsableName, ::isCreatableName

https://gerrit.wikimedia.org/r/675572

gerritbot added a comment.Mar 30 2021, 3:31 PM

Change 675825 had a related patch set uploaded (by Peter.ovchyn; author: Peter.ovchyn):
[mediawiki/core@master] Hard Deprecate User ::getCanonicalName, ::isUsableName, ::isCreatableName

https://gerrit.wikimedia.org/r/675825

gerritbot added a comment.Mar 30 2021, 3:35 PM

Change 675826 had a related patch set uploaded (by Peter.ovchyn; author: Peter.ovchyn):
[mediawiki/core@master] Hard Deprecate User ::getCanonicalName, ::isUsableName, ::isCreatableName

https://gerrit.wikimedia.org/r/675826

gerritbot added a comment.Mar 30 2021, 3:38 PM

Change 675830 had a related patch set uploaded (by Peter.ovchyn; author: Peter.ovchyn):
[mediawiki/core@master] Hard Deprecate User ::getCanonicalName, ::isUsableName, ::isCreatableName

https://gerrit.wikimedia.org/r/675830

gerritbot added a comment.Mar 30 2021, 3:39 PM

Change 675830 abandoned by Peter.ovchyn:
[mediawiki/core@master] Hard Deprecate User ::getCanonicalName, ::isUsableName, ::isCreatableName

Reason:
Wrong patch

https://gerrit.wikimedia.org/r/675830

gerritbot added a comment.Mar 30 2021, 3:39 PM

Change 675826 abandoned by Peter.ovchyn:
[mediawiki/core@master] Hard Deprecate User ::getCanonicalName, ::isUsableName, ::isCreatableName

Reason:
Wrong patch

https://gerrit.wikimedia.org/r/675826

gerritbot added a comment.Mar 30 2021, 3:39 PM

Change 675825 abandoned by Peter.ovchyn:
[mediawiki/core@master] Hard Deprecate User ::getCanonicalName, ::isUsableName, ::isCreatableName

Reason:
Wrong patch

https://gerrit.wikimedia.org/r/675825

Vlad.shapik moved this task from Doing to Waiting for Review on the Platform Team Workboards (MW Expedition) board.Apr 6 2021, 12:05 PM
MBinder_WMF added a project: Growth-Team-Filtering.Apr 15 2021, 6:48 PM
gerritbot added a comment.Apr 16 2021, 1:17 PM

Change 680327 had a related patch set uploaded (by Vlad.shapik; author: Vlad.shapik):

[mediawiki/core@master] Implement injecting of deprendencies to a provider

https://gerrit.wikimedia.org/r/680327

gerritbot added a comment.Apr 26 2021, 4:04 PM

Change 680327 merged by jenkins-bot:

[mediawiki/core@master] Implement injecting of dependencies to an AuthenticationProvider

https://gerrit.wikimedia.org/r/680327

gerritbot added a comment.Apr 29 2021, 8:48 PM

Change 683726 had a related patch set uploaded (by Vlad.shapik; author: Vlad.shapik):

[mediawiki/core@master] Implement injecting of dependencies to a SessionProvider

https://gerrit.wikimedia.org/r/683726

gerritbot added a comment.May 4 2021, 3:57 PM

Change 683726 merged by jenkins-bot:

[mediawiki/core@master] Create an initialization method in the SessionProvider class

https://gerrit.wikimedia.org/r/683726

gerritbot added a comment.May 4 2021, 11:35 PM

Change 675572 merged by jenkins-bot:

[mediawiki/core@master] Hard Deprecate User ::getCanonicalName, ::isUsableName, ::isCreatableName

https://gerrit.wikimedia.org/r/675572

ReleaseTaggerBot added a project: MW-1.37-notes (1.37.0-wmf.5; 2021-05-11).May 5 2021, 12:00 AM
Vlad.shapik moved this task from Waiting for Review to Blocked on the Platform Team Workboards (MW Expedition) board.May 7 2021, 11:24 AM
Vlad.shapik added a comment.EditedMay 7 2021, 11:53 AM

The patch for the core will be merged and the ticket will be resolved when the setters of AbstractAuthenticationProvider will be replaced in all deployed extensions.
So wait for resolving the following ticket about the setters - T281174.

Vlad.shapik moved this task from Blocked to Doing on the Platform Team Workboards (MW Expedition) board.May 31 2021, 11:38 AM
Vlad.shapik moved this task from Doing to Waiting for Review on the Platform Team Workboards (MW Expedition) board.Jun 1 2021, 2:34 PM
Vlad.shapik moved this task from Waiting for Review to On the train on the Platform Team Workboards (MW Expedition) board.Jun 1 2021, 4:36 PM
• Pchelolo closed this task as Resolved.Jun 17 2021, 8:59 PM
gerritbot added a comment.Nov 4 2021, 9:21 PM

Change 673444 abandoned by Umherirrender:

[mediawiki/extensions/ApprovedRevs@master] Avoid using User::getCanonicalName

Reason:

superseeded by I79b93997dbad386f0b265e91cbf01a7fb06bdfc2

https://gerrit.wikimedia.org/r/673444

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits