Page MenuHomePhabricator

Avoid using User ::isUsableName, ::isCreatableName, ::getCanonicalName
Open, MediumPublic

Description

User::isUsableName, User::isCreatableName, User::getCanonicalName were soft deprecated and now need to be hard deprecated. So we need to remove using from the extensions:

  • CentralAuth
  • FlaggedRevs
  • OpenStackManager
  • AbuseFilter
  • ConfirmEdit
  • Translate
  • Echo
  • LdapAuthentication
  • BlueSpicePrivacy
  • RegexBlock
  • BlueSpiceFoundation
  • ApprovedRevs
  • Auth_remoteuser
  • ImapAuthorization

Details

ProjectBranchLines +/-Subject
mediawiki/coremaster+97 -37
mediawiki/coremaster+340 -106
mediawiki/coremaster+479 -210
mediawiki/extensions/ApprovedRevsmaster+7 -1
mediawiki/coremaster+311 -117
mediawiki/coremaster+308 -117
mediawiki/coremaster+308 -117
mediawiki/extensions/BlueSpiceFoundationmaster+4 -3
mediawiki/extensions/RegexBlockmaster+48 -4
mediawiki/extensions/ImapAuthorizationmaster+16 -2
mediawiki/extensions/Auth_remoteusermaster+2 -2
mediawiki/extensions/BlueSpicePrivacymaster+4 -2
mediawiki/extensions/Echomaster+6 -4
mediawiki/extensions/Translatemaster+13 -1
mediawiki/extensions/CentralAuthmaster+249 -74
mediawiki/extensions/LdapAuthenticationmaster+17 -7
mediawiki/extensions/ConfirmEditmaster+3 -1
mediawiki/extensions/OpenStackManagermaster+2 -1
mediawiki/extensions/FlaggedRevsmaster+2 -1
mediawiki/extensions/AbuseFiltermaster+12 -2
Show related patches Customize query in gerrit

Event Timeline

Change 664877 had a related patch set uploaded (by Vlad.shapik; owner: Vlad.shapik):
[mediawiki/extensions/CentralAuth@master] Avoid using User ::isUsableName, ::isCreatableName, ::getCanonicalName

https://gerrit.wikimedia.org/r/664877

Change 665475 had a related patch set uploaded (by Vlad.shapik; owner: Vlad.shapik):
[mediawiki/extensions/FlaggedRevs@master] Avoid using User ::isUsableName

https://gerrit.wikimedia.org/r/665475

Change 665655 had a related patch set uploaded (by Vlad.shapik; owner: Vlad.shapik):
[mediawiki/extensions/OpenStackManager@master] Avoid using User ::isCreatableName

https://gerrit.wikimedia.org/r/665655

Change 665660 had a related patch set uploaded (by Vlad.shapik; owner: Vlad.shapik):
[mediawiki/extensions/AbuseFilter@master] Avoid using User ::getCanonicalName

https://gerrit.wikimedia.org/r/665660

Change 665662 had a related patch set uploaded (by Vlad.shapik; owner: Vlad.shapik):
[mediawiki/extensions/ConfirmEdit@master] Avoid using User ::getCanonicalName

https://gerrit.wikimedia.org/r/665662

Change 665760 had a related patch set uploaded (by Vlad.shapik; owner: Vlad.shapik):
[mediawiki/extensions/Translate@master] Avoid using User ::getCanonicalName

https://gerrit.wikimedia.org/r/665760

Change 665801 had a related patch set uploaded (by Vlad.shapik; owner: Vlad.shapik):
[mediawiki/extensions/Echo@master] Avoid using User ::getCanonicalName

https://gerrit.wikimedia.org/r/665801

Change 665803 had a related patch set uploaded (by Vlad.shapik; owner: Vlad.shapik):
[mediawiki/extensions/LdapAuthentication@master] Avoid using User ::getCanonicalName

https://gerrit.wikimedia.org/r/665803

Change 665660 merged by jenkins-bot:
[mediawiki/extensions/AbuseFilter@master] Avoid using User ::getCanonicalName

https://gerrit.wikimedia.org/r/665660

Change 665475 merged by jenkins-bot:
[mediawiki/extensions/FlaggedRevs@master] Avoid using User ::isUsableName

https://gerrit.wikimedia.org/r/665475

daniel triaged this task as Medium priority.Feb 23 2021, 6:43 PM

Change 665655 merged by jenkins-bot:
[mediawiki/extensions/OpenStackManager@master] Avoid using User ::isCreatableName

https://gerrit.wikimedia.org/r/665655

Change 665662 merged by jenkins-bot:
[mediawiki/extensions/ConfirmEdit@master] Avoid using User ::getCanonicalName

https://gerrit.wikimedia.org/r/665662

Change 665803 merged by jenkins-bot:
[mediawiki/extensions/LdapAuthentication@master] Avoid using User ::getCanonicalName

https://gerrit.wikimedia.org/r/665803

Change 664877 merged by jenkins-bot:
[mediawiki/extensions/CentralAuth@master] Avoid using User ::isUsableName, ::isCreatableName, ::getCanonicalName

https://gerrit.wikimedia.org/r/664877

Change 665760 merged by jenkins-bot:
[mediawiki/extensions/Translate@master] Avoid using User ::getCanonicalName

https://gerrit.wikimedia.org/r/665760

Change 665801 merged by jenkins-bot:
[mediawiki/extensions/Echo@master] Avoid using User ::getCanonicalName

https://gerrit.wikimedia.org/r/665801

Seems like it's ready to introduce a hard-deprecation patch.

Seems like it's ready to introduce a hard-deprecation patch.

Do you mean to introduce for the core with this group of methods?

Yes. Seems like all usages in extensions were removed.

Yes. Seems like all usages in extensions were removed.

Yes, I removed all usages of these methods in all deployed extensions. So, I will create hard-deprecation patch for the core under this ticket.

Change 673274 had a related patch set uploaded (by Vlad.shapik; owner: Vlad.shapik):
[mediawiki/extensions/BlueSpicePrivacy@master] Avoid using User ::newFromName, ::isCreatableName

https://gerrit.wikimedia.org/r/673274

Change 673274 merged by jenkins-bot:
[mediawiki/extensions/BlueSpicePrivacy@master] Avoid using User ::newFromName, ::isCreatableName

https://gerrit.wikimedia.org/r/673274

Change 673294 had a related patch set uploaded (by Vlad.shapik; owner: Vlad.shapik):
[mediawiki/extensions/RegexBlock@master] Avoid using User::isUsableName

https://gerrit.wikimedia.org/r/673294

Nikerabbit added a subscriber: Nikerabbit.

I suppose you meant Translate instead of translatewiki.

Change 673305 had a related patch set uploaded (by Vlad.shapik; owner: Vlad.shapik):
[mediawiki/extensions/BlueSpiceFoundation@master] Avoid using User ::isCreatableName, ::isUsableName

https://gerrit.wikimedia.org/r/673305

Change 673444 had a related patch set uploaded (by Vlad.shapik; owner: Vlad.shapik):
[mediawiki/extensions/ApprovedRevs@master] Avoid using User::getCanonicalName

https://gerrit.wikimedia.org/r/673444

Change 673445 had a related patch set uploaded (by Vlad.shapik; owner: Vlad.shapik):
[mediawiki/extensions/Auth_remoteuser@master] Avoid using User ::getCanonicalName, ::isUsableName

https://gerrit.wikimedia.org/r/673445

Change 673449 had a related patch set uploaded (by Vlad.shapik; owner: Vlad.shapik):
[mediawiki/extensions/ImapAuthorization@master] Avoid using User::getCanonicalName

https://gerrit.wikimedia.org/r/673449

Change 673445 merged by jenkins-bot:
[mediawiki/extensions/Auth_remoteuser@master] Avoid using User ::getCanonicalName, ::isUsableName

https://gerrit.wikimedia.org/r/673445

Change 673449 merged by Alphanoob1337:
[mediawiki/extensions/ImapAuthorization@master] Avoid using User::getCanonicalName

https://gerrit.wikimedia.org/r/673449

Change 673294 merged by Jack Phoenix:
[mediawiki/extensions/RegexBlock@master] Avoid using User::isUsableName

https://gerrit.wikimedia.org/r/673294

Change 673305 merged by jenkins-bot:
[mediawiki/extensions/BlueSpiceFoundation@master] Avoid using User ::isCreatableName, ::isUsableName

https://gerrit.wikimedia.org/r/673305

Change 675572 had a related patch set uploaded (by Peter.ovchyn; author: Peter.ovchyn):
[mediawiki/core@master] Hard Deprecate User ::getCanonicalName, ::isUsableName, ::isCreatableName

https://gerrit.wikimedia.org/r/675572

Change 675825 had a related patch set uploaded (by Peter.ovchyn; author: Peter.ovchyn):
[mediawiki/core@master] Hard Deprecate User ::getCanonicalName, ::isUsableName, ::isCreatableName

https://gerrit.wikimedia.org/r/675825

Change 675826 had a related patch set uploaded (by Peter.ovchyn; author: Peter.ovchyn):
[mediawiki/core@master] Hard Deprecate User ::getCanonicalName, ::isUsableName, ::isCreatableName

https://gerrit.wikimedia.org/r/675826

Change 675830 had a related patch set uploaded (by Peter.ovchyn; author: Peter.ovchyn):
[mediawiki/core@master] Hard Deprecate User ::getCanonicalName, ::isUsableName, ::isCreatableName

https://gerrit.wikimedia.org/r/675830

Change 675830 abandoned by Peter.ovchyn:
[mediawiki/core@master] Hard Deprecate User ::getCanonicalName, ::isUsableName, ::isCreatableName

Reason:
Wrong patch

https://gerrit.wikimedia.org/r/675830

Change 675826 abandoned by Peter.ovchyn:
[mediawiki/core@master] Hard Deprecate User ::getCanonicalName, ::isUsableName, ::isCreatableName

Reason:
Wrong patch

https://gerrit.wikimedia.org/r/675826

Change 675825 abandoned by Peter.ovchyn:
[mediawiki/core@master] Hard Deprecate User ::getCanonicalName, ::isUsableName, ::isCreatableName

Reason:
Wrong patch

https://gerrit.wikimedia.org/r/675825

Change 680327 had a related patch set uploaded (by Vlad.shapik; author: Vlad.shapik):

[mediawiki/core@master] Implement injecting of deprendencies to a provider

https://gerrit.wikimedia.org/r/680327

Change 680327 merged by jenkins-bot:

[mediawiki/core@master] Implement injecting of dependencies to an AuthenticationProvider

https://gerrit.wikimedia.org/r/680327

Change 683726 had a related patch set uploaded (by Vlad.shapik; author: Vlad.shapik):

[mediawiki/core@master] Implement injecting of dependencies to a SessionProvider

https://gerrit.wikimedia.org/r/683726

Change 683726 merged by jenkins-bot:

[mediawiki/core@master] Create an initialization method in the SessionProvider class

https://gerrit.wikimedia.org/r/683726

Change 675572 merged by jenkins-bot:

[mediawiki/core@master] Hard Deprecate User ::getCanonicalName, ::isUsableName, ::isCreatableName

https://gerrit.wikimedia.org/r/675572

The patch for the core will be merged and the ticket will be resolved when the setters of AbstractAuthenticationProvider will be replaced in all deployed extensions.
So wait for resolving the following ticket about the setters - T281174.