Page MenuHomePhabricator

Reword Library Bundle string
Closed, ResolvedPublic

Description

Task

The string starting at TWLight/resources/templates/resources/partner_detail.html#L534 should be reworded from "This resource is part of our <a href="{{ about }}">Library Bundle</a>access, which you can access" to "This resource is part of our <a href="{{ about }}">Library Bundle</a>, which you can access" to avoid repeating the word "access" in quick succession.

Good first task

This task has been placed in the good first task category. This means it has been scoped and written in a way that makes it simpler for folks who haven’t contributed to the tool’s development or open source software in the past.

If that’s you, welcome! Please feel free to ask questions here about this specific task or the codebase more generally. We’ll be more than happy to help you and clarify the steps needed to complete the task, whether that’s setting up the repository, implementing the necessary changes, or pushing your changes to Github.

If you have experience contributing to this project or similar ones, please consider leaving this one for someone new, and taking a look at the Open Tasks column of the workboard for another task. Also feel free to help out if you see unanswered questions here!

How to contribute

Assign yourself to this task: Click the ‘Add Action’ dropdown menu below and then select Assign / Claim. The box should fill your username in automatically, then click Submit!

The Library Card platform repository can be found at WikipediaLibrary/TWLight. Please see the Getting Started and Local Setup guides to get up and running with a local development environment.

To submit your changes, you should fork the repository and create a new branch. After pushing your changes to your Github branch, you can open a pull request. Please link your pull request in a comment here when it has been submitted, and include the Phabricator task number in the pull request. Experienced contributors to the project will review your code and either provide feedback or merge it in!

Event Timeline

@Uditdesai2206 It would be helpful if you could only claim the one task you're working on at any particular time. You've claimed three for the Library-Card-Platform - can you un-claim the ones you aren't currently working on? Thanks :)

Uditdesai2206 subscribed.

@Samwalton9 . Sorry for the inconvenience :( . I have un-claimed the ones I am not currently working on. I had claimed them since they were similar in nature and the required changes were also in the same file .