500k invalid events in the last day:
https://logstash.wikimedia.org/goto/7ecbceeeedc656c28eb9be181f671106
Additional properties are not allowed ('optedOutCampaigns' was unexpected)
It seems to have started two days ago, maybe with af9b0791b4049a81f2314e1e081c8e6a4ef4f809.
Change 664887 had a related patch set uploaded (by AndyRussG; owner: AndyRussG):
[mediawiki/extensions/CentralNotice@master] Remove optedOutCampaigns property from impression data
Change 664889 had a related patch set uploaded (by AndyRussG; owner: AndyRussG):
[operations/mediawiki-config@master] Remove wgCentralNoticeImpressionEventSampleRate (will default to 0)
Change 664887 merged by jenkins-bot:
[mediawiki/extensions/CentralNotice@master] Remove optedOutCampaigns property from impression data
Change 664949 had a related patch set uploaded (by AndyRussG; owner: AndyRussG):
[mediawiki/extensions/CentralNotice@wmf_deploy] Remove optedOutCampaigns property from impression data
Change 664949 merged by jenkins-bot:
[mediawiki/extensions/CentralNotice@wmf_deploy] Remove optedOutCampaigns property from impression data
Change 664665 had a related patch set uploaded (by Urbanecm; owner: AndyRussG):
[mediawiki/extensions/CentralNotice@wmf/1.36.0-wmf.30] Remove optedOutCampaigns property from impression data
Change 664966 had a related patch set uploaded (by Urbanecm; owner: AndyRussG):
[mediawiki/extensions/CentralNotice@wmf/1.36.0-wmf.31] Remove optedOutCampaigns property from impression data
Change 664889 merged by jenkins-bot:
[operations/mediawiki-config@master] Remove wgCentralNoticeImpressionEventSampleRate (will default to 0)
Change 664665 merged by jenkins-bot:
[mediawiki/extensions/CentralNotice@wmf/1.36.0-wmf.30] Remove optedOutCampaigns property from impression data
Change 664966 merged by jenkins-bot:
[mediawiki/extensions/CentralNotice@wmf/1.36.0-wmf.31] Remove optedOutCampaigns property from impression data
Mentioned in SAL (#wikimedia-operations) [2021-02-18T00:28:37Z] <urbanecm@deploy1001> sync-file aborted: 08b32c453a1e879e6321ebec39122d0e06e14714: Remove wgCentralNoticeImpressionEventSampleRate; will default to 0 (T275054) (duration: 00m 00s)
Mentioned in SAL (#wikimedia-operations) [2021-02-18T00:31:06Z] <urbanecm@deploy1001> Synchronized wmf-config/CommonSettings.php: 08b32c453a1e879e6321ebec39122d0e06e14714: Remove wgCentralNoticeImpressionEventSampleRate; will default to 0 (T275054) (duration: 02m 17s)
Mentioned in SAL (#wikimedia-operations) [2021-02-18T00:32:53Z] <urbanecm@deploy1001> Synchronized php-1.36.0-wmf.31/extensions/CentralNotice/resources/ext.centralNotice.display/state.js: rECNOff444c28eacb: Remove optedOutCampaigns property from impression data (T275054) (duration: 01m 09s)
Mentioned in SAL (#wikimedia-operations) [2021-02-18T00:34:30Z] <urbanecm@deploy1001> Synchronized php-1.36.0-wmf.30/extensions/CentralNotice/resources/ext.centralNotice.display/state.js: rECNOdd64e4488672: Remove optedOutCampaigns property from impression data (T275054) (duration: 01m 08s)
This looks fixed! There are still a few events like this in the wild, probably due to incorrectly cached JS, but the number has dropped dramatically. Thanks again @awight!!
@AbbanWMDE I noticed today that the CentralNotice banner impression events seems to have been shut off since these patches in 2021. Does it make sense to also remove this version of the impression tracking logic, for maintenance reasons? Looks like the so-called legacy impression counting using /beacon/impression is still in place.