Page MenuHomePhabricator
Create Task
Maniphest T275054

Many invalid CentralNoticeImpression events
Closed, ResolvedPublic
Actions

Description

500k invalid events in the last day:
https://logstash.wikimedia.org/goto/7ecbceeeedc656c28eb9be181f671106

Additional properties are not allowed ('optedOutCampaigns' was unexpected)

It seems to have started two days ago, maybe with af9b0791b4049a81f2314e1e081c8e6a4ef4f809.

Details

ProjectBranchLines +/-Subject
operations/mediawiki-configmaster+0 -3Remove wgCentralNoticeImpressionEventSampleRate (will default to 0)
mediawiki/extensions/CentralNoticewmf/1.36.0-wmf.31+1 -0Remove optedOutCampaigns property from impression data
mediawiki/extensions/CentralNoticewmf/1.36.0-wmf.30+1 -0Remove optedOutCampaigns property from impression data
mediawiki/extensions/CentralNoticewmf_deploy+1 -0Remove optedOutCampaigns property from impression data
mediawiki/extensions/CentralNoticemaster+1 -0Remove optedOutCampaigns property from impression data
Customize query in gerrit

Related Objects

Event Timeline

awight created this task.Wed, Feb 17, 5:40 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptWed, Feb 17, 5:40 PM
gerritbot added a comment.Wed, Feb 17, 7:08 PM

Change 664887 had a related patch set uploaded (by AndyRussG; owner: AndyRussG):
[mediawiki/extensions/CentralNotice@master] Remove optedOutCampaigns property from impression data

https://gerrit.wikimedia.org/r/664887

gerritbot added a project: Patch-For-Review.Wed, Feb 17, 7:08 PM
gerritbot added a comment.Wed, Feb 17, 7:13 PM

Change 664889 had a related patch set uploaded (by AndyRussG; owner: AndyRussG):
[operations/mediawiki-config@master] Remove wgCentralNoticeImpressionEventSampleRate (will default to 0)

https://gerrit.wikimedia.org/r/664889

gerritbot added a comment.Wed, Feb 17, 7:45 PM

Change 664887 merged by jenkins-bot:
[mediawiki/extensions/CentralNotice@master] Remove optedOutCampaigns property from impression data

https://gerrit.wikimedia.org/r/664887

ReleaseTaggerBot added a project: MW-1.36-notes (1.36.0-wmf.32; 2021-02-23).Wed, Feb 17, 8:00 PM
Aklapper added a project: Wikimedia-production-error.Wed, Feb 17, 11:13 PM
gerritbot added a comment.Wed, Feb 17, 11:18 PM

Change 664949 had a related patch set uploaded (by AndyRussG; owner: AndyRussG):
[mediawiki/extensions/CentralNotice@wmf_deploy] Remove optedOutCampaigns property from impression data

https://gerrit.wikimedia.org/r/664949

gerritbot added a comment.Wed, Feb 17, 11:26 PM

Change 664949 merged by jenkins-bot:
[mediawiki/extensions/CentralNotice@wmf_deploy] Remove optedOutCampaigns property from impression data

https://gerrit.wikimedia.org/r/664949

gerritbot added a comment.Thu, Feb 18, 12:14 AM

Change 664665 had a related patch set uploaded (by Urbanecm; owner: AndyRussG):
[mediawiki/extensions/CentralNotice@wmf/1.36.0-wmf.30] Remove optedOutCampaigns property from impression data

https://gerrit.wikimedia.org/r/664665

gerritbot added a comment.Thu, Feb 18, 12:18 AM

Change 664966 had a related patch set uploaded (by Urbanecm; owner: AndyRussG):
[mediawiki/extensions/CentralNotice@wmf/1.36.0-wmf.31] Remove optedOutCampaigns property from impression data

https://gerrit.wikimedia.org/r/664966

gerritbot added a comment.Thu, Feb 18, 12:20 AM

Change 664889 merged by jenkins-bot:
[operations/mediawiki-config@master] Remove wgCentralNoticeImpressionEventSampleRate (will default to 0)

https://gerrit.wikimedia.org/r/664889

gerritbot added a comment.Thu, Feb 18, 12:23 AM

Change 664665 merged by jenkins-bot:
[mediawiki/extensions/CentralNotice@wmf/1.36.0-wmf.30] Remove optedOutCampaigns property from impression data

https://gerrit.wikimedia.org/r/664665

gerritbot added a comment.Thu, Feb 18, 12:23 AM

Change 664966 merged by jenkins-bot:
[mediawiki/extensions/CentralNotice@wmf/1.36.0-wmf.31] Remove optedOutCampaigns property from impression data

https://gerrit.wikimedia.org/r/664966

Stashbot added a comment.Thu, Feb 18, 12:28 AM

Mentioned in SAL (#wikimedia-operations) [2021-02-18T00:28:37Z] <urbanecm@deploy1001> sync-file aborted: 08b32c453a1e879e6321ebec39122d0e06e14714: Remove wgCentralNoticeImpressionEventSampleRate; will default to 0 (T275054) (duration: 00m 00s)

Stashbot added a comment.Thu, Feb 18, 12:31 AM

Mentioned in SAL (#wikimedia-operations) [2021-02-18T00:31:06Z] <urbanecm@deploy1001> Synchronized wmf-config/CommonSettings.php: 08b32c453a1e879e6321ebec39122d0e06e14714: Remove wgCentralNoticeImpressionEventSampleRate; will default to 0 (T275054) (duration: 02m 17s)

Stashbot added a comment.Thu, Feb 18, 12:32 AM

Mentioned in SAL (#wikimedia-operations) [2021-02-18T00:32:53Z] <urbanecm@deploy1001> Synchronized php-1.36.0-wmf.31/extensions/CentralNotice/resources/ext.centralNotice.display/state.js: ff444c28eacbac45476b8fbaed82bc3d8fc4dc66: Remove optedOutCampaigns property from impression data (T275054) (duration: 01m 09s)

Stashbot added a comment.Thu, Feb 18, 12:34 AM

Mentioned in SAL (#wikimedia-operations) [2021-02-18T00:34:30Z] <urbanecm@deploy1001> Synchronized php-1.36.0-wmf.30/extensions/CentralNotice/resources/ext.centralNotice.display/state.js: dd64e44886727871fa0d2e0e87960d7d8ffba451: Remove optedOutCampaigns property from impression data (T275054) (duration: 01m 08s)

ReleaseTaggerBot edited projects, added MW-1.36-notes (1.36.0-wmf.31; 2021-02-16); removed MW-1.36-notes (1.36.0-wmf.32; 2021-02-23).Thu, Feb 18, 1:00 AM
AndyRussG closed this task as Resolved.Thu, Feb 18, 3:54 AM
AndyRussG claimed this task.
AndyRussG added a subscriber: AndyRussG.

This looks fixed! There are still a few events like this in the wild, probably due to incorrectly cached JS, but the number has dropped dramatically. Thanks again @awight!!

AndyRussG edited projects, added Fundraising-Backlog, Fundraising Sprint Downed power line jump rope; removed Patch-For-Review, FR-Tech-Analytics.Thu, Feb 18, 3:55 AM
AndyRussG moved this task from Triage to Sprint C Feb 2nd to Feb 16th on the Fundraising-Backlog board.
AndyRussG moved this task from Backlog to Done on the Fundraising Sprint Downed power line jump rope board.
Content licensed under Creative Commons Attribution-ShareAlike 3.0 (CC-BY-SA) unless otherwise noted; code licensed under GNU General Public License (GPL) or other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL