Page MenuHomePhabricator

Many invalid CentralNoticeImpression events
Closed, ResolvedPublic

Description

500k invalid events in the last day:
https://logstash.wikimedia.org/goto/7ecbceeeedc656c28eb9be181f671106

Additional properties are not allowed ('optedOutCampaigns' was unexpected)

It seems to have started two days ago, maybe with af9b0791b4049a81f2314e1e081c8e6a4ef4f809.

Event Timeline

Change 664887 had a related patch set uploaded (by AndyRussG; owner: AndyRussG):
[mediawiki/extensions/CentralNotice@master] Remove optedOutCampaigns property from impression data

https://gerrit.wikimedia.org/r/664887

Change 664889 had a related patch set uploaded (by AndyRussG; owner: AndyRussG):
[operations/mediawiki-config@master] Remove wgCentralNoticeImpressionEventSampleRate (will default to 0)

https://gerrit.wikimedia.org/r/664889

Change 664887 merged by jenkins-bot:
[mediawiki/extensions/CentralNotice@master] Remove optedOutCampaigns property from impression data

https://gerrit.wikimedia.org/r/664887

Change 664949 had a related patch set uploaded (by AndyRussG; owner: AndyRussG):
[mediawiki/extensions/CentralNotice@wmf_deploy] Remove optedOutCampaigns property from impression data

https://gerrit.wikimedia.org/r/664949

Change 664949 merged by jenkins-bot:
[mediawiki/extensions/CentralNotice@wmf_deploy] Remove optedOutCampaigns property from impression data

https://gerrit.wikimedia.org/r/664949

Change 664665 had a related patch set uploaded (by Urbanecm; owner: AndyRussG):
[mediawiki/extensions/CentralNotice@wmf/1.36.0-wmf.30] Remove optedOutCampaigns property from impression data

https://gerrit.wikimedia.org/r/664665

Change 664966 had a related patch set uploaded (by Urbanecm; owner: AndyRussG):
[mediawiki/extensions/CentralNotice@wmf/1.36.0-wmf.31] Remove optedOutCampaigns property from impression data

https://gerrit.wikimedia.org/r/664966

Change 664889 merged by jenkins-bot:
[operations/mediawiki-config@master] Remove wgCentralNoticeImpressionEventSampleRate (will default to 0)

https://gerrit.wikimedia.org/r/664889

Change 664665 merged by jenkins-bot:
[mediawiki/extensions/CentralNotice@wmf/1.36.0-wmf.30] Remove optedOutCampaigns property from impression data

https://gerrit.wikimedia.org/r/664665

Change 664966 merged by jenkins-bot:
[mediawiki/extensions/CentralNotice@wmf/1.36.0-wmf.31] Remove optedOutCampaigns property from impression data

https://gerrit.wikimedia.org/r/664966

Mentioned in SAL (#wikimedia-operations) [2021-02-18T00:28:37Z] <urbanecm@deploy1001> sync-file aborted: 08b32c453a1e879e6321ebec39122d0e06e14714: Remove wgCentralNoticeImpressionEventSampleRate; will default to 0 (T275054) (duration: 00m 00s)

Mentioned in SAL (#wikimedia-operations) [2021-02-18T00:31:06Z] <urbanecm@deploy1001> Synchronized wmf-config/CommonSettings.php: 08b32c453a1e879e6321ebec39122d0e06e14714: Remove wgCentralNoticeImpressionEventSampleRate; will default to 0 (T275054) (duration: 02m 17s)

Mentioned in SAL (#wikimedia-operations) [2021-02-18T00:32:53Z] <urbanecm@deploy1001> Synchronized php-1.36.0-wmf.31/extensions/CentralNotice/resources/ext.centralNotice.display/state.js: ff444c28eacbac45476b8fbaed82bc3d8fc4dc66: Remove optedOutCampaigns property from impression data (T275054) (duration: 01m 09s)

Mentioned in SAL (#wikimedia-operations) [2021-02-18T00:34:30Z] <urbanecm@deploy1001> Synchronized php-1.36.0-wmf.30/extensions/CentralNotice/resources/ext.centralNotice.display/state.js: dd64e44886727871fa0d2e0e87960d7d8ffba451: Remove optedOutCampaigns property from impression data (T275054) (duration: 01m 08s)

AndyRussG claimed this task.
AndyRussG added a subscriber: AndyRussG.

This looks fixed! There are still a few events like this in the wild, probably due to incorrectly cached JS, but the number has dropped dramatically. Thanks again @awight!!