Page MenuHomePhabricator
Create Task
Maniphest T275067

CannotCreateActorException: Cannot create an actor for a usable name that is not an existing user: … (via SpecialImportFile)
Closed, ResolvedPublicPRODUCTION ERROR
Actions

Description

normalized_message
CannotCreateActorException: Cannot create an actor for a usable name that is not an existing user: …
exception.trace
from /srv/mediawiki/php-1.36.0-wmf.30/includes/user/ActorStore.php(341)
#0 /srv/mediawiki/php-1.36.0-wmf.30/includes/ActorMigration.php(364): MediaWiki\User\ActorStore->acquireActorId(User, Wikimedia\Rdbms\DatabaseMysqli)
#1 /srv/mediawiki/php-1.36.0-wmf.30/includes/Revision/RevisionStore.php(650): ActorMigration->getInsertValuesWithTempTable(Wikimedia\Rdbms\DatabaseMysqli, string, User)
#2 /srv/mediawiki/php-1.36.0-wmf.30/includes/Revision/RevisionStore.php(505): MediaWiki\Revision\RevisionStore->insertRevisionRowOn(Wikimedia\Rdbms\DatabaseMysqli, MediaWiki\Revision\MutableRevisionRecord, integer)
#3 /srv/mediawiki/php-1.36.0-wmf.30/includes/Revision/RevisionStore.php(444): MediaWiki\Revision\RevisionStore->insertRevisionInternal(MediaWiki\Revision\MutableRevisionRecord, Wikimedia\Rdbms\DatabaseMysqli, User, CommentStoreComment, Title, integer, integer)
#4 /srv/mediawiki/php-1.36.0-wmf.30/includes/libs/rdbms/database/Database.php(4500): MediaWiki\Revision\RevisionStore->MediaWiki\Revision\{closure}(Wikimedia\Rdbms\DatabaseMysqli, string)
#5 /srv/mediawiki/php-1.36.0-wmf.30/includes/libs/rdbms/database/DBConnRef.php(68): Wikimedia\Rdbms\Database->doAtomicSection(string, Closure)
#6 /srv/mediawiki/php-1.36.0-wmf.30/includes/libs/rdbms/database/DBConnRef.php(641): Wikimedia\Rdbms\DBConnRef->__call(string, array)
#7 /srv/mediawiki/php-1.36.0-wmf.30/includes/Revision/RevisionStore.php(446): Wikimedia\Rdbms\DBConnRef->doAtomicSection(string, Closure)
#8 /srv/mediawiki/php-1.36.0-wmf.30/includes/import/ImportableOldRevisionImporter.php(197): MediaWiki\Revision\RevisionStore->insertRevisionOn(MediaWiki\Revision\MutableRevisionRecord, Wikimedia\Rdbms\DBConnRef)
#9 /srv/mediawiki/php-1.36.0-wmf.30/extensions/FileImporter/src/Operations/TextRevisionFromTextRevision.php(127): ImportableOldRevisionImporter->import(WikiRevision)
#10 /srv/mediawiki/php-1.36.0-wmf.30/extensions/FileImporter/src/Data/ImportOperations.php(133): FileImporter\Operations\TextRevisionFromTextRevision->commit()
#11 /srv/mediawiki/php-1.36.0-wmf.30/extensions/FileImporter/src/Data/ImportOperations.php(82): FileImporter\Data\ImportOperations->FileImporter\Data\{closure}(FileImporter\Operations\TextRevisionFromTextRevision)
#12 /srv/mediawiki/php-1.36.0-wmf.30/extensions/FileImporter/src/Data/ImportOperations.php(134): FileImporter\Data\ImportOperations->runOperations(integer, integer, boolean, Closure)
#13 /srv/mediawiki/php-1.36.0-wmf.30/extensions/FileImporter/src/Services/Importer.php(310): FileImporter\Data\ImportOperations->commit()
#14 /srv/mediawiki/php-1.36.0-wmf.30/extensions/FileImporter/src/Services/Importer.php(174): FileImporter\Services\Importer->commitImportOperations(FileImporter\Data\ImportOperations)
#15 /srv/mediawiki/php-1.36.0-wmf.30/extensions/FileImporter/src/SpecialImportFile.php(335): FileImporter\Services\Importer->import(User, FileImporter\Data\ImportPlan)
#16 /srv/mediawiki/php-1.36.0-wmf.30/extensions/FileImporter/src/SpecialImportFile.php(236): FileImporter\SpecialImportFile->doImport(FileImporter\Data\ImportPlan)
#17 /srv/mediawiki/php-1.36.0-wmf.30/extensions/FileImporter/src/SpecialImportFile.php(201): FileImporter\SpecialImportFile->handleAction(string, FileImporter\Data\ImportPlan)
#18 /srv/mediawiki/php-1.36.0-wmf.30/includes/specialpage/SpecialPage.php(645): FileImporter\SpecialImportFile->execute(NULL)
#19 /srv/mediawiki/php-1.36.0-wmf.30/includes/specialpage/SpecialPageFactory.php(1405): SpecialPage->run(NULL)
#20 /srv/mediawiki/php-1.36.0-wmf.30/includes/MediaWiki.php(310): MediaWiki\SpecialPage\SpecialPageFactory->executePath(Title, RequestContext)
#21 /srv/mediawiki/php-1.36.0-wmf.30/includes/MediaWiki.php(944): MediaWiki->performRequest()
#22 /srv/mediawiki/php-1.36.0-wmf.30/includes/MediaWiki.php(548): MediaWiki->main()
#23 /srv/mediawiki/php-1.36.0-wmf.30/index.php(53): MediaWiki->run()
#24 /srv/mediawiki/php-1.36.0-wmf.30/index.php(46): wfIndexMain()
#25 /srv/mediawiki/w/index.php(3): require(string)
#26 {main}
Impact
Notes

Details

Request ID
YC1o8-@BS9zA7K8jKQI-iQAAAJU
Request URL
https://commons.wikimedia.org/wiki/Special:ImportFile
Related Changes in Gerrit:
SubjectAuthorRepoBranchLines +/-
ActorStore: Try fetching actor id from primary before throwingPpchelkomediawiki/coremaster+54 -20
ActorStore: bypass repeatable read snapshot when creating actor.Ppchelkomediawiki/coremaster+11 -10
Customize query in gerrit

Event Timeline

Krinkle created this task.Feb 17 2021, 7:26 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptFeb 17 2021, 7:26 PM
Krinkle added a project: Release-Engineering-Team (Logspam).Feb 17 2021, 7:29 PM
Krinkle moved this task from Untriaged to Feb 2021 on the Wikimedia-production-error board.Feb 17 2021, 7:48 PM
Ammarpad removed a project: MediaWiki-Core-Snapshots.Feb 17 2021, 9:29 PM
Ammarpad added a project: Move-Files-To-Commons.Feb 17 2021, 9:47 PM
Krinkle added projects: MediaWiki-Core-Revision-backend, MediaWiki-User-management, Platform Engineering.Feb 17 2021, 9:48 PM
Krinkle added a subscriber: Ammarpad.

@Ammarpad I tagged Export-Import as the error was observed while using the Import feature. That's usually where I'd expect investigation to begin. However, I suppose given how little that has changed over the years, and the fact that RevisionStore and the Actor system are relatively new, it's not unlikely that the problem might be there instead. Is that why you untagged it?

I'll tag Revision-backend and User-management (which encompasses RevisionStore as inserter; and ActorStore as receiver), both of which are owned by PET.

• Pchelolo subscribed.EditedFeb 17 2021, 9:53 PM

Most certaintly caused by https://gerrit.wikimedia.org/r/c/mediawiki/core/+/661572 - we've actually started using UserIdentityValue and actors in revision store. The patch though tried to preserve existing behavior as much as possible. Investigating. If there's no clear fix from me, reverting the patch should fix the issue.

Ammarpad added a comment.EditedFeb 17 2021, 9:59 PM

@Krinkle, In my understanding, this error is not related to mediawiki core import-export feature, the error is from the file import feature of FileImporter extension. A recent User-related core change may play a role here, but even then that's likely unrelated to MediaWiki-Core-Snapshots since the extension is not using that logic.

• Pchelolo edited projects, added: Platform Team Workboards (MW Expedition); removed: Platform Engineering.Feb 17 2021, 10:11 PM
Krinkle renamed this task from CannotCreateActorException: Cannot create an actor for a usable name that is not an existing user: … (via SpecialImport.php) to CannotCreateActorException: Cannot create an actor for a usable name that is not an existing user: … (via SpecialImportFile).Feb 17 2021, 10:19 PM
• Pchelolo added a comment.EditedFeb 17 2021, 10:43 PM

I was wrong instantly blaming ActorStore refactoring. I can find these exceptions going back 3 months: https://logstash.wikimedia.org/goto/084bc5924b86526d7d37a5ca10cb34fa

This could be a race condition. Currently, we do the following when creating actor:

  1. try to select for existing actor on master
  2. if not found - verify the actor will have a user_id set if the name is a usable name -> this is where it throws now
  3. write new row to actor table
  4. check for affected rows - if it's zero and the insert failed, try reading again, but now use LOCK IN SHARED MODE.

I believe the same race condition that forced adding the final read fallback could be hitting, and forcing us to throw an exception.

All the cases share more or less the same stack trace and are all coming from FileImporter. And it seems like in this case files were imported by users who didn't have commons local account, so it was should have been auto created just before trying to use it

gerritbot added a comment.Feb 17 2021, 11:51 PM

Change 664953 had a related patch set uploaded (by Ppchelko; owner: Ppchelko):
[mediawiki/core@master] ActorStore: try locking read before crashing request

https://gerrit.wikimedia.org/r/664953

gerritbot added a project: Patch-For-Review.Feb 17 2021, 11:51 PM
• Pchelolo triaged this task as High priority.Feb 23 2021, 6:33 PM
• Pchelolo moved this task from Unsorted pile to UserStore pile on the Platform Team Workboards (MW Expedition) board.
• Pchelolo moved this task from UserStore pile to Waiting for Review on the Platform Team Workboards (MW Expedition) board.
• Pchelolo moved this task from Waiting for Review to Doing on the Platform Team Workboards (MW Expedition) board.Feb 23 2021, 6:37 PM
• Pchelolo moved this task from Doing to Waiting for Review on the Platform Team Workboards (MW Expedition) board.Feb 23 2021, 6:40 PM
daniel assigned this task to • Pchelolo.Mar 1 2021, 9:15 PM
daniel moved this task from Waiting for Review to Doing on the Platform Team Workboards (MW Expedition) board.
• Pchelolo moved this task from Doing to Waiting for Review on the Platform Team Workboards (MW Expedition) board.Mar 5 2021, 6:27 PM
• Pchelolo added a comment.Mar 16 2021, 1:53 PM

Some more log context when this happens:

Mar 12, 2021 @ 11:32:17.025	mediawiki	mw1266	[YEtRPL6gBC9b0POalL@nUgAAABg] /wiki/Special:ImportFile   CannotCreateActorException: Cannot create an actor for a usable name that is not an existing user: user_name="REDACTED"
	Mar 12, 2021 @ 11:32:13.404	mediawiki	mw1266	MediaWiki\Auth\AuthManager::autoCreateUser: REDACTED already exists locally (race)
	Mar 12, 2021 @ 11:32:13.402	mediawiki	mw1266	MediaWiki\Auth\AuthManager::autoCreateUser: creating new user (REDACTED) - from: /wiki/Special:ImportFile
	Mar 12, 2021 @ 11:32:06.110	mediawiki	mw1264	Couldn't find a global ID for user REDACTED
	Mar 12, 2021 @ 11:32:05.992	mediawiki	mw1264	Couldn't find a global ID for user REDACTED
	Mar 12, 2021 @ 11:32:05.982	mediawiki	mw1264	Attaching local user REDACTED@commonswiki by 'login'
	Mar 12, 2021 @ 11:32:05.978	mediawiki	mw1264	Couldn't find a global ID for user REDACTED
JJMC89 moved this task from Backlog to Other on the MediaWiki-User-management board.May 3 2021, 3:02 PM
gerritbot added a comment.May 11 2021, 2:42 PM

Change 664953 abandoned by Ppchelko:

[mediawiki/core@master] ActorStore: bypass repeatable read snapshot when creating actor.

Reason:

https://gerrit.wikimedia.org/r/664953

Maintenance_bot removed a project: Patch-For-Review.May 11 2021, 3:10 PM
gerritbot added a comment.May 13 2021, 5:26 PM

Change 690583 had a related patch set uploaded (by Ppchelko; author: Ppchelko):

[mediawiki/core@master] ActorStore: Try fetching actor id from master before throwing

https://gerrit.wikimedia.org/r/690583

gerritbot added a project: Patch-For-Review.May 13 2021, 5:26 PM
• Pchelolo closed this task as Resolved.Jun 25 2021, 5:05 PM

None of these in the last month. I guess some of the ActorStore work has fixed this.

gerritbot added a comment.Jun 25 2021, 5:05 PM

Change 690583 abandoned by Ppchelko:

[mediawiki/core@master] ActorStore: Try fetching actor id from primary before throwing

Reason:

Doesn't seem to be needed anymore.

https://gerrit.wikimedia.org/r/690583

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits