| CaitVirtue | |
| Feb 17 2021, 7:42 PM |
| F34110529: image.png | |
| Feb 17 2021, 7:42 PM |
| F34110531: image.png | |
| Feb 17 2021, 7:42 PM |
I'm not pasting any hard to read screenshots, as they have PII in them, but it's pretty much everything that does have data in it. The titles and text wrapping is awkward.
Also, I stole the title from T215802 -- As always feel free to retitle if I've missed the mark.
I checked out the first of these & sadly we really haven't had any $5k + gifts this week - so it''s legit empty - although I want to compare with how it would have looked before. I haven't checked the other 2
Aha, that makes sense! It's a good reminder that it's time for me to switch back to the $5k+ gifts this month dashlet. I use the "this week" dashlets in Q1 & 2.
@CaitVirtue - I dug into this a bit further. I've proposed a patch that make it clearer that a report with no results did actually run (https://github.com/civicrm/civicrm-core/pull/19668)
I also loaded up a demo site with sample data before and after the last change to compare - do the screenshots here look like the difference you are talking about
https://github.com/civicrm/org.civicrm.shoreditch/issues/484#issuecomment-785475714
This DOES seem to have been a by-product of the work we have commissioned on search kit - I'm trying to discuss plans to fix with people
Change 667698 had a related patch set uploaded (by Eileen; owner: Eileen):
[wikimedia/fundraising/crm/civicrm@master] Add test to report template saying no results found if that is the case
@Eileenmcnaughton Yes, that looks right to me....Does the title of the dashlet change to "empty"? Or is that text inside the dashlet fields instead?
Change 667698 merged by jenkins-bot:
[wikimedia/fundraising/crm/civicrm@master] Add text to report template saying no results found if that is the case
@CaitVirtue @DStrine so I *think* the main issue here was the confusing empty dashlets which should be solved now
As noted above there is a visual change on the other dashlets - how important is it to you for us to address that? It's a little tricky because we use the shoreditch theme and changes that we wanted in core threw out the shoreditch theme a bit. They would love us to give them some funding to adjust the shoreditch theme to reflect the core changes - but absent that it will likely be improved on some much longer timeframe. I can probably do something on just our site to improve it but they will almost certainly want to do it differently to whatever I come up with so I doubt I'd be able to upstream it.
Note link to visiual change screenshots https://github.com/civicrm/org.civicrm.shoreditch/issues/484#issuecomment-785475714
I can live with the formatting issues for now. Everything else looks good.
@NNichols Note that we should make dashlet titles as short as is reasonable, now that the text wrapping is wonky.
Change 673182 had a related patch set uploaded (by Eileen; owner: Eileen):
[wikimedia/fundraising/crm/civicrm@master] Add text to report template saying no results found if that is the case
Change 673182 merged by jenkins-bot:
[wikimedia/fundraising/crm/civicrm@master] Add text to report template saying no results found if that is the case