Page MenuHomePhabricator

Make public properties of Parser private
Open, Needs TriagePublic

Description

There are a number of public properties of Parser which need to be made private, as they will not exist on a Parser base class. They all have getter methods which should be used instead.

List of properties, all deprecated in 1.35 and which need to be actually removed/made private:

  • mTagHooks
  • mFunctionHooks
  • mMarkerIndex
  • mFirstCall
  • mPreprocessor
  • mOutput
  • mStripState
  • mLinkID
  • mIncludeSizes
  • mPPNodeCount
  • mGeneratedPPNodeCount
  • mHighestExpansionDepth
  • mHeadings
  • mDoubleUnderscores
  • mExpensiveFunctionCount
  • mShowToc
  • mUser
  • mOptions
  • mTitle
  • ot
  • mRevisionObject
  • mRevisionId
  • mRevisionTimestamp
  • mRevisionUser
  • mRevisionSize
  • mInputSize
  • mInParse

Details

ProjectBranchLines +/-Subject
mediawiki/extensions/DisplayTitleREL1_35+1 -1
mediawiki/coremaster+3 -2
mediawiki/coremaster+56 -24
mediawiki/extensions/ReplaceSetmaster+4 -1
mediawiki/extensions/Sparkmaster+1 -1
mediawiki/coremaster+6 -5
mediawiki/coremaster+5 -4
mediawiki/coremaster+3 -41
mediawiki/coremaster+6 -3
mediawiki/coremaster+4 -3
mediawiki/extensions/CharInsertmaster+2 -2
mediawiki/extensions/StringFunctionsEscapedmaster+30 -21
mediawiki/extensions/Newsmaster+1 -1
mediawiki/extensions/MsLinksmaster+1 -1
mediawiki/extensions/Mpdfmaster+1 -1
mediawiki/extensions/SemanticDrilldownmaster+2 -2
mediawiki/extensions/ParserFunmaster+1 -1
mediawiki/extensions/SemanticPageSeriesmaster+1 -1
mediawiki/extensions/Scribuntomaster+14 -14
mediawiki/extensions/Negrefmaster+1 -1
mediawiki/extensions/TemplateStylesmaster+0 -1
mediawiki/extensions/SmoothGallerymaster+2 -2
mediawiki/extensions/SemanticDrilldownmaster+3 -3
mediawiki/extensions/ApprovedRevsmaster+1 -1
mediawiki/extensions/PhpTagsmaster+2 -2
mediawiki/extensions/SemanticRatingmaster+4 -1
mediawiki/extensions/HierarchyBuildermaster+10 -10
mediawiki/extensions/TemplateStylesmaster+1 -1
mediawiki/extensions/ProofreadPagemaster+3 -3
mediawiki/extensions/PageInCatmaster+1 -1
mediawiki/extensions/RandomImageByCategorymaster+1 -1
mediawiki/extensions/BlueSpiceSocialmaster+6 -6
mediawiki/extensions/SyntaxHighlight_GeSHimaster+2 -2
mediawiki/extensions/Flowmaster+1 -1
mediawiki/extensions/HierarchyBuildermaster+10 -10
mediawiki/extensions/Mpdfmaster+1 -1
mediawiki/extensions/MsLinksmaster+1 -1
mediawiki/extensions/SemanticDrilldownmaster+2 -2
mediawiki/extensions/SemanticPageSeriesmaster+1 -1
mediawiki/extensions/SemanticRatingmaster+4 -1
mediawiki/extensions/PageFormsmaster+3 -3
mediawiki/extensions/MediaFunctionsmaster+7 -7
mediawiki/extensions/PhpTagsmaster+3 -3
mediawiki/extensions/TinyMCEmaster+1 -1
mediawiki/extensions/JsonDatamaster+1 -1
mediawiki/extensions/DisplayTitlemaster+1 -1
mediawiki/extensions/ParserFunctionsmaster+4 -4
mediawiki/extensions/JsonConfigmaster+3 -3
mediawiki/extensions/TemplateStylesmaster+1 -1
mediawiki/extensions/UseResourcemaster+4 -4
mediawiki/extensions/S5SlideShowmaster+1 -1
Show related patches Customize query in gerrit

Event Timeline

There are a very large number of changes, so older changes are hidden. Show Older Changes

Change 665228 had a related patch set uploaded (by C. Scott Ananian; owner: C. Scott Ananian):
[mediawiki/core@master] Remove Parser::$mConf

https://gerrit.wikimedia.org/r/665228

Change 665229 had a related patch set uploaded (by C. Scott Ananian; owner: C. Scott Ananian):
[mediawiki/extensions/ParserFunctions@master] Replace use of Parser::$mOutput, deprecated in 1.35

https://gerrit.wikimedia.org/r/665229

Change 665230 had a related patch set uploaded (by C. Scott Ananian; owner: C. Scott Ananian):
[mediawiki/extensions/SemanticDrilldown@master] Replace use of Parser::$mOutput, deprecated in 1.35

https://gerrit.wikimedia.org/r/665230

Change 665231 had a related patch set uploaded (by C. Scott Ananian; owner: C. Scott Ananian):
[mediawiki/extensions/ApprovedRevs@master] Replace use of Parser::$mOutput, deprecated in 1.35

https://gerrit.wikimedia.org/r/665231

Change 665205 merged by jenkins-bot:
[mediawiki/extensions/JsonConfig@master] Replace use of Parser::$mTagHooks, deprecated in 1.35

https://gerrit.wikimedia.org/r/665205

Change 665229 merged by jenkins-bot:
[mediawiki/extensions/ParserFunctions@master] Replace use of Parser::$mOutput, deprecated in 1.35

https://gerrit.wikimedia.org/r/665229

Change 665342 had a related patch set uploaded (by C. Scott Ananian; owner: C. Scott Ananian):
[mediawiki/core@master] WIP: Make Parser::$mOutput private

https://gerrit.wikimedia.org/r/665342

Change 665345 had a related patch set uploaded (by C. Scott Ananian; owner: C. Scott Ananian):
[mediawiki/extensions/DisplayTitle@master] Replace use of Parser::$mOutput, deprecated in 1.35

https://gerrit.wikimedia.org/r/665345

Change 665346 had a related patch set uploaded (by C. Scott Ananian; owner: C. Scott Ananian):
[mediawiki/extensions/JsonData@master] Replace use of Parser::$mOutput, deprecated in 1.35

https://gerrit.wikimedia.org/r/665346

Change 665347 had a related patch set uploaded (by C. Scott Ananian; owner: C. Scott Ananian):
[mediawiki/extensions/MediaFunctions@master] Replace use of Parser::$mOutput, deprecated in 1.35

https://gerrit.wikimedia.org/r/665347

Change 665348 had a related patch set uploaded (by C. Scott Ananian; owner: C. Scott Ananian):
[mediawiki/extensions/PhpTags@master] Replace use of Parser::$mOutput, deprecated in 1.35

https://gerrit.wikimedia.org/r/665348

Change 665349 had a related patch set uploaded (by C. Scott Ananian; owner: C. Scott Ananian):
[mediawiki/extensions/SmoothGallery@master] Replace use of Parser::$mOutput, deprecated in 1.35

https://gerrit.wikimedia.org/r/665349

Change 665350 had a related patch set uploaded (by C. Scott Ananian; owner: C. Scott Ananian):
[mediawiki/extensions/TinyMCE@master] Replace use of Parser::$mOutput, deprecated in 1.35

https://gerrit.wikimedia.org/r/665350

Change 665345 merged by jenkins-bot:
[mediawiki/extensions/DisplayTitle@master] Replace use of Parser::$mOutput, deprecated in 1.35

https://gerrit.wikimedia.org/r/665345

Change 665346 merged by jenkins-bot:
[mediawiki/extensions/JsonData@master] Replace use of Parser::$mOutput, deprecated in 1.35

https://gerrit.wikimedia.org/r/665346

Change 665350 merged by jenkins-bot:
[mediawiki/extensions/TinyMCE@master] Replace use of Parser::$mOutput, deprecated in 1.35

https://gerrit.wikimedia.org/r/665350

Change 665348 merged by jenkins-bot:
[mediawiki/extensions/PhpTags@master] Replace use of Parser::$mOutput, deprecated in 1.35

https://gerrit.wikimedia.org/r/665348

Change 665347 merged by jenkins-bot:
[mediawiki/extensions/MediaFunctions@master] Replace use of Parser::$mOutput, deprecated in 1.35

https://gerrit.wikimedia.org/r/665347

Change 665368 had a related patch set uploaded (by C. Scott Ananian; owner: C. Scott Ananian):
[mediawiki/core@master] Parser: initialize preprocessor in constructor

https://gerrit.wikimedia.org/r/665368

Change 665369 had a related patch set uploaded (by C. Scott Ananian; owner: C. Scott Ananian):
[mediawiki/extensions/TemplateStyles@master] Replace use of Parser::$mPreprocessor, deprecated in 1.35

https://gerrit.wikimedia.org/r/665369

Change 665372 had a related patch set uploaded (by C. Scott Ananian; owner: C. Scott Ananian):
[mediawiki/core@master] Make Parser::$mPreprocessor private

https://gerrit.wikimedia.org/r/665372

Change 665420 had a related patch set uploaded (by C. Scott Ananian; owner: C. Scott Ananian):
[mediawiki/extensions/Scribunto@master] Replace use of Parser::$mStripState, deprecated in 1.35

https://gerrit.wikimedia.org/r/665420

Change 665422 had a related patch set uploaded (by C. Scott Ananian; owner: C. Scott Ananian):
[mediawiki/extensions/ProofreadPage@master] Replace use of Parser::$mStripState, deprecated in 1.35

https://gerrit.wikimedia.org/r/665422

Change 665424 had a related patch set uploaded (by C. Scott Ananian; owner: C. Scott Ananian):
[mediawiki/extensions/CharInsert@master] Replace use of Parser::$mStripState, deprecated in 1.35

https://gerrit.wikimedia.org/r/665424

Change 665426 had a related patch set uploaded (by C. Scott Ananian; owner: C. Scott Ananian):
[mediawiki/extensions/Flow@master] Replace use of Parser::$mStripState, deprecated in 1.35

https://gerrit.wikimedia.org/r/665426

Change 665427 had a related patch set uploaded (by C. Scott Ananian; owner: C. Scott Ananian):
[mediawiki/extensions/SyntaxHighlight_GeSHi@master] Replace use of Parser::$mStripState, deprecated in 1.35

https://gerrit.wikimedia.org/r/665427

Change 665428 had a related patch set uploaded (by C. Scott Ananian; owner: C. Scott Ananian):
[mediawiki/extensions/TemplateStyles@master] Replace use of Parser::$mStripState, deprecated in 1.35

https://gerrit.wikimedia.org/r/665428

Change 665430 had a related patch set uploaded (by C. Scott Ananian; owner: C. Scott Ananian):
[mediawiki/extensions/BlueSpiceSocial@master] Replace use of Parser::$mStripState, deprecated in 1.35

https://gerrit.wikimedia.org/r/665430

Change 665431 had a related patch set uploaded (by C. Scott Ananian; owner: C. Scott Ananian):
[mediawiki/extensions/HierarchyBuilder@master] Replace use of Parser::$mStripState, deprecated in 1.35

https://gerrit.wikimedia.org/r/665431

Change 665432 had a related patch set uploaded (by C. Scott Ananian; owner: C. Scott Ananian):
[mediawiki/extensions/Mpdf@master] Replace use of Parser::$mStripState, deprecated in 1.35

https://gerrit.wikimedia.org/r/665432

Change 665433 had a related patch set uploaded (by C. Scott Ananian; owner: C. Scott Ananian):
[mediawiki/extensions/MsLinks@master] Replace use of Parser::$mStripState, deprecated in 1.35

https://gerrit.wikimedia.org/r/665433

Change 665435 had a related patch set uploaded (by C. Scott Ananian; owner: C. Scott Ananian):
[mediawiki/extensions/Negref@master] Replace use of Parser::$mStripState, deprecated in 1.35

https://gerrit.wikimedia.org/r/665435

Change 665436 had a related patch set uploaded (by C. Scott Ananian; owner: C. Scott Ananian):
[mediawiki/extensions/PageForms@master] Replace use of Parser::$mStripState, deprecated in 1.35

https://gerrit.wikimedia.org/r/665436

Change 665437 had a related patch set uploaded (by C. Scott Ananian; owner: C. Scott Ananian):
[mediawiki/extensions/PageInCat@master] Replace use of Parser::$mStripState, deprecated in 1.35

https://gerrit.wikimedia.org/r/665437

Change 665438 had a related patch set uploaded (by C. Scott Ananian; owner: C. Scott Ananian):
[mediawiki/extensions/ParserFun@master] Replace use of Parser::$mStripState, deprecated in 1.35

https://gerrit.wikimedia.org/r/665438

Change 665439 had a related patch set uploaded (by C. Scott Ananian; owner: C. Scott Ananian):
[mediawiki/extensions/PhpTags@master] Replace use of Parser::$mStripState, deprecated in 1.35

https://gerrit.wikimedia.org/r/665439

Change 665440 had a related patch set uploaded (by C. Scott Ananian; owner: C. Scott Ananian):
[mediawiki/extensions/RandomImageByCategory@master] Replace use of Parser::$mStripState, deprecated in 1.35

https://gerrit.wikimedia.org/r/665440

Change 665441 had a related patch set uploaded (by C. Scott Ananian; owner: C. Scott Ananian):
[mediawiki/extensions/ReplaceSet@master] Replace use of Parser::$mStripState, deprecated in 1.35

https://gerrit.wikimedia.org/r/665441

Change 665442 had a related patch set uploaded (by C. Scott Ananian; owner: C. Scott Ananian):
[mediawiki/extensions/SemanticDrilldown@master] Replace use of Parser::$mStripState, deprecated in 1.35

https://gerrit.wikimedia.org/r/665442

Change 665443 had a related patch set uploaded (by C. Scott Ananian; owner: C. Scott Ananian):
[mediawiki/extensions/SemanticPageSeries@master] Replace use of Parser::$mStripState, deprecated in 1.35

https://gerrit.wikimedia.org/r/665443

Change 665444 had a related patch set uploaded (by C. Scott Ananian; owner: C. Scott Ananian):
[mediawiki/extensions/SemanticRating@master] Replace use of Parser::$mStripState, deprecated in 1.35

https://gerrit.wikimedia.org/r/665444

Change 665445 had a related patch set uploaded (by C. Scott Ananian; owner: C. Scott Ananian):
[mediawiki/extensions/SemanticRating@master] Replace use of Parser::$mStripState, deprecated in 1.35

https://gerrit.wikimedia.org/r/665445

Change 665444 abandoned by C. Scott Ananian:
[mediawiki/extensions/SemanticRating@master] Replace use of Parser::$mStripState, deprecated in 1.35

Reason:
Abandoned in favor of Ia04f1aac1d8ae4ea16c98cfbbe72195fffe653b6

https://gerrit.wikimedia.org/r/665444

Change 665446 had a related patch set uploaded (by C. Scott Ananian; owner: C. Scott Ananian):
[mediawiki/extensions/SemanticPageSeries@master] Replace use of Parser::$mStripState, deprecated in 1.35

https://gerrit.wikimedia.org/r/665446

Change 665443 abandoned by C. Scott Ananian:
[mediawiki/extensions/SemanticPageSeries@master] Replace use of Parser::$mStripState, deprecated in 1.35

Reason:
Abandon in favor of I4a5bd64760cdde5b614a7d4e2b09e8d0634b2056

https://gerrit.wikimedia.org/r/665443

Change 665447 had a related patch set uploaded (by C. Scott Ananian; owner: C. Scott Ananian):
[mediawiki/extensions/SemanticDrilldown@master] Replace use of Parser::$mStripState, deprecated in 1.35

https://gerrit.wikimedia.org/r/665447

Change 665442 abandoned by C. Scott Ananian:
[mediawiki/extensions/SemanticDrilldown@master] Replace use of Parser::$mStripState, deprecated in 1.35

Reason:
Abandon in favor of If8ff2e21952b3f08d3a8950d42e2afb56973fb89

https://gerrit.wikimedia.org/r/665442

Change 665448 had a related patch set uploaded (by C. Scott Ananian; owner: C. Scott Ananian):
[mediawiki/extensions/MsLinks@master] Replace use of Parser::$mStripState, deprecated in 1.35

https://gerrit.wikimedia.org/r/665448

Change 665433 abandoned by C. Scott Ananian:
[mediawiki/extensions/MsLinks@master] Replace use of Parser::$mStripState, deprecated in 1.35

Reason:
Abandon in favor of I4b01017da752def982777c4fea5fad5e21e4c7ea

https://gerrit.wikimedia.org/r/665433

Change 665449 had a related patch set uploaded (by C. Scott Ananian; owner: C. Scott Ananian):
[mediawiki/extensions/Mpdf@master] Replace use of Parser::$mStripState, deprecated in 1.35

https://gerrit.wikimedia.org/r/665449

Change 665432 abandoned by C. Scott Ananian:
[mediawiki/extensions/Mpdf@master] Replace use of Parser::$mStripState, deprecated in 1.35

Reason:
Abandon in favor of Ic392afd1e93ae0003fd0ab65114ec1ff38bb2927

https://gerrit.wikimedia.org/r/665432

Change 665450 had a related patch set uploaded (by C. Scott Ananian; owner: C. Scott Ananian):
[mediawiki/extensions/HierarchyBuilder@master] Replace use of Parser::$mStripState, deprecated in 1.35

https://gerrit.wikimedia.org/r/665450

Change 665431 abandoned by C. Scott Ananian:
[mediawiki/extensions/HierarchyBuilder@master] Replace use of Parser::$mStripState, deprecated in 1.35

Reason:
Abandon in favor of I3676fe9882ce9de5732cb7230528134df544ff98

https://gerrit.wikimedia.org/r/665431

Change 665452 had a related patch set uploaded (by C. Scott Ananian; owner: C. Scott Ananian):
[mediawiki/extensions/Spark@master] Replace use of Parser::$mStripState, deprecated in 1.35

https://gerrit.wikimedia.org/r/665452

Change 665453 had a related patch set uploaded (by C. Scott Ananian; owner: C. Scott Ananian):
[mediawiki/core@master] WIP: Make Parser::$mStripState private

https://gerrit.wikimedia.org/r/665453

Change 665426 merged by jenkins-bot:
[mediawiki/extensions/Flow@master] Replace use of Parser::$mStripState, deprecated in 1.35

https://gerrit.wikimedia.org/r/665426

Change 665422 merged by jenkins-bot:
[mediawiki/extensions/ProofreadPage@master] Replace use of Parser::$mStripState, deprecated in 1.35

https://gerrit.wikimedia.org/r/665422

Change 665427 merged by jenkins-bot:
[mediawiki/extensions/SyntaxHighlight_GeSHi@master] Replace use of Parser::$mStripState, deprecated in 1.35

https://gerrit.wikimedia.org/r/665427

Change 665428 merged by jenkins-bot:
[mediawiki/extensions/TemplateStyles@master] Replace use of Parser::$mStripState, deprecated in 1.35

https://gerrit.wikimedia.org/r/665428

Change 665430 merged by jenkins-bot:
[mediawiki/extensions/BlueSpiceSocial@master] Replace use of Parser::$mStripState, deprecated in 1.35

https://gerrit.wikimedia.org/r/665430

Change 665440 merged by jenkins-bot:
[mediawiki/extensions/RandomImageByCategory@master] Replace use of Parser::$mStripState, deprecated in 1.35

https://gerrit.wikimedia.org/r/665440

Change 665437 merged by jenkins-bot:
[mediawiki/extensions/PageInCat@master] Replace use of Parser::$mStripState, deprecated in 1.35

https://gerrit.wikimedia.org/r/665437

Change 665445 merged by jenkins-bot:
[mediawiki/extensions/SemanticRating@master] Replace use of Parser::$mStripState, deprecated in 1.35

https://gerrit.wikimedia.org/r/665445

Change 665439 merged by jenkins-bot:
[mediawiki/extensions/PhpTags@master] Replace use of Parser::$mStripState, deprecated in 1.35

https://gerrit.wikimedia.org/r/665439

Change 665231 merged by jenkins-bot:
[mediawiki/extensions/ApprovedRevs@master] Replace use of Parser::$mOutput, deprecated in 1.35

https://gerrit.wikimedia.org/r/665231

Change 665230 merged by jenkins-bot:
[mediawiki/extensions/SemanticDrilldown@master] Replace use of Parser::$mOutput, deprecated in 1.35

https://gerrit.wikimedia.org/r/665230

Change 665349 merged by jenkins-bot:
[mediawiki/extensions/SmoothGallery@master] Replace use of Parser::$mOutput, deprecated in 1.35

https://gerrit.wikimedia.org/r/665349

Change 665369 merged by jenkins-bot:
[mediawiki/extensions/TemplateStyles@master] Replace use of Parser::$mPreprocessor, deprecated in 1.35

https://gerrit.wikimedia.org/r/665369

Change 665420 merged by jenkins-bot:
[mediawiki/extensions/Scribunto@master] Replace use of Parser::$mStripState, deprecated in 1.35

https://gerrit.wikimedia.org/r/665420

Change 665435 merged by jenkins-bot:
[mediawiki/extensions/Negref@master] Replace use of Parser::$mStripState, deprecated in 1.35

https://gerrit.wikimedia.org/r/665435

Change 665446 merged by jenkins-bot:
[mediawiki/extensions/SemanticPageSeries@master] Replace use of Parser::$mStripState, deprecated in 1.35

https://gerrit.wikimedia.org/r/665446

Change 665438 merged by jenkins-bot:
[mediawiki/extensions/ParserFun@master] Replace use of Parser::$mStripState, deprecated in 1.35

https://gerrit.wikimedia.org/r/665438

Change 665447 merged by jenkins-bot:
[mediawiki/extensions/SemanticDrilldown@master] Replace use of Parser::$mStripState, deprecated in 1.35

https://gerrit.wikimedia.org/r/665447

Change 665449 merged by jenkins-bot:
[mediawiki/extensions/Mpdf@master] Replace use of Parser::$mStripState, deprecated in 1.35

https://gerrit.wikimedia.org/r/665449

Change 665448 merged by jenkins-bot:
[mediawiki/extensions/MsLinks@master] Replace use of Parser::$mStripState, deprecated in 1.35

https://gerrit.wikimedia.org/r/665448

Change 665207 merged by jenkins-bot:
[mediawiki/extensions/News@master] Replace use of Parser::$mTagHooks, deprecated in 1.35

https://gerrit.wikimedia.org/r/665207

Change 665219 merged by jenkins-bot:
[mediawiki/extensions/StringFunctionsEscaped@master] Replace use of Parser::$mFunctionHooks, deprecated in 1.35

https://gerrit.wikimedia.org/r/665219

Change 665424 merged by jenkins-bot:
[mediawiki/extensions/CharInsert@master] Replace use of Parser::$mStripState, deprecated in 1.35

https://gerrit.wikimedia.org/r/665424

Change 665203 merged by jenkins-bot:
[mediawiki/core@master] Make Parser::$mTagHooks private

https://gerrit.wikimedia.org/r/665203

Change 665220 merged by jenkins-bot:
[mediawiki/core@master] Make Parser::$mFunctionHooks private

https://gerrit.wikimedia.org/r/665220

Change 665228 merged by jenkins-bot:
[mediawiki/core@master] Remove Parser::$mConf

https://gerrit.wikimedia.org/r/665228

Change 665342 merged by jenkins-bot:
[mediawiki/core@master] Make Parser::$mOutput private

https://gerrit.wikimedia.org/r/665342

Change 665452 merged by jenkins-bot:
[mediawiki/extensions/Spark@master] Replace use of Parser::$mStripState, deprecated in 1.35

https://gerrit.wikimedia.org/r/665452

Change 665441 merged by jenkins-bot:
[mediawiki/extensions/ReplaceSet@master] Replace use of Parser::$mStripState, deprecated in 1.35

https://gerrit.wikimedia.org/r/665441

Change 665368 merged by jenkins-bot:
[mediawiki/core@master] Parser: initialize preprocessor in constructor

https://gerrit.wikimedia.org/r/665368

Change 665372 merged by jenkins-bot:
[mediawiki/core@master] Make Parser::$mPreprocessor private

https://gerrit.wikimedia.org/r/665372

Change 674336 had a related patch set uploaded (by Cicalese; owner: C. Scott Ananian):
[mediawiki/extensions/DisplayTitle@REL1_35] Replace use of Parser::$mOutput, deprecated in 1.35

https://gerrit.wikimedia.org/r/674336

Change 674336 merged by jenkins-bot:
[mediawiki/extensions/DisplayTitle@REL1_35] Replace use of Parser::$mOutput, deprecated in 1.35

https://gerrit.wikimedia.org/r/674336