Page MenuHomePhabricator
Create Task
Maniphest T275198

Transcluding Special:RecentChanges causes an internal error when Flow is installed
Closed, ResolvedPublic
Actions

Description

Running MediaWiki 1.35.1. Full version: https://stampy.ai/wiki/index.php/Special:Version

I have the main page of my wiki set up to transclude Special:RecentChanges. This works fine when I disable Flow, but enabling it causes the main page to be replaced by:

MediaWiki internal error.

Original exception: [cf1ce95f3412291a42a9e5a7] [no req] MWException from line 6237 of /var/www/html/wiki/includes/parser/Parser.php: Parser state cleared while parsing. Did you call Parser::parse recursively? Lock is held by: #0 /var/www/html/wiki/includes/parser/Parser.php(620): Parser->lock()
#1 /var/www/html/wiki/includes/content/WikitextContent.php(374): Parser->parse()
#2 /var/www/html/wiki/includes/content/AbstractContent.php(590): WikitextContent->fillParserOutput()
#3 /var/www/html/wiki/includes/Revision/RenderedRevision.php(263): AbstractContent->getParserOutput()
#4 /var/www/html/wiki/includes/Revision/RenderedRevision.php(235): MediaWiki\Revision\RenderedRevision->getSlotParserOutputUncached()
#5 /var/www/html/wiki/includes/Revision/RevisionRenderer.php(215): MediaWiki\Revision\RenderedRevision->getSlotParserOutput()
#6 /var/www/html/wiki/includes/Revision/RevisionRenderer.php(152): MediaWiki\Revision\RevisionRenderer->combineSlotOutput()
#7 [internal function]: MediaWiki\Revision\RevisionRenderer->MediaWiki\Revision\{closure}()
#8 /var/www/html/wiki/includes/Revision/RenderedRevision.php(197): call_user_func()
#9 /var/www/html/wiki/includes/Storage/DerivedPageDataUpdater.php(1315): MediaWiki\Revision\RenderedRevision->getRevisionParserOutput()
#10 /var/www/html/wiki/includes/Storage/PageUpdater.php(752): MediaWiki\Storage\DerivedPageDataUpdater->getCanonicalParserOutput()
#11 /var/www/html/wiki/includes/page/WikiPage.php(2015): MediaWiki\Storage\PageUpdater->saveRevision()
#12 /var/www/html/wiki/includes/EditPage.php(2457): WikiPage->doEditContent()
#13 /var/www/html/wiki/includes/EditPage.php(1724): EditPage->internalAttemptSave()
#14 /var/www/html/wiki/includes/EditPage.php(680): EditPage->attemptSave()
#15 /var/www/html/wiki/includes/actions/EditAction.php(71): EditPage->edit()
#16 /var/www/html/wiki/includes/actions/SubmitAction.php(38): EditAction->show()
#17 /var/www/html/wiki/includes/MediaWiki.php(527): SubmitAction->show()
#18 /var/www/html/wiki/includes/MediaWiki.php(313): MediaWiki->performAction()
#19 /var/www/html/wiki/includes/MediaWiki.php(940): MediaWiki->performRequest()
#20 /var/www/html/wiki/includes/MediaWiki.php(543): MediaWiki->main()
#21 /var/www/html/wiki/index.php(53): MediaWiki->run()
#22 /var/www/html/wiki/index.php(46): wfIndexMain()
#23 {main}
Backtrace:
#0 /var/www/html/wiki/includes/parser/Parser.php(620): Parser->lock()
#1 /var/www/html/wiki/extensions/Flow/includes/Conversion/Utils.php(234): Parser->parse()
#2 /var/www/html/wiki/extensions/Flow/includes/Conversion/Utils.php(67): Flow\Conversion\Utils::parser()
#3 /var/www/html/wiki/extensions/Flow/includes/Model/AbstractRevision.php(433): Flow\Conversion\Utils::convert()
#4 /var/www/html/wiki/extensions/Flow/includes/Parsoid/ContentFixer.php(41): Flow\Model\AbstractRevision->getContent()
#5 /var/www/html/wiki/extensions/Flow/includes/Templating.php(157): Flow\Parsoid\ContentFixer->getContent()
#6 /var/www/html/wiki/extensions/Flow/includes/Formatter/RevisionFormatter.php(947): Flow\Templating->getContent()
#7 /var/www/html/wiki/extensions/Flow/includes/Formatter/RevisionFormatter.php(896): Flow\Formatter\RevisionFormatter->processParam()
#8 /var/www/html/wiki/extensions/Flow/includes/Formatter/RevisionFormatter.php(237): Flow\Formatter\RevisionFormatter->buildProperties()
#9 /var/www/html/wiki/extensions/Flow/includes/Formatter/ChangesListFormatter.php(167): Flow\Formatter\RevisionFormatter->formatApi()
#10 /var/www/html/wiki/extensions/Flow/includes/Hooks.php(600): Flow\Formatter\ChangesListFormatter->getTimestampLink()
#11 /var/www/html/wiki/extensions/Flow/includes/Hooks.php(582): Flow\Hooks::modifyChangesListLine()
#12 /var/www/html/wiki/includes/HookContainer/HookContainer.php(320): Flow\Hooks::onEnhancedChangesListModifyBlockLineData()
#13 /var/www/html/wiki/includes/HookContainer/HookContainer.php(131): MediaWiki\HookContainer\HookContainer->callLegacyHook()
#14 /var/www/html/wiki/includes/HookContainer/HookRunner.php(1710): MediaWiki\HookContainer\HookContainer->run()
#15 /var/www/html/wiki/includes/changes/EnhancedChangesList.php(714): MediaWiki\HookContainer\HookRunner->onEnhancedChangesListModifyBlockLineData()
#16 /var/www/html/wiki/includes/changes/EnhancedChangesList.php(824): EnhancedChangesList->recentChangesBlockLine()
#17 /var/www/html/wiki/includes/changes/EnhancedChangesList.php(118): EnhancedChangesList->recentChangesBlock()
#18 /var/www/html/wiki/includes/specials/SpecialRecentChanges.php(482): EnhancedChangesList->recentChangesLine()
#19 /var/www/html/wiki/includes/specialpage/ChangesListSpecialPage.php(1666): SpecialRecentChanges->outputChangesList()
#20 /var/www/html/wiki/includes/specialpage/ChangesListSpecialPage.php(678): ChangesListSpecialPage->webOutput()
#21 /var/www/html/wiki/includes/specials/SpecialRecentChanges.php(172): ChangesListSpecialPage->execute()
#22 /var/www/html/wiki/includes/specialpage/SpecialPage.php(600): SpecialRecentChanges->execute()
#23 /var/www/html/wiki/includes/specialpage/SpecialPageFactory.php(635): SpecialPage->run()
#24 /var/www/html/wiki/includes/specialpage/SpecialPageFactory.php(693): MediaWiki\SpecialPage\SpecialPageFactory->executePath()
#25 /var/www/html/wiki/includes/parser/Parser.php(3144): MediaWiki\SpecialPage\SpecialPageFactory->capturePath()
#26 /var/www/html/wiki/includes/parser/PPFrame_Hash.php(253): Parser->braceSubstitution()
#27 /var/www/html/wiki/includes/parser/Parser.php(2887): PPFrame_Hash->expand()
#28 /var/www/html/wiki/includes/parser/Parser.php(1556): Parser->replaceVariables()
#29 /var/www/html/wiki/includes/parser/Parser.php(651): Parser->internalParse()
#30 /var/www/html/wiki/includes/content/WikitextContent.php(374): Parser->parse()
#31 /var/www/html/wiki/includes/content/AbstractContent.php(590): WikitextContent->fillParserOutput()
#32 /var/www/html/wiki/includes/Revision/RenderedRevision.php(263): AbstractContent->getParserOutput()
#33 /var/www/html/wiki/includes/Revision/RenderedRevision.php(235): MediaWiki\Revision\RenderedRevision->getSlotParserOutputUncached()
#34 /var/www/html/wiki/includes/Revision/RevisionRenderer.php(215): MediaWiki\Revision\RenderedRevision->getSlotParserOutput()
#35 /var/www/html/wiki/includes/Revision/RevisionRenderer.php(152): MediaWiki\Revision\RevisionRenderer->combineSlotOutput()
#36 [internal function]: MediaWiki\Revision\RevisionRenderer->MediaWiki\Revision\{closure}()
#37 /var/www/html/wiki/includes/Revision/RenderedRevision.php(197): call_user_func()
#38 /var/www/html/wiki/includes/Storage/DerivedPageDataUpdater.php(1315): MediaWiki\Revision\RenderedRevision->getRevisionParserOutput()
#39 /var/www/html/wiki/includes/Storage/PageUpdater.php(752): MediaWiki\Storage\DerivedPageDataUpdater->getCanonicalParserOutput()
#40 /var/www/html/wiki/includes/page/WikiPage.php(2015): MediaWiki\Storage\PageUpdater->saveRevision()
#41 /var/www/html/wiki/includes/EditPage.php(2457): WikiPage->doEditContent()
#42 /var/www/html/wiki/includes/EditPage.php(1724): EditPage->internalAttemptSave()
#43 /var/www/html/wiki/includes/EditPage.php(680): EditPage->attemptSave()
#44 /var/www/html/wiki/includes/actions/EditAction.php(71): EditPage->edit()
#45 /var/www/html/wiki/includes/actions/SubmitAction.php(38): EditAction->show()
#46 /var/www/html/wiki/includes/MediaWiki.php(527): SubmitAction->show()
#47 /var/www/html/wiki/includes/MediaWiki.php(313): MediaWiki->performAction()
#48 /var/www/html/wiki/includes/MediaWiki.php(940): MediaWiki->performRequest()
#49 /var/www/html/wiki/includes/MediaWiki.php(543): MediaWiki->main()
#50 /var/www/html/wiki/index.php(53): MediaWiki->run()
#51 /var/www/html/wiki/index.php(46): wfIndexMain()
#52 {main}

Exception caught inside exception handler: [cf1ce95f3412291a42a9e5a7] [no req] MWException from line 165 of /var/www/html/wiki/includes/FauxRequest.php: Request URL not set
Backtrace:
#0 /var/www/html/wiki/includes/skins/SkinTemplate.php(1092): FauxRequest->getRequestURL()
#1 /var/www/html/wiki/includes/skins/SkinTemplate.php(379): SkinTemplate->buildContentNavigationUrls()
#2 /var/www/html/wiki/includes/skins/SkinTemplate.php(127): SkinTemplate->prepareQuickTemplate()
#3 /var/www/html/wiki/includes/skins/SkinTemplate.php(144): SkinTemplate->generateHTML()
#4 /var/www/html/wiki/includes/OutputPage.php(2615): SkinTemplate->outputPage()
#5 /var/www/html/wiki/includes/exception/MWException.php(193): OutputPage->output()
#6 /var/www/html/wiki/includes/exception/MWException.php(231): MWException->reportHTML()
#7 /var/www/html/wiki/includes/exception/MWExceptionHandler.php(104): MWException->report()
#8 /var/www/html/wiki/includes/exception/MWExceptionHandler.php(185): MWExceptionHandler::report()
#9 /var/www/html/wiki/includes/MediaWiki.php(576): MWExceptionHandler::handleException()
#10 /var/www/html/wiki/index.php(53): MediaWiki->run()
#11 /var/www/html/wiki/index.php(46): wfIndexMain()
#12 {main}

I've removed the transclusion on the main page for now, which also stops the issue.

Related Objects

Event Timeline

Plex248 created this task.Feb 19 2021, 11:13 AM
Restricted Application added a project: Growth-Team. · View Herald TranscriptFeb 19 2021, 11:13 AM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
Plex248 updated the task description. (Show Details)Feb 19 2021, 11:20 AM
Plex248 updated the task description. (Show Details)
MBinder_WMF added a project: Growth-Team-Filtering.Apr 15 2021, 6:47 PM
• matmarex closed this task as Resolved.Sep 18 2023, 5:01 PM
• matmarex subscribed.

I can't reproduce this. Unfortunately, I have no idea when or how it was fixed.

(I am fairly sure that it's fixed, and it's not just me reproducing it wrong, because I just found another similar issue that is definitely fixed: T35740)

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits