is not valid HTML
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Inductiveload
	Feb 19 2021, 6:24 PM

Description

The watchlist links diff and hist are mis-nested HTML: they are a <DIV> within a <SPAN>:

<span class="mw-changeslist-line-inner" data-target-page="Wikisource:Scriptorium">  
  <div class="mw-changeslist-links">
    ....links
  </div>
  ....
</span>

This is invalid HTML, since it's a block element inside an inline one. The W3C validator reports this as an Error.

Details

	Subject	Repo	Branch	Lines +/-
	Avoid misnesting div in span in OldChangesList	mediawiki/core	master	+1 -1

Customize query in gerrit

Related Objects

Mentioned In: T59886: Support special page transclusion

Event Timeline

Inductiveload created this task.Feb 19 2021, 6:24 PM

Restricted Application added a project: Growth-Team. · View Herald TranscriptFeb 19 2021, 6:24 PM

Restricted Application added a subscriber: Aklapper. · View Herald Transcript

Inductiveload updated the task description. (Show Details)Feb 19 2021, 6:26 PM

Aklapper renamed this task from Watchlist "diff | hist" links are misnested to Watchlist "diff | hist" links are misnested: <DIV> within a <SPAN> is not valid HTML.Feb 20 2021, 11:10 AM

The same goes for the search settings area: mw-advancedSearch-searchPreview and mw-advancedSearch-namespacesPreview.

Spans-in-div outlined in red:

@Inductiveload: That's Advanced-Search; this task is about MediaWiki-Watchlist only.

MBinder_WMF added a project: Growth-Team-Filtering.Apr 15 2021, 6:47 PM

This appears to be happening with Special:RecentChanges/25 as of today. See https://en.wikipedia.org/w/index.php?title=User:Jonesey95/sandbox&oldid=1199013916 for an example.

Jonesey95 mentioned this in T59886: Support special page transclusion.Jan 25 2024, 9:19 PM

matmarex subscribed.Jan 25 2024, 9:32 PM

Change 993048 had a related patch set uploaded (by Arlolra; author: Arlolra):

[mediawiki/core@master] Avoid misnesting div in span in OldChangesList

https://gerrit.wikimedia.org/r/993048

gerritbot added a project: Patch-For-Review.Jan 25 2024, 10:40 PM

Change 993048 merged by jenkins-bot:

[mediawiki/core@master] Avoid misnesting div in span in OldChangesList

https://gerrit.wikimedia.org/r/993048

Maintenance_bot removed a project: Patch-For-Review.Jan 26 2024, 2:30 AM

ReleaseTaggerBot added a project: MW-1.42-notes (1.42.0-wmf.16; 2024-01-30).Jan 26 2024, 3:00 AM

matmarex closed this task as Resolved.Jan 26 2024, 2:54 PM

matmarex assigned this task to Arlolra.

MSantos added projects: Content-Transform-Team-WIP, Essential-Work.Feb 8 2024, 10:07 PM

	F34115747: 2021-02-20_203313_714x130_screenshot.png
	Feb 20 2021, 8:33 PM

	F34114088: Screenshot_2021-02-19 Showing results for contents of text-input area - Nu Html Checker.png
	Feb 19 2021, 6:26 PM

Watchlist "diff | hist" links are misnested: <DIV> within a <SPAN> is not valid HTMLClosed, ResolvedPublicActions

Description

Details

Related Objects

Event Timeline

Watchlist "diff | hist" links are misnested: <DIV> within a <SPAN> is not valid HTML
Closed, ResolvedPublic
Actions