Page MenuHomePhabricator

iwlinks.iwl_prefix should be the same length as interwiki.iw_prefix
Closed, ResolvedPublic

Description

According to the documentation, interwiki.iw_prefix is varbinary(32), while iwlinks.iwl_prefix is only varbinary(20). This may result in truncated interwiki prefixes in the iwlinks table and bugs such as this query where the prefix should be archlinux-service-agreements, but instead it is truncated to archlinux-service-ag.

Event Timeline

Reedy renamed this task from iwl_prefix has inconsistent length on MySQL to iwlinks.iwl_prefix should be the same length as interwiki.iw_prefix.Feb 19 2021, 8:50 PM
Reedy updated the task description. (Show Details)

Change 665454 had a related patch set uploaded (by Reedy; owner: Reedy):
[mediawiki/core@master] WIP: Extend iwlinks.iwl_prefix to length 32

https://gerrit.wikimedia.org/r/665454

Change 665454 merged by jenkins-bot:
[mediawiki/core@master] Extend iwlinks.iwl_prefix to VARBINARY(32) on MySQL

https://gerrit.wikimedia.org/r/665454

Wonder if we should backport this to 1.35 too...

Change 666698 had a related patch set uploaded (by Reedy; owner: Reedy):
[mediawiki/core@REL1_35] Extend iwlinks.iwl_prefix to VARBINARY(32) on MySQL

https://gerrit.wikimedia.org/r/666698

Change 666698 merged by jenkins-bot:
[mediawiki/core@REL1_35] Extend iwlinks.iwl_prefix to VARBINARY(32) on MySQL

https://gerrit.wikimedia.org/r/666698

Reedy claimed this task.