Page MenuHomePhabricator
Create Task
Maniphest T275253

GlobalWatchlist should set mobile targets
Closed, ResolvedPublic1 Estimated Story Points
Actions

Description

Currently when viewed on mobile, rather unhelpfully the page renders "This special page requires JavaScript to work" however I don't see any reason why it should.

To fix this you'll need to add on all modules:

"targets": [ "desktop", "mobile" ]

This should be a blocker for rolling this out into production. All new extensions should be mobile friendly by default.

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
Enable all ResourceLoader modules on mobile toomediawiki/extensions/GlobalWatchlistmaster+8 -4
Customize query in gerrit

Event Timeline

Jdlrobson created this task.Feb 19 2021, 10:40 PM
Restricted Application added a project: User-DannyS712. · View Herald TranscriptFeb 19 2021, 10:40 PM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
DannyS712 updated the task description. (Show Details)Feb 20 2021, 12:41 AM
gerritbot added a comment.Feb 20 2021, 12:42 AM

Change 665391 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/extensions/GlobalWatchlist@master] Enable all ResourceLoader modules on mobile too

https://gerrit.wikimedia.org/r/665391

gerritbot added a project: Patch-For-Review.Feb 20 2021, 12:42 AM
DannyS712 claimed this task.Feb 20 2021, 12:43 AM
DannyS712 moved this task from Backlog to In progress on the MediaWiki-extensions-GlobalWatchlist board.
DannyS712 moved this task from Unsorted to Awaiting review and deployment on the User-DannyS712 board.
DannyS712 set the point value for this task to 1.
gerritbot added a comment.Feb 20 2021, 2:48 AM

Change 665391 merged by jenkins-bot:
[mediawiki/extensions/GlobalWatchlist@master] Enable all ResourceLoader modules on mobile too

https://gerrit.wikimedia.org/r/665391

ReleaseTaggerBot added a project: MW-1.36-notes (1.36.0-wmf.32; 2021-02-23).Feb 20 2021, 3:00 AM
Maintenance_bot removed a project: Patch-For-Review.Feb 20 2021, 3:10 AM
DannyS712 closed this task as Resolved.Feb 20 2021, 10:41 PM
DannyS712 moved this task from In progress to Done on the MediaWiki-extensions-GlobalWatchlist board.
DannyS712 set Final Story Points to 1.
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits