Tied in with that, the global variable $wgPageFormsPartialPath seems unnecessary.
This corresponds to item #7 in the "Page Forms review checklist" task (T183213).
Yaron_Koren | |
Feb 22 2021, 4:31 PM |
F34160789: image.png | |
Mar 15 2021, 5:55 AM |
F34160792: image.png | |
Mar 15 2021, 5:55 AM |
Tied in with that, the global variable $wgPageFormsPartialPath seems unnecessary.
This corresponds to item #7 in the "Page Forms review checklist" task (T183213).
Hi @Yaron_Koren, I've a doubt regarding this task, previously $wgPageFormsPartialPath was '/extensions/PageForms' and together with $wgScriptPath, it generated 'mediawiki-1.35.1/extensions/PageForms' that was nothing but $wgPageFormsScriptPath. Now, when I added $wgExtensionAssetsPath instead of $wgScriptPath and removed $wgPageFormsPartialPath completely, $wgPageFormsScriptPath became 'mediawiki-1.35.1/extensions/', it was running perfectly fine, so I'm not sure whether '/PageForms' is required or not.
For reference, I am uploading the screenshots of both cases-
@Yashvarhsney - I admire your enthusiasm, but please hold off on doing any more microtasks; I want to leave some for other potential students as well.
Ok I'll definitely hold, it's quite interesting to do the tasks. Meanwhile, I'll explore more about PageForms and read the documentation.
Change 675561 had a related patch set uploaded (by Swathi kasikala; author: Swathi kasikala):
[mediawiki/extensions/PageForms@master] added wgExtensionAssetsPath to PF_Hooks
Change 676575 had a related patch set uploaded (by Anjali041; author: Anjali041):
[mediawiki/extensions/PageForms@master] Used wgExtensionAssetsPath and removed variable
Change 675561 merged by jenkins-bot:
[mediawiki/extensions/PageForms@master] added wgExtensionAssetsPath to PF_Hooks
Change 676575 abandoned by Yaron Koren:
[mediawiki/extensions/PageForms@master] Used wgExtensionAssetsPath and removed variable
Reason:
Sorry - this patch was almost correct (the spacing was a little off), but someone else submitted a fully correct patch first. You got the idea right, though.