Page MenuHomePhabricator

Warnings break rendering of BlueSpiceCalumma
Open, Needs TriagePublic

Description

Using current master of BlueSpiceCalumma I am seeing various warnings when rendering the Chamelon skin - all of which originate in BlueSpiceCalumma.

Test URL: https://skins-demo.wmflabs.org//wiki/Help:Sample_page?useformat=desktop&useskin=chameleon

( ! ) Warning: Invalid argument supplied for foreach() in /vagrant/mediawiki/skins/BlueSpiceCalumma/src/PanelFactory.php on line 58

( ! ) Warning: uasort() expects parameter 1 to be array, null given in /vagrant/mediawiki/skins/BlueSpiceCalumma/src/PanelFactory.php on line 120

( ! ) Warning: Invalid argument supplied for foreach() in /vagrant/mediawiki/skins/BlueSpiceCalumma/src/Components/Logo.php on line 26

( ! ) Warning: Invalid argument supplied for foreach() in /vagrant/mediawiki/skins/BlueSpiceCalumma/src/Components/FeaturedActions.php on line 24

Copy of Chameleon issue 220.

Event Timeline

should be fixed. can someone tell me how this systems are updated?

I'm now getting a fatal:

[463852053bc9011f2c36b6ac] /w/index.php TypeError: Argument 2 passed to wfArrayPlus2d() must be of the type array, null given, called in /vagrant/mediawiki/extensions/BlueSpiceFoundation/src/Foundation.php on line 149

Backtrace:

from /vagrant/mediawiki/includes/GlobalFunctions.php(2875)
#0 /vagrant/mediawiki/extensions/BlueSpiceFoundation/src/Foundation.php(149): wfArrayPlus2d(array, NULL)
#1 /vagrant/mediawiki/extensions/BlueSpiceFoundation/src/Foundation.php(115): BlueSpice\Foundation->overwriteGlobals()
#2 /vagrant/mediawiki/extensions/BlueSpiceFoundation/src/Foundation.php(49): BlueSpice\Foundation->initialize()
#3 /vagrant/mediawiki/includes/Setup.php(821): BlueSpice\Foundation::BlueSpice\{closure}()
#4 /vagrant/mediawiki/includes/WebStart.php(87): require_once(string)
#5 /vagrant/mediawiki/index.php(44): require(string)
#6 /var/www/w/index.php(5): require(string)
#7 {main}

When I address that I'm getting ( ! ) Warning: Invalid argument supplied for foreach() in /vagrant/mediawiki/skins/BlueSpiceCalumma/src/Components/Logo.php on line 26

it seems like, the BlueSpiceFoundation is missing one of its required libraries:
https://github.com/wikimedia/mediawiki-extensions-BlueSpiceFoundation/blob/master/composer.json#L27

The Warning is legit. I will fix that

i could not find any issue with that code. What branch is used for this system?
We only support REL1_31, REL1_35 and somewhat master

I am trying to use with the latest MediaWiki master. I don't expect it to work perfectly but was hoping it wouldn't fatal :)